From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2052.outbound.protection.outlook.com [40.107.15.52]) by sourceware.org (Postfix) with ESMTPS id DC1D53858C54 for ; Fri, 10 Mar 2023 09:40:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DC1D53858C54 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h8wJ046+yBCpkF0obcWAPzoGh75TrVqxSgncs2XfP094VWK6Cjr7/cFMmfW89VWhvSeCYnsBUiiT0uS40dw9q/1sCxvZBHO7qADoWkfap9zXwd77hoZPNPg53TS4Nh6TfKFpEulyiVW0bi5Fo4GlwicePhPL8DCEVEIPL6ze/71jTJYg8F2d99a7Nt7rCn5hTgNVg4oAWyHS8HPJMxl69KdTTPHzW6M184kEhc/XieA3kjifD72RbeWOkLhUP8Z1hCJZInUAZNK9QIrazT9sdBXpjLIGdYmv9DeyIG/GSLfQV7kFSkrNdto7AqwahreJV467fiZYRLWkhdwEz/uxVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hN31FS8Fgqe/9CPabcuhIduAlWCudyFUUmlZnfWAa68=; b=PzQ67bPz7FleGLJJt8qvKywqttE46P1/cuByqdH9hvWmy4IqHF3Y8IBcH72ftve/YDUNVHsc+H2bLyWmRPX6umA98fSEoe6VNN5tdo7a2n3sWAQLQb4qWVcL2/NNoY69vKmpDu9wxuWZ8Wsb7Bmdss5FLDD+XgPl4SkPNEVv1XBgUW6rk5nXYfeQpN1KTohYufXdqsUEDMC9a/VOQU4CHO4rhdKZ+P8iUS23CwGpdHlBiZTLgZoaAs9PMlP8mhRxy+ORHUvBRoM6J/BSzqOnd7Ju6rbr6M6QBu/NHEWfSq7OIx32JiA1k4tokgvAfqAQAhbpHzdbeX8Bbr+nN7DO8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hN31FS8Fgqe/9CPabcuhIduAlWCudyFUUmlZnfWAa68=; b=m1Vcu1kpbepxdYzE+2qdBDkKLn1vHAy2+FfcLmJRDiFlHMTFtIOXxAFJqWv2JLpIC8XIj8DRgDnI75DhqGcWjruC4mPKpIFh9BcV6KsCAms04A2XbhqUf3dA3PXgVvX3gW2Kvsteo86ECubuoCJLw2tSbaS8kestI99UFe1hYzhCeGDUqj8b4UisV/9CrFwXjvo+9sf6lh3vKSdjx6le6ccsL6Pm/IakRzy2jeuoT1ygRA+7P7bMIQ521Py4UQeM8wjmdunI7+10lS7P2JQ+eeXvayhoGBI0qoG84cV2GnG2nde+AxNIYG3v7qxqxJgryb0t8JuLKLJgOAw/FbIuJA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6857.eurprd04.prod.outlook.com (2603:10a6:10:114::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.19; Fri, 10 Mar 2023 09:40:19 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%5]) with mapi id 15.20.6178.019; Fri, 10 Mar 2023 09:40:19 +0000 Message-ID: <9f769d26-f51c-4f85-f61b-330226c1cc2d@suse.com> Date: Fri, 10 Mar 2023 10:40:16 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH RFC] RISC-V: alter the special character used in FAKE_LABEL_NAME Content-Language: en-US To: Nick Clifton , Alan Modra Cc: Palmer Dabbelt , Andrew Waterman , Jim Wilson , Nelson Chu , Binutils References: <150b4184-62af-3f5c-c07b-24b0c2ae788f@suse.com> From: Jan Beulich In-Reply-To: <150b4184-62af-3f5c-c07b-24b0c2ae788f@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0122.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DB8PR04MB6857:EE_ X-MS-Office365-Filtering-Correlation-Id: 15df66d9-8669-4038-8911-08db214b75fb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TLKyj0FGK8P3/8b3BzFh3gEjU8XTX2fSFacsIZc/CKppsl8iGFNT+cX0ZmALkPhj1pE2we+i9LcjQg1IXohxImRlhswYy0PlocBcw5laS5OBaz26Y6gdqXgidMj+oZECo+hEqygB5x60YmcJt2QdGnQ0SzgP+UK6oLqqKBkpue+s75NGpLVCxZ35DQ50WggZe7Q0epbRu53LD/SAqoaR47ZaG8/Qqg+M4FdLkimnEw4YKBJAyVeYB+W7Lk8TD2lW9QHJYwHFxkLdv6GD7hDemcw6ckxweN/ktdjOGx8coxwX767tDVVCcGr4wy4xuNA64VhcgAUPQ0xp5I24iZ15/ljZr5U0fO0T8iaTfT9YPiswu3DBuUpCuMS0Gd3ayhIv9WxDiRFcTKGIqrWoE/bNNY78r5SUIFrpG8f+jrhaxZU85ywihp+ZTwhVjF8UFaYh9Xn3n5KWSkgBbH/EMi92YQFE/yXW1Okm/6eIIw8flJ3qeuYb9aXuXZFUK3K5e/BGC9L/ExywDbUi5z9zvVVgwAof3RRqctjfH7diFoof5GUHYmlmtS3fdq4kkbFPYKkNc6mfWC1h0L0u+78m+xVC55eSNKHZKUQc9OMZk1VJ8MWqf3AuYb1OZ73StI+KTeClhrMII8M/g48mBZdfY5wUDei59LOlOZFs7cbMm5GvFRWHj0YhstWNsFbaCfwmpqiJTV+hIN2+xFniOBhzRMfNqD5RFjuudw9Fc7rfz3V3aXM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(136003)(346002)(366004)(396003)(39860400002)(451199018)(4744005)(5660300002)(8936002)(41300700001)(36756003)(86362001)(31696002)(2906002)(38100700002)(186003)(83380400001)(478600001)(6666004)(6512007)(2616005)(53546011)(6506007)(31686004)(26005)(4326008)(8676002)(6486002)(66946007)(66556008)(66476007)(54906003)(110136005)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUdka3A4YkQ4NC9UMEtoNDdjSk1xMjBYN1RldVR5QWJJVDV4QmthMXJQSGNL?= =?utf-8?B?c3hhcFZON05ZaUFvRGg3SlQyeTYxSWFqQ08vTFlMOUd2T1psdmFsYXRTeUhT?= =?utf-8?B?OVcrckwybDVJMzRpRHovQjBtVHIwZmViTnFsWUdvOWhCZDZFdlVydHJrdUxz?= =?utf-8?B?RWZKM3B5Vnh2NXNERzFLQU9jbWhkQXpFRzNNbzVzRUhheVMwT0ZqaG5QcHhz?= =?utf-8?B?SXFvNEtNNytlSjlhY2swUFQxdi9BbWxUM25iOVVyS0FNZEZQRUxwcmF1VXA3?= =?utf-8?B?MytXMnNhTmd4algwWTZsSStyRkVCUWNCUFF0Q2tXL0UzVEk3MDRlRE1NZE9i?= =?utf-8?B?QVRmcjAyc3hJb1VTRFZqZ3ROeTRsV24zYW9PVGowTlVpcDRSaVp6Wncwd1Ey?= =?utf-8?B?d0tObUltbVFnSm02K1RXMlYxZUtEcGoyaDhuVEc5emFybWRmcmlwYU5zNnZt?= =?utf-8?B?ZEpLanl0Mm1NeXNQMWhJQzRzOTNFV0dvMC9wQ0YvelEzc3JhM2l6RWxIZysz?= =?utf-8?B?QUI3SWMvZCtUbm5NOHRTYTRNT09OOUhVWm1naEpSTGxzOC91SDJTV0ZhTDln?= =?utf-8?B?clpOa0NCajVzTGVjN00zRW91cHNRcGdKdG81aDBFL2l4YmxSYU0zbitTM1Ez?= =?utf-8?B?RFBmbzdtc2Q2TkJuNVZIdmRFYXJNaWZmMDNaQTJtbStxckt0VzMyQjQvVlFJ?= =?utf-8?B?eVd3SDhkRGlaVFdRL2poaUM0NHlMV1ppZW1rREwwVFhUY1NLWmNHelRHV1pE?= =?utf-8?B?OW5SVTVUbVpId2lVdVNRWjd4aHNWaUtIR2VyZWhMdWdiNTJHVkhjWnRXVkZi?= =?utf-8?B?TlV6bVFHY0MzaVdPNmJxSVJVTGpjTE1ZbklmUGNlSjc5NVR0Z3k0WVE3MXJV?= =?utf-8?B?eXoxSWhrUXdzSVBmTUxjQjlmelBBVEdYRTh0dmxmRVdUV1RhRmZLdTBuc1Fx?= =?utf-8?B?dDdaTXNhck54NmwvRWZqL2N4ZkJONVZSaHllMmU0OXBOaUVqbGdiUlkzUm03?= =?utf-8?B?R1ZZeVJpQ0tCOXN2bXRHOE9RTGd1OW5TNzlSL2cwWWZQZjRrbkNyNG43WWFx?= =?utf-8?B?RlRPME8zcnQ3Q3E4ODViMUpqcVlMeFcxNlNORzhpM0RjZGNSU0pMa0JCVjEw?= =?utf-8?B?RzZWZDM5T081ZkppaE9MUS9zRm92aUVWNll3NEpYdERvTzV0YlpBUEFFS3lw?= =?utf-8?B?VlNXWitic0Z4OGNLaUtjNUk2MWd0bHQzVDIrVHpZcXBpQ3pKNi95MjE2ekVX?= =?utf-8?B?VWcyd3lHUnNjQlVPY0FBcHB1QW1vT2h1MldFUGdzRy85V0pFdWlGWnFUQzJL?= =?utf-8?B?R1ZyVkhDRjVMdnlBbEd6ekhXOWdLNEluUmlwTWZ2YjBqdzFGYm9ueHoxS1lS?= =?utf-8?B?ZGplcnJmZkhkNy9BdTB4RmVHVE1jTzdMT0RIQ1hINXJ0OEtTUGRWSldXdkFX?= =?utf-8?B?ejQ3ZStkQ2huWWJKRGNsaHVjR1plOWM3Vm1vRFlyTG82OHduTmV3V3pXQzM3?= =?utf-8?B?dGZkejd1akNMVFJJeXFGKzliVHZaZEIvakZCeW5uYjlKU3NmdVRMd1pLRDVt?= =?utf-8?B?SUFkalJKNjNjMG9TMjkyZUw0TzlsZXhuY0NyRnNyZklJMmVzNWdabzBiVHph?= =?utf-8?B?NTlJc0xMOXl4TkczUUFScDdncFp3UGlpSEpxSEphVEF1SDM2VS91TFhWa3la?= =?utf-8?B?eDhUWEt0UHhVRVBDMFhTb2t0a2NMK2pySzJmbTVPTlp3OWN1WjN4ZGhFTWNw?= =?utf-8?B?c0RTQWlsYmxhQTZITEdHNmxnMS83TGsxQ0tMM3duV2lNTUZLaXdmbUdqVk15?= =?utf-8?B?R3RiN3BDRUNJQ0k4QWtzRCtXNGlDOGNTWWdFbTdLQXVnRXNtaFVYa3N5eU15?= =?utf-8?B?azNnWllNaDl4N1BHMFdJckROVy9LTWxXdVE3OXJvY1cyRUk3dnNMbjdwUmpV?= =?utf-8?B?NFpaSmxTcG90emg3UjFpRHNaMUpKY3NkSUh4M2pHOHRRWXZ4ZEVuVTRhNGtk?= =?utf-8?B?bjh4SHVxczh6bDZlaEJzbkxkcGwxVHlYWm9ZSGlOVXRzSDNmbE1VVFc1MGJR?= =?utf-8?B?dlBodXJXQktYZU9zTzlJN0FhQjBUSVV4aEdNTlRKbGwwaXRRaEVrQVU4d2Vm?= =?utf-8?Q?a5wGSjXQov23j3ecCuWCbjMRy?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15df66d9-8669-4038-8911-08db214b75fb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 09:40:19.0770 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G2qgqgv+KnKIq65umTvKcUf/IZeGtPGDv2M5FTNB153wN50VZrc3gw7LvNgkSR4FvlfRuvO0he+Is4kIls44aw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6857 X-Spam-Status: No, score=-3028.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Nick, Alan, On 10.03.2023 10:36, Jan Beulich via Binutils wrote: > Considering the special casing of FAKE_LABEL_CHAR in read_symbol_name() > and get_symbol_name() I wonder in how far LOCAL_LABEL_CHAR and/or > DOLLAR_LABEL_CHAR don't also need recognizing there (and then also be > marked in lex[] just like done here). I can't point out a specific case > though where there could be a problem. > > The checking for *_LABEL_CHAR in S_IS_LOCAL() looks to collide with uses > of these characters in quoted symbol names. while the rest of the open questions is RISC-V specific, these two items are not, and since from the title I suppose you may not notice the generic aspects here, I thought I'd point them out explicitly. Just in case you have any thoughts there (if you don't, I'm not sure how to progress). Thanks, Jan