From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2042.outbound.protection.outlook.com [40.107.20.42]) by sourceware.org (Postfix) with ESMTPS id C908E3858D33 for ; Wed, 8 Nov 2023 11:49:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C908E3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C908E3858D33 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.20.42 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699444182; cv=pass; b=vSx1fpoNGtCZEFlHt+wItMdJBZ9zeTN9Oltq7OdfoNwBqVbjXyx23o+gALZtifxrfQEMYFtwPMwdMOhLr/T1rvFLDPRp7DsMPhgjaQjTOY9LW401mAE1ocEgxonb5SqAN54M5uu6QHEfNidtjmWEfIh4cHHXyvGjCg4YtYyDDYk= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1699444182; c=relaxed/simple; bh=VC/+2GWkLM4wv1jEc/tOtpQLcj3D5MCgUe8AAOahrb0=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=OeOiC/1wk/G0Tv/cYE0DmUtFHxc6o4i8/TKvjL2Xg2DKKcDDPyOAvaszLusZGnRm+droDYI6ue/R7W1k/pmo9iogg47kiAnrAzInKgmAWYwMBAiZym2jOp6qdNXO6MbcEEytADReIrzXOYV5sSux7G1Mt58bUrkjQCywu0wAdTE= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c84hsTLK4G74DBCAQ5gofbPV9I4Q0DTPNGmGMhkRvEr6R4DYV1BGfNyuT/jxPc0ggkqwZ97IFiXomGpOqcIK+XjGGUpR9yRfuDDuKBqmast0w5L6C7ZW98jMUOayzscDfXlq6L4gP9FtaOvPJIpDfjGNtiByZWLUka6/GZbp25UmyQy5JDIe3wnBxKVsiUejWHdSjJhD/miFdTW6BLjZA/AWhjk54K4nePeXtRktFVDtuvbL/lHJs94Qvw8pzl9cDsIaviot5jVe4zbTkEEHiedxRKE2nPzRxE46LI4AgPC83ta+qiJLdjNewlFoNxjEha4niAJbFukXBChlEhMPIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CHJEhQwLgE8zBNWXrqFLQyibB155pZoGEVM/A0YzSgs=; b=KNrK3Wr5OyLaVxIG4t1MA2QDodjha+FWY7uf3wxK2vSGOM0n17Gbh5E7Al4n8uvft4rJ7RUkvIgS5WOW75H0E9g6j2bRGDZCIFWI/u3w3lp23AtfBk8eyXseBDzomP+mScF3hTmH60v0EMYwWEHq8xZPURnsp9nLr017kOTliO2wZePoZTFhj96wHqaZZvsTer/a2wTsfTdq/hAd7t3N7mLZmWH5L2epNsOJ4J4dECX+OCgL7FxDRIIT0BaLencqqkqO34mfz7jKkuH1LM5n7Qln4E0q1d9LU2NCHZi4+Yq6u5QBlT5vtq4JDL44D0AxpsYjD9+wbw5ED+QN/wEuow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CHJEhQwLgE8zBNWXrqFLQyibB155pZoGEVM/A0YzSgs=; b=NuSeE981n4blnjzb31dTV3Bv5rOCtiagzet30xJXI5CLYOiMV0BKlzRaldoAez3jHne1kp2PzYDPnmPh0Vr1QigwgcNH+5Zzzf1b0R3LJr1uVRcvEiBSE6AG9aswIVtGaSfcyQwRX+eCMw1Gsua0o+DVdYv4Px0Q+TFQgjzVLTy0UL1gBM0rpICGdHJ34xIyKAZPSY7nxmbEW53Dh2+UOZocXHxiZeTlfqUqELKVA+P0+swV3ekeZIuQxvgOeHLds0dXuwI3Su5GpKrLsx+8V4RNKZO8vEmWl3SCEM9hsgkyM0kXfePFc/HMA+gXY5g3X4g4juRoTowYakH4obXXAg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) by VI1PR04MB7008.eurprd04.prod.outlook.com (2603:10a6:803:13b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6977.18; Wed, 8 Nov 2023 11:49:38 +0000 Received: from DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44]) by DU2PR04MB8790.eurprd04.prod.outlook.com ([fe80::eb8e:fa24:44c1:5d44%3]) with mapi id 15.20.6977.018; Wed, 8 Nov 2023 11:49:38 +0000 Message-ID: <9f796886-fadf-e875-88ad-3cfef1848c9e@suse.com> Date: Wed, 8 Nov 2023 12:49:36 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v3 0/2] x86: insn template CPU specifier processing Content-Language: en-US To: "Cui, Lili" Cc: "H.J. Lu" , Binutils References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0146.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:98::7) To DU2PR04MB8790.eurprd04.prod.outlook.com (2603:10a6:10:2e1::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8790:EE_|VI1PR04MB7008:EE_ X-MS-Office365-Filtering-Correlation-Id: 921613d1-d45d-41b9-8d51-08dbe050c94a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sRjdFopxitXymOxYTMuyUFe/kkXI+2qClfs3tCZaqr2qWVVb5QWS6RFE1G8syKeJP8O0Gkv3qqE7LpVopR4bUxSDNGYQBHedkJ49svWR283ZX1tkNKIJy5bKeqAk6PThNUp9wTl0QWY36P0iZboKNKpI7x90bhT56gS2G15f6I5g99iW8YYjz/R/W5KQuveaRvAGUsciOz5ZrxZOv21ooBayd7PO/nFo22+cVmxqCph/dg15vwsPtTmwjrFox06DKRoBUGKvDeDknDmzYwY77hLtYEqPCKaBfWfTUqHi3/jX8MTz9FRFtaI1+jqS7w4IxHCAbkjYH+hVVJEK9KZebL6ozMgUW08ka0ywpkIM9eanCJQFx6SPdREEJExkjoeX7fDdcPvMzu4vclmPEiR71kvE2rGT2jNBs/nQWwcmiwGiKjjefkb3oCdxiKE/fIBun7XWsffFhj2YrWF8rjkO5klB/9wtpLCUBXLwNtYcmGmWU31Kxdy/hshptnYzegCExPwH1WYYGlE7PZGbKdMuIJDGtrzaOmAw+jL8ApD4uPaKldxUhlD2SSBkVUSkDiCfphvK7F/R/k3kWH0KDH1gW2oKmaXCN6B7YAK0UNvj/VHXJleoqgTIJxZS6f+Hb0098X1VZ2K/nEWYINiZrbJi8A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8790.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(346002)(376002)(136003)(39860400002)(366004)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(36756003)(8676002)(8936002)(4326008)(83380400001)(66476007)(54906003)(26005)(66556008)(66946007)(6916009)(316002)(2906002)(5660300002)(6486002)(966005)(6506007)(478600001)(53546011)(6512007)(2616005)(31686004)(31696002)(38100700002)(86362001)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGVXS3pOTG95NlFkenRqcXpSRGpwOHNYLzM2Vk83Z1dsSnFmQWx6c3d3QU00?= =?utf-8?B?TXZLdXhoS0gva1lsaEd0Q0JZaFhFcTBOZHZJVjB6RUh2dkVzVzZtdmdpRGRI?= =?utf-8?B?U2lrcUQrTjJ6TUFtSWFkMDIzbXNteW1CQlVnd2l1NUN5SUtsZVlUK1Zsak14?= =?utf-8?B?SE5YVEY1d1hIOTNuaDVvbEw0YXRDRlNoTjlvZmpxZmFIT2grTy9KSnBPL2RK?= =?utf-8?B?ZThxKzNsbkcrUWxGSHNMK21yZVhleWUwejhhRXpYM1FHUmFyaGNXS3k4UHZW?= =?utf-8?B?b1FZVmJKWTBUa2JFL0tTd3czbmxwR3FQTzdJNGNOT3V6Q3N2VmFUandUWVhI?= =?utf-8?B?LzFESS9uSTlDN2pSZ2lTSk81R0RLMWxpNm9ORTF6NVE1a0hNVnJFdXpJbXRC?= =?utf-8?B?YkpGL09uZ280N0wrdlNXL3g3NTE2RmlZWGpmdW1pZmlma1c0QWkwZEZ2OVhy?= =?utf-8?B?S2hWbXZPQnNINE1TeXdCT1Z4OWR6ZCtudFFYdzA3T2VROFlselRrK2ZnTFov?= =?utf-8?B?bTBnRi92ck9NZG5VUXZnajF1Y1Fzemk3WmZpOXFRSUtGS1Nzb2ZrYzJMMWVQ?= =?utf-8?B?RzZRYldPM1crb2UvOS9PUzI1dytqWFdmVzBNSkR2d1RNMVVPQ3QxMXFsZVkw?= =?utf-8?B?SEdZbkJIdnkxbEFLTE9MdlFpS3ZFMERQSFNLZU96WHBPNHo4ZmxSQm1NVjJz?= =?utf-8?B?UGo5QU9ZOEJ4SndPc1FLLzlZbTVsRVQ2SG1mZW1rMDV6Q2o4djdoUlJPU1pE?= =?utf-8?B?SStucFhEN2ZhS3E4UWF2K2tySEg3aHJma1dXTllpbFlGb3JHU1o4cEt6VnRl?= =?utf-8?B?V0RJMU9VUHJ6Z0c3cEl3RlJEbHRtVzZIU0hjbFJSUVhFa01XT2cvVjZYVDZy?= =?utf-8?B?WlBvOWNDbVduczNVQytBMzc1WUQvZ3Q4cks0S2xyeTFtZWNHS0g0T2RSU21D?= =?utf-8?B?K09zWjBpemRVVmQvRjFreEtIRWJOMWZrdGJ2bHhuYkowWktFT0FRNHN1ZzJw?= =?utf-8?B?K1VzenRRNWMxNjZkb1Rrd0tJWDM4TVRaTWM5dkdRdE5WdTNBaThYRFhGWWho?= =?utf-8?B?WEF6VzhFOFM3Y3k4aTZaL0s3VXRFU0VyUkpodjE4NXRjRkpVRnd0WTVOR2JJ?= =?utf-8?B?TVBhUm9ZR1RJOHhPRWEwRzVUOGhUOFdEMW0wcmhNcHJOMkNNeDB5aDNpeGEy?= =?utf-8?B?S2IxRWN5RXFPcjVUMTJMYmJhdTNDOFgxS3FlWkN6eUFsVlFrSTJRS3l2Qkwv?= =?utf-8?B?cC9OS1lpMm5uSUdIZlFRa09FUUNxVzdNSG41SlY3TFdKRDZEdXUvN3VaeC94?= =?utf-8?B?QkcwZUpoTHZEVk9HUmNaM01Zb2NIVEVVKzJib2xrZkwwVDlKN2RFdERoaGtL?= =?utf-8?B?blBraUhCR3ZxYnNqVFZJUUxmNVEvZ2pEUXNsWWZSbXQzUmR4STZEcmdKclhV?= =?utf-8?B?UjRwSkNFeW9iS0NPYVZYWWlIZzIzNTE3TXdwR0wwcURVeXlQZzNJZ1pYcVNV?= =?utf-8?B?U29VTWR6SzY3VDBaOHBGZ2w5N2huY3VNaHFMMlY2RkNBeHlBSkhFcUduV0Ju?= =?utf-8?B?ZjdueG5PNURXOXYzOS81STdHelVxMEdWYnBJM0JTaTBLRHluc2lMbVRSMng2?= =?utf-8?B?N28xaUQzb0FVRmNaZzJzOWc3bk43L0FubFkvdlBvby9vd2o0Y3Vyb3NiMnJH?= =?utf-8?B?dnJwd3pYZm05eVppc25WclA0RTJKWU1DL2JyT0dTc3VRY0I2NTJyNFZHVzZY?= =?utf-8?B?RVJUS0ErT1h5cnJqU0M2SURFWkpDZUhXRjZBQ3UxTUxFZ1N0ejFtdGJHM1Uv?= =?utf-8?B?RlpPei9pQ1ljZmllSVBaZWJZbGFrODRncndYalpCVzFEd2Vxemp4OHVZTHRK?= =?utf-8?B?SWtVWGc2UHhoeU5KV0o0ZHFSblZ5djlNUUNzMTBPN0JhZmJMc0pUNWZOTnFS?= =?utf-8?B?QU1PK0swcGlWSGtaZHRCaFNuWExhcUZudXd6ZXhmMFVwd1pjeWZLUExCOXVE?= =?utf-8?B?bEtzNjBkQU5Ndm16akxDdHhoRmQyNmpzOFdXR0xuK2Y5andLbzZmVUVSRE8y?= =?utf-8?B?Zk9VOUpidFo0ZVNYK2xocmtsNzNBZ1MyOUNPdEFuM1NINmJyTE1TVWZyUEZh?= =?utf-8?Q?3SLQyF2BrAfaH8E/3fNolxDiT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 921613d1-d45d-41b9-8d51-08dbe050c94a X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8790.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2023 11:49:38.3038 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GMk2TSnedpyHr0DVYcOy6W8qrk5puxOK1kIqdu9C1cyewTGzHDgwyWlsnypE0bOy6MBQexgf3knsCn54tS80Lg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7008 X-Spam-Status: No, score=-3028.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 08.11.2023 12:43, Cui, Lili wrote: >> Subject: [PATCH v3 0/2] x86: insn template CPU specifier processing >> >> This continues to be in particular in preparation for APX. >> >> 1: Cpu64 handling improvements >> 2: split insn templates' CPU field >> >> While only noticeable in generated files, this goes on top of "x86: >> Intel Core processors do not support CMPXCHG16B" [1]. (Guess how I noticed >> that other issue.) >> >> The 1st patch is new in v3, and it being placed first allows what is now the 2nd >> patch here to be shrunk some. >> >> Jan >> >> [1] https://sourceware.org/pipermail/binutils/2023-November/130372.html > > Hi Jan, > > I adapted the apx patch based on these 3 patches and they work fine, but I still have two issues. They are all in install_template. > > 1. We need to clear i.tm.opcode_modifier.evex = 0 or i.tm.opcode_modifier.vex = 0 for all merged insn, I found that output_insn also needs to use i.tm.opcode_modifier.evex. We need to add the cpu id here for each new merge (VEX and EVEX), which looks a bit ugly. Now I just add AMX for it. > > > if ((maybe_cpu (t, CpuAVX) || maybe_cpu (t, CpuAVX2) || maybe_cpu (t, CpuAMX_TILE) > || maybe_cpu (t, CpuFMA)) > && (maybe_cpu (t, CpuAVX512F) || maybe_cpu (t, CpuAVX512VL) || maybe_cpu (t, CpuAPX_F))) I specifically mentioned already that this may want tidying as the set grows. We can do that up front if you're concerned, or afterwards. I don't, however, understand how this is connected to you saying "I found that output_insn also needs to use i.tm.opcode_modifier.evex". > 2. The assertion below blocks AMX insns and I need to remove it. > else > { > //gas_assert (!i.tm.cpu.bitfield.isa); > i.tm.cpu.bitfield.isa = i.tm.cpu_any.bitfield.isa; > } I had asked about this already in reply to one of the patches, also pointing out that removing the assertion is problematic. By you not explaining what the problem is, I still can't figure how this is getting in the way of AMX. Specifically in that case, what are the values of both fields upon entry into this block? Jan