From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2041.outbound.protection.outlook.com [40.107.20.41]) by sourceware.org (Postfix) with ESMTPS id 110C6385416D for ; Thu, 27 Oct 2022 06:45:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 110C6385416D Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O/8T2F6QEWbVUc4nIwhWMpxPj1WSty0FsRhlHnPdTkidBxFRTuAgintJw7l4ZUNZpqZg0Fh9CSPPnI4xyELDmxYgOj0ndy4n+AkX7lKIPoOcLpFZ6CWNiVkEHqBO7/S6hqckAOGmxdfE5SX6/JPzCe5E+nDSam6o/n9X0n4kvfbtE3sq+qqzxDUUv+Exq8+NCVFFY91wxy+gxKHnj5I0zrIKXoP/Ap3SbqPMttWY4pJCztgm/JkJj+7Zp3/JV3dZyESJHRrCvaAx52qMbBgdrlxN3y0o89+TV76Dh3BXTip/6lLSp3gVXr3n3A0CPs/LlEf0F6J46W5cXjYaPh1vIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kfz0gi/uMlCuUdBSnRtpDrxyWVAoDzLQZg4SbMYLuBU=; b=ILFgKOaA+fGOh1IPTYfbIdX9OiQfUpQNJhXMc+mlNpk/kiGcyTj5oI6KHf3czGgF84VlUrI1YPpZKo1w1rDsqvSf1spmrfDtTinH1AGtLvrM+dDaIW8d35fDOczZ4GpOk83TboCq/iskUb41NshsEQqAKIT61ByzhPth/FQXR/OLwEPTW8W1H3ytItbeuErdM+qBZ/lxxa9n5fium7pVtqCyuCjVizrtkuVPL44X0xD/W4CJJNx1P8nv5udcwbgWYQxtXzKP084zirtqei4502mAdMMVTDEsLOqY4w9w3/84CRvtVPgTek/IYSSlhYi2kb6etbzUBfBeijpgDSpv2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kfz0gi/uMlCuUdBSnRtpDrxyWVAoDzLQZg4SbMYLuBU=; b=hSwyi0vopnAxCf4oVoi67gxG1MNYXjt3m47TjajNog7JGDN5Jkmhi8+c5HhJvELfdDlCj6DkEnyxFUvtXtuAPsb+zLSshwYYp5UfAJ61Bc8kIog3F5zkRFb2HmQIJPCPU1nVR2fsOz+ZhRsc+svqmp/xOfIrPjRG8qMrmg0E67qkqUIsGlrdRhTEOpKp0kvrrN7vnaPgffxguAXuLt7muuSK44bOYNF6hAe5/N6zspARgtYAfsFcDlEO3ZkwPLf8v0Z9D8CvL2sTHdvOEHOO7GOhp+ffGc96Zv07SH8JZnKqCv75msawagrR1ciLDwDAx1kL2LasFjZLwLGqyA2oHQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8343.eurprd04.prod.outlook.com (2603:10a6:20b:3f1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5746.21; Thu, 27 Oct 2022 06:45:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5746.021; Thu, 27 Oct 2022 06:45:09 +0000 Message-ID: <9f7cfcd0-36aa-91d0-dfd6-462b69c41ac7@suse.com> Date: Thu, 27 Oct 2022 08:45:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 10/10] Support Intel PREFETCHI Content-Language: en-US To: "Cui, Lili" Cc: "binutils@sourceware.org" , "Jiang, Haochen" , "H.J. Lu" References: <20221014091248.4920-1-haochen.jiang@intel.com> <20221014091248.4920-11-haochen.jiang@intel.com> <0aa4d551-e9ab-5e09-4f94-c672b7724915@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0090.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB8343:EE_ X-MS-Office365-Filtering-Correlation-Id: c899ad80-f3a9-4d5e-8083-08dab7e6ca40 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oTLjNssyJ5Z1xjZyVzDjlPhCimqSP70XVfjZ7ZfqCXLUN4/V23iT5+MVXXDZUWkxP6UxF3KqVNi+SVN5nfWSfEkVEx2Glor5GxpFwbc7r5iCwwAtDRvvymExLuiGNXWnN+vq1OYJLKrzPYAFqjjNMEQuXDk+vD7hyYSzHv3+LPIy1YLGwr2WFcMDU/I62JT8DiTVJW0swdgtGoISUBm7Qt0Qit8suxqTN1vt346iWcVSXETbBdnwL0yVQDlmqQvErv26EAsOCF3w59VDayHQzNFhLQo9nUl1HpxDCfS8T9bTBeGOdG8UEdNoDZlSb3G2KaIbRz0e8orBvF0AdJ2MMOxuk5SgPca96RGhu6C1YmOMq3oxpJwa3IiyAOI3ktl2BL3FmxBQid/9cMJe+F/vpG6VXOj87rmJKvvcjatlLRWNf7NtxysQUwmIp8AjAckXBggG/J+UCP/Kq2IjCOh/ZFY18nzGpNtAfn3lmQO1lQpH02fmqq1Z2658fmHKjJQdvqU90w3gdU3dof8cZSJjLni73oZHRfBNzwzoZoAmtXto4Pt6c7Z77sBAUGbVBIHGi1Pe0wPh7rYaAkialC12Eu+ELxrd6Ybu3CN9nArWHIHD5mq4E/bPx5nCF8CFf9pbN11T4LYftw6bmkcCG3Azy8lYTu0RMVDKYnOAgejTLah58bcJvMFQY95nMGQj446XcqNCgQo7bnWjs7HuXBMsdaHoaSl06fpryeiVx13BRxeUcgxiR/zaMNxm+fScU1g/Ta4HqT+aJhfMp8CtToiuvrGCsVhIk18XJQxPgRg/zPE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(376002)(396003)(346002)(366004)(136003)(451199015)(66946007)(6506007)(8676002)(66476007)(66556008)(4326008)(54906003)(6916009)(36756003)(316002)(83380400001)(38100700002)(8936002)(31696002)(26005)(41300700001)(86362001)(6512007)(2906002)(2616005)(4744005)(5660300002)(186003)(6486002)(31686004)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aThMd2puRDNZOE5WaTJDQXpIOEdQTklwZHJ4a1czRUNXTlg3Y2liL0NoYWhI?= =?utf-8?B?OG9OWnlQQS9oU2R4M21iU21YOUhqOG9lWnhrMnJ5WXJuUU9YQW5WVk40dWRy?= =?utf-8?B?c3BsZjBnblc5elRwQmpEbVBJa0huU3kwMG1UY0d5RVFRT1psNmkyWG12bmY4?= =?utf-8?B?RG1KaTAzWkY2SlZSRFdjQW9hVE9jcTJ6RVVEV0pJeXpueWZJUGRhVUVqbk04?= =?utf-8?B?SWxvd0NqODdxcWljUW1UREFhd2dDOUt5Nzc0T1NjNXc2YU50eUIwUlBkVTlt?= =?utf-8?B?YXRxeVN4aDlTZnA3NkVNeGNXT1VpaTU4RDFjcjZUSHkzUUlzdXVPQ3B3TEQy?= =?utf-8?B?VnJtT2hSaUNQSU00WGxSSGxYZjF5S3ZVNkExZVNrMit0ckQ5YkxNamlXRTRY?= =?utf-8?B?WTZsbWs5dHc0NzlUUklQRzlTSW5kUDNEYWFSUkJCSEVET0F2YTRMenZvMGtD?= =?utf-8?B?OXh4ZlE4NzlZZlBTY3cxSTFmMmkvMTA0dWxWSGZvTkUzRkxZOXdVaXJ3UmlN?= =?utf-8?B?NnpLdWpkQ0l1dE5qVVp3SG5hSUFCNDQ1Sjd1c3ZReDdSQkxvc0tzVG91YWJh?= =?utf-8?B?MlNvblBTMnNXT1RTNlN0dG4veUNoTU5NRDJTdnlkcU9xcEkyMjZ0SVhpVnZ4?= =?utf-8?B?S2wwRkVIazRweEV5ais3SHZKbUFyc3MyK0Y3cS9qREphZ2UyME5BSmFqQVZ5?= =?utf-8?B?NndZa2t5ZURiSWlTck1wam56OURGc0RETk9LUnVmdXNTeWdiU2Z4REFodm0z?= =?utf-8?B?cFUyWmFBY3VYVXNxbGtLVWhqenRTSVpFWWJ6c0Y3Y1pUdHlidTMybk5qekIx?= =?utf-8?B?RTNlekx1MHFhalJ4L1FCemhFU2pydVpKTElVVnlQRmJ6RlJ4UjVKNS9reW5Z?= =?utf-8?B?L0RScFJ4RVNYTG84dlFLWGZiaGt3d1k1L0JzMXlCWHFaVC9xU3IrcHRzRkVu?= =?utf-8?B?d1Y1NFdGYWJpYVVjVlNPOWwva0JaZUdieTlwRlc0NkF2SFI2a1hLakNSMmUr?= =?utf-8?B?aGlLOGpFdmR4RjlMNk1LZXZmT0J1SlAxcm10bDl1QkEvZHJDZVpoV3NRT2dS?= =?utf-8?B?QmVoZHd5WkpMK25hc05xaDBBOHQ0RUhzTG1jZkNnVUN3cWdLdEVCUDlJd20y?= =?utf-8?B?Zm5aeTllZWxRVXpNVktTWUIwZk93UHk3Z3FOMk9EdVJMYksvZ3ZnQkJzZnBu?= =?utf-8?B?SWt5ZTFnNHMxbGUzVlVEZ2VXZE5uakNvVFFjV21Cck5EMHhFdnRvM29vaGh3?= =?utf-8?B?bVFKZFBZN2tzU2ZGRUp3Z2J3THZ2elV0UVRzQ0gzcjZxV01JY0E0RVB5enQx?= =?utf-8?B?VkFmaFI0R0MvU285U2d5QU1MczBpM05DL3ArTUs5MDBYc2l6eWluaUFTOHc1?= =?utf-8?B?QjgzK0pubmlISnUxem4wMzlHOHFKUGhaeWx3djB6K1pJUCtSMDJJdGFERGI0?= =?utf-8?B?eHl5SjNRQ29IMGxzaEF4eFl4UnQvb1EyZW5TUlRXWlI3ZlJBa2diNTZiM1pi?= =?utf-8?B?YnZWSERoZ1JkLzZFcWhzOEVHRG45QW5aeDViU2ZXejZjTTBJelRqUmJqankv?= =?utf-8?B?c1l0N2piSzJoUDE3bkgySVpkWW00TTVsaFZ6djZ6dGxHMXJxM1NDK3dXWjBs?= =?utf-8?B?SGpsS0VYeEJDZmszSVlwT1loeHBaTWluRE9RUWlCbVE5LzRyWVVybE1lNlJN?= =?utf-8?B?V3M1cHpjYUVaMGVFUmZ6M2l2TFNoV0JsYnkvWHYvNENoSjNCZ1FPNUZ2N2R6?= =?utf-8?B?ZVIxRmtWYXZiUzB3RlJiaWdFZXBKb3NVVGJRdXlKWEk3WUErZFFMODA1SXEy?= =?utf-8?B?ZjRKVlpjalQ5RTlYQmpMT24zUWgrWVR0SGRzVEYweERBV25NaWhxOWhaNERB?= =?utf-8?B?YU9sZkQxQm5lWk9hb2FVNXVhaXJZSzNrWnErMGxmcno0b203amRyTzRMbk8v?= =?utf-8?B?dDExRTdHQy8wM1pYNmpIejdlQ3NRZDBROGNBL2djZUNkV2pxZFZpN2FwVEE4?= =?utf-8?B?b2g2aHRLRi9ZL3EwS3BQemQ0YWkyQXFOL3hXRTZTaW9MWm1LYmVzbWRPL2Vn?= =?utf-8?B?dHdTdGRMdkVqTUx6eUh1anIydXRuYjJWYWxwcjNPb21ZTS9mV2swbEtUUGph?= =?utf-8?Q?9QVHmLSpOC2ZJi3xqa2T6nMvP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c899ad80-f3a9-4d5e-8083-08dab7e6ca40 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2022 06:45:09.1182 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YH1R5aiernwg8gPM/W8bfAH05x8rgThtge5kSgfkHXswDP0bpOSQvaih6TgKv4vS2Emky5avDX+lnjF6ELdB+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8343 X-Spam-Status: No, score=-3029.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27.10.2022 08:04, Cui, Lili wrote:> @@ -5057,9 +5057,15 @@ md_assemble (char *line) > if (!process_suffix ()) > return; > > - /* Update operand types and check extended states. */ > + /* 1. Update operand types and check extended states. > + 2. Check IP-relative addressing for prefetchi. */ > for (j = 0; j < i.operands; j++) > { > + /* Check if IP-relative addressing requirements can be satisfied. */ > + if (i.tm.cpu_flags.bitfield.cpuprefetchi > + && !(i.base_reg && i.base_reg->reg_num == RegIP)) > + as_warn (_("only support RIP-relative address")); One final suggestion: as_warn (_("`%s' only supports RIP-relative address"), i.tm.name); And maybe also keep code and comment in sync as to the sequence of things done. Jan