public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [RFA] pdp11: fix abort if debug symbols present
@ 2010-11-29 18:09 Paul Koning
  2010-12-02  2:58 ` Alan Modra
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Koning @ 2010-11-29 18:09 UTC (permalink / raw)
  To: binutils

The existing bfd/pdp11.c doesn't accept debug symbols.  The attached patch cures that.

Tested by building pdp11-aout-none and using it with gcc -g.

Ok for trunk?

	paul

ChangeLog:

2010-11-29  Paul Koning  <ni1d@arrl.net>

	* pdp11.c (aout_link_add_symbols): Ignore debug symbols.

Index: pdp11.c
===================================================================
RCS file: /cvs/src/src/bfd/pdp11.c,v
retrieving revision 1.45
diff -u -r1.45 pdp11.c
--- pdp11.c	14 Oct 2010 01:31:27 -0000	1.45
+++ pdp11.c	29 Nov 2010 17:08:45 -0000
@@ -2777,7 +2777,9 @@
       switch (type)
 	{
 	default:
-	  abort ();
+	  /* Anything else should be a debugging symbol.  */
+	  BFD_ASSERT ((type & N_STAB) != 0);
+	  continue;
 
 	case N_UNDF:
 	case N_ABS:

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFA] pdp11: fix abort if debug symbols present
  2010-11-29 18:09 [RFA] pdp11: fix abort if debug symbols present Paul Koning
@ 2010-12-02  2:58 ` Alan Modra
  2010-12-02 11:53   ` Paul Koning
  0 siblings, 1 reply; 3+ messages in thread
From: Alan Modra @ 2010-12-02  2:58 UTC (permalink / raw)
  To: Paul Koning; +Cc: binutils

On Mon, Nov 29, 2010 at 12:10:52PM -0500, Paul Koning wrote:
> 	* pdp11.c (aout_link_add_symbols): Ignore debug symbols.

OK.

-- 
Alan Modra
Australia Development Lab, IBM

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFA] pdp11: fix abort if debug symbols present
  2010-12-02  2:58 ` Alan Modra
@ 2010-12-02 11:53   ` Paul Koning
  0 siblings, 0 replies; 3+ messages in thread
From: Paul Koning @ 2010-12-02 11:53 UTC (permalink / raw)
  To: Alan Modra; +Cc: binutils


On Dec 1, 2010, at 9:57 PM, Alan Modra wrote:

> On Mon, Nov 29, 2010 at 12:10:52PM -0500, Paul Koning wrote:
>> 	* pdp11.c (aout_link_add_symbols): Ignore debug symbols.
> 
> OK.

Thanks!  Committed.

	paul

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-12-02 11:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-29 18:09 [RFA] pdp11: fix abort if debug symbols present Paul Koning
2010-12-02  2:58 ` Alan Modra
2010-12-02 11:53   ` Paul Koning

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).