From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31869 invoked by alias); 19 Oct 2010 16:12:36 -0000 Received: (qmail 31814 invoked by uid 22791); 19 Oct 2010 16:12:34 -0000 X-SWARE-Spam-Status: No, hits=3.0 required=5.0 tests=AWL,BAYES_00,CHARSET_FARAWAY_HEADER,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MIME_CHARSET_FARAWAY,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 19 Oct 2010 16:12:25 +0000 Received: from hpaq14.eem.corp.google.com (hpaq14.eem.corp.google.com [172.25.149.14]) by smtp-out.google.com with ESMTP id o9JGCNjp024005 for ; Tue, 19 Oct 2010 09:12:23 -0700 Received: from pxi18 (pxi18.prod.google.com [10.243.27.18]) by hpaq14.eem.corp.google.com with ESMTP id o9JGBHcV009931 for ; Tue, 19 Oct 2010 09:12:22 -0700 Received: by pxi18 with SMTP id 18so652293pxi.20 for ; Tue, 19 Oct 2010 09:12:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.221.6 with SMTP id t6mr4815110wfg.438.1287504741499; Tue, 19 Oct 2010 09:12:21 -0700 (PDT) Received: by 10.143.167.19 with HTTP; Tue, 19 Oct 2010 09:12:21 -0700 (PDT) In-Reply-To: References: Date: Tue, 19 Oct 2010 16:12:00 -0000 Message-ID: Subject: Re: [GOLD][PATCH] Set SHF_LINK_ORDER flags of ARM EXIDX sections. From: =?Big5?B?RG91ZyBLd2FuICjD9q62vHcp?= To: Ian Lance Taylor Cc: binutils Content-Type: text/plain; charset=Big5 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00306.txt.bz2 Gold does not handle SHF_LINK_ORDER flag in general, we drop the flag when searching for an output section. Output_section* Layout::choose_output_section(const Relobj* relobj, const char* name, elfcpp::Elf_Word type, elfcpp::Elf_Xword flag= s, bool is_input_section, Output_section_order o= rder, bool is_relro) ... // Some flags in the input section should not be automatically // copied to the output section. flags &=3D ~ (elfcpp::SHF_INFO_LINK | elfcpp::SHF_LINK_ORDER | elfcpp::SHF_GROUP | elfcpp::SHF_MERGE =A6b 2010=A6~10=A4=EB19=A4=E9=A4U=A4=C810:07=A1AIan Lance Taylor =BCg=B9D=A1G > "Doug Kwan (=C3=F6=AE=B6=BCw)" writes: > >> This patch changes code writing output section headers so that the >> SHF_LINK_ORDER flag of a section of type SHT_ARM_EXIDX is always set. >> The flag is required to be set for such a section by the ARM EHABI. >> The existing code drops the SHF_LINK_ORDER flag and that confuses >> other tools. Gold does not handle SHF_LINK_ORDER in general but the >> ARM back-end can handle the EXIDX sections. >> >> -Doug >> >> >> 2010-10-19 Doug Kwan >> >> * output.cc(Output_section::write_header): Set SHF_LINK_ORDER fl= ags of >> ARM EXIDX sections. > > I don't see the ARM backend actually creating any SHT_ARM_EXIDX > sections. So it seems to me that they are input sections. If the ABI > requires the input sections to have the SHF_LINK_ORDER flag set, then > that setting should carry through to the output section. Does that not > happen? > > Ian >