From: "H.J. Lu" <hjl.tools@gmail.com>
To: Hans-Peter Nilsson <hans-peter.nilsson@axis.com>,
hp@axis.com, binutils@sourceware.org
Cc: Alan Modra <amodra@gmail.com>
Subject: Re: PATCH: Mention symbol name in non-constant .size expression
Date: Mon, 07 Mar 2011 05:43:00 -0000 [thread overview]
Message-ID: <AANLkTi=4P8-_0esD=kqjarbph65HUwFBZ3XA5tvOHC0Z@mail.gmail.com> (raw)
In-Reply-To: <20110307035457.GL6275@bubble.grove.modra.org>
On Sun, Mar 6, 2011 at 7:54 PM, Alan Modra <amodra@gmail.com> wrote:
> On Mon, Mar 07, 2011 at 04:28:02AM +0100, Hans-Peter Nilsson wrote:
>> If there's no intention to actually fix it, I think xfail is
>> more appropriate; no particular reason it should fail, IMHO.
>
> The new test will fail for any target without DIFF_EXPR_OK defined.
> HJ, I don't think it is worth going to the bother of firstly finding
> out exactly what set of targets that is, then xfailing them all.
> Please just revert the testsuite change that checks for the symbol
> name.
>
Done.
--
H.J.
prev parent reply other threads:[~2011-03-07 5:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-05 15:32 H.J. Lu
2011-03-06 8:33 ` Alan Modra
2011-03-07 2:22 ` Hans-Peter Nilsson
2011-03-07 2:51 ` H.J. Lu
2011-03-07 3:28 ` Hans-Peter Nilsson
2011-03-07 3:55 ` Alan Modra
2011-03-07 5:43 ` H.J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=4P8-_0esD=kqjarbph65HUwFBZ3XA5tvOHC0Z@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=hans-peter.nilsson@axis.com \
--cc=hp@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).