* [gold patch] final_layout.sh fails depending on symbol table order
@ 2011-03-25 21:43 Cary Coutant
2011-03-25 22:39 ` Ian Lance Taylor
0 siblings, 1 reply; 2+ messages in thread
From: Cary Coutant @ 2011-03-25 21:43 UTC (permalink / raw)
To: Ian Lance Taylor, Binutils
The recent patch to testsuite/final_layout.sh (to eliminate the
dependency on dc) now simply checks the order of the variables in nm
output, but nm output is not always in address order:
0000000000401acc B global_vara
0000000000401ac8 B global_varb
0000000000401ad0 B global_varc
The script is checking that global_varb comes before global_vara, but
fails here because the symbol table is not in address order. Adding
the -n option to the nm call fixes this.
OK? (Obvious?)
-cary
* testsuite/Makefile.am (final_layout.stdout): Use -n option with nm.
* testsuite/Makefile.in: Regenerate.
Index: testsuite/Makefile.am
===================================================================
RCS file: /cvs/src/src/gold/testsuite/Makefile.am,v
retrieving revision 1.155
diff -u -p -r1.155 Makefile.am
--- testsuite/Makefile.am 10 Mar 2011 01:31:33 -0000 1.155
+++ testsuite/Makefile.am 25 Mar 2011 21:37:49 -0000
@@ -209,7 +209,7 @@ final_layout_sequence.txt:
final_layout: final_layout.o final_layout_sequence.txt gcctestdir/ld
$(CXXLINK) -Bgcctestdir/
-Wl,--section-ordering-file,final_layout_sequence.txt final_layout.o
final_layout.stdout: final_layout
- $(TEST_NM) final_layout > final_layout.stdout
+ $(TEST_NM) -n final_layout > final_layout.stdout
check_PROGRAMS += icf_virtual_function_folding_test
MOSTLYCLEANFILES += icf_virtual_function_folding_test
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [gold patch] final_layout.sh fails depending on symbol table order
2011-03-25 21:43 [gold patch] final_layout.sh fails depending on symbol table order Cary Coutant
@ 2011-03-25 22:39 ` Ian Lance Taylor
0 siblings, 0 replies; 2+ messages in thread
From: Ian Lance Taylor @ 2011-03-25 22:39 UTC (permalink / raw)
To: Cary Coutant; +Cc: Binutils
Cary Coutant <ccoutant@google.com> writes:
> The recent patch to testsuite/final_layout.sh (to eliminate the
> dependency on dc) now simply checks the order of the variables in nm
> output, but nm output is not always in address order:
>
> 0000000000401acc B global_vara
> 0000000000401ac8 B global_varb
> 0000000000401ad0 B global_varc
>
> The script is checking that global_varb comes before global_vara, but
> fails here because the symbol table is not in address order. Adding
> the -n option to the nm call fixes this.
> * testsuite/Makefile.am (final_layout.stdout): Use -n option with nm.
> * testsuite/Makefile.in: Regenerate.
Arrghh, I wrote this myself but I forgot to check it in. Please do
check in your patch. Thanks.
Ian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-25 22:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-25 21:43 [gold patch] final_layout.sh fails depending on symbol table order Cary Coutant
2011-03-25 22:39 ` Ian Lance Taylor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).