From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-70292-listarch-binutils=sources.redhat.com@sourceware.org>
Received: (qmail 13110 invoked by alias); 25 Feb 2011 23:45:21 -0000
Received: (qmail 13096 invoked by uid 22791); 25 Feb 2011 23:45:20 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Received: from mail-qy0-f169.google.com (HELO mail-qy0-f169.google.com) (209.85.216.169)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Feb 2011 23:45:16 +0000
Received: by qyk2 with SMTP id 2so877785qyk.0        for <binutils@sourceware.org>; Fri, 25 Feb 2011 15:45:14 -0800 (PST)
MIME-Version: 1.0
Received: by 10.224.74.10 with SMTP id s10mr2535970qaj.291.1298677514485; Fri, 25 Feb 2011 15:45:14 -0800 (PST)
Received: by 10.224.61.18 with HTTP; Fri, 25 Feb 2011 15:45:14 -0800 (PST)
In-Reply-To: <20110225232948.GD5959@bubble.grove.modra.org>
References: <20110224225913.GA3169@intel.com>	<20110225232948.GD5959@bubble.grove.modra.org>
Date: Fri, 25 Feb 2011 23:45:00 -0000
Message-ID: <AANLkTi=dBpEVPX=_yCpgb38TByDeO5mgUfAoD=96qWOb@mail.gmail.com>
Subject: Re: PATCH: PR ld/12507: Can't build a program with -flto -nostdlib
From: "H.J. Lu" <hjl.tools@gmail.com>
To: "H.J. Lu" <hjl.tools@gmail.com>, binutils@sourceware.org
Cc: Alan Modra <amodra@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact binutils-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <binutils.sourceware.org>
List-Subscribe: <mailto:binutils-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: binutils-owner@sourceware.org
X-SW-Source: 2011-02/txt/msg00323.txt.bz2

On Fri, Feb 25, 2011 at 3:29 PM, Alan Modra <amodra@gmail.com> wrote:
> On Thu, Feb 24, 2011 at 02:59:13PM -0800, H.J. Lu wrote:
>> @@ -490,8 +490,10 @@ get_symbols (const void *handle, int nsyms, struct =
ld_plugin_symbol *syms)
>> =A0 =A0 =A0 =A0even potentially-referenced, perhaps in a future final li=
nk if
>> =A0 =A0 =A0 =A0this is a partial one, perhaps dynamically at load-time i=
f the
>> =A0 =A0 =A0 =A0symbol is externally visible. =A0*/
>> - =A0 =A0 =A0ironly =3D !is_visible_from_outside (&syms[n], owner_sec, b=
lhe)
>> - =A0 =A0 && !bfd_hash_lookup (non_ironly_hash, syms[n].name, FALSE, FAL=
SE);
>> + =A0 =A0 =A0ironly =3D (!is_visible_from_outside (&syms[n], owner_sec, =
blhe)
>> + =A0 =A0 =A0 =A0 =A0 =A0 && !bfd_hash_lookup (non_ironly_hash, syms[n].=
name,
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0FAL=
SE, FALSE)
>> + =A0 =A0 =A0 =A0 =A0 =A0 && strcmp (syms[n].name, entry_symbol.name) !=
=3D 0);
>>
>> =A0 =A0 =A0 =A0/* If it was originally undefined or common, then it has =
been
>> =A0 =A0 =A0 =A0resolved; determine how. =A0*/
>
> It would be better to put the entry symbol, and -u syms on the
> entry_symbol chain, into non_ironly_hash.
>

I tried it and it doesn't work.

Also, we only care about the entry symbol for LTO.

--=20
H.J.