[hjl/lto-mixed] PATCH: Remove IRONLY_SUFFIX

[hjl/lto-mixed] PATCH: Remove IRONLY_SUFFIX

[H.J. Lu]

Hi Dave,

I don't believe IRONLY_SUFFIX is needed for 2 stage linker.  Will it
cause any problems on Windows for you?

Thanks.


H.J.
---
diff --git a/ld/ChangeLog.lto-mixed b/ld/ChangeLog.lto-mixed
index cb75156..306a1f6 100644
--- a/ld/ChangeLog.lto-mixed
+++ b/ld/ChangeLog.lto-mixed
@@ -1,3 +1,8 @@
+2011-01-10  H.J. Lu  <hongjiu.lu@intel.com>
+
+	* plugin.c (IRONLY_SUFFIX): Removed.
+	(plugin_get_ir_dummy_bfd): Updated.
+
 2011-01-09  H.J. Lu  <hongjiu.lu@intel.com>
 
 	* ldlang.c (lang_startup): Call cmdline_option_prepend with
diff --git a/ld/plugin.c b/ld/plugin.c
index 377a840..cdabd8f 100644
--- a/ld/plugin.c
+++ b/ld/plugin.c
@@ -36,11 +36,6 @@
 #include <Windows.h>
 #endif
 
-/* The suffix to append to the name of the real (claimed) object file
-   when generating a dummy BFD to hold the IR symbols sent from the
-   plugin.  */
-#define IRONLY_SUFFIX		".ironly\004"
-
 /* Stores a single argument passed to a plugin.  */
 typedef struct plugin_arg
 {
@@ -240,8 +235,7 @@ plugin_get_ir_dummy_bfd (const char *name, bfd *srctemplate)
   bfd *abfd;
 
   bfd_use_reserved_id = 1;
-  abfd = bfd_create (concat (name, IRONLY_SUFFIX, (const char *)NULL),
-		     srctemplate);
+  abfd = bfd_create (name, srctemplate);
   bfd_set_arch_info (abfd, bfd_get_arch_info (srctemplate));
   bfd_make_writable (abfd);
   abfd->flags |= BFD_PLUGIN_DUMMY;

Re: [hjl/lto-mixed] PATCH: Remove IRONLY_SUFFIX

[Dave Korn]

On 11/01/2011 18:27, H.J. Lu wrote:
> Hi Dave,
> 
> I don't believe IRONLY_SUFFIX is needed for 2 stage linker.  Will it
> cause any problems on Windows for you?

  No, it's not the name of any real file after all, and there's nothing
special about it for Windows.  (It was at times a useful diagnostic to know
whether an error arose in the original file or the replacement bfd by looking
at the filename in the error message, but other than that the only purpose it
served is subsumed in your new BFD_PLUGIN_DUMMY flag.)

    cheers,
      DaveK

Re: [hjl/lto-mixed] PATCH: Remove IRONLY_SUFFIX

[H.J. Lu]

On Wed, Jan 12, 2011 at 6:57 PM, Dave Korn <dave.korn.cygwin@gmail.com> wrote:
> On 11/01/2011 18:27, H.J. Lu wrote:
>> Hi Dave,
>>
>> I don't believe IRONLY_SUFFIX is needed for 2 stage linker.  Will it
>> cause any problems on Windows for you?
>
>  No, it's not the name of any real file after all, and there's nothing
> special about it for Windows.  (It was at times a useful diagnostic to know
> whether an error arose in the original file or the replacement bfd by looking
> at the filename in the error message, but other than that the only purpose it
> served is subsumed in your new BFD_PLUGIN_DUMMY flag.)
>

Thanks.  It is on hjl/lto-mixed branch now.

-- 
H.J.