public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "Petr Hluzín" <petr.hluzin@gmail.com>
To: Richard Henderson <rth@redhat.com>
Cc: Anitha Boyapati <anitha.boyapati@gmail.com>, binutils@sourceware.org
Subject: Re: Testing Call frame information in .debug_frame section
Date: Tue, 15 Feb 2011 22:13:00 -0000	[thread overview]
Message-ID: <AANLkTi=u=w8AdO71yZ_YZWptcbAGDhVzjr3WoZtnuSCr@mail.gmail.com> (raw)
In-Reply-To: <4D5ABFAC.7050804@redhat.com>

On 15 February 2011 19:02, Richard Henderson <rth@redhat.com> wrote:
> On 02/15/2011 09:41 AM, Richard Henderson wrote:
>> On 02/13/2011 07:10 AM, Petr Hluzín wrote:
>>> http://xfree86.cygwin.ru/ml/binutils/2010-08/msg00109.html
>>
>> I'll agree that a better error message would be helpful.
>
> Committed as follows.
>
>
> r~
>
>
>        * dw2gencfi.c (dot_cfi_dummy): New.
>        (cfi_pseudo_table) [!TARGET_USE_CFIPOP]: New.
>        * read.c (pobegin): Unconditionally call cfi_pop_insert.
>

Great, thanks.

Note: The submitted code code does not print the platform GAS is
configured for. If makefile/IDE is accidentally launching wrong build
of GAS then user will have hard time figuring this out. If it is not
an accident then the extra information is useful for googling since
recovery steps may be different. ("CFI on arch FOO? You have to
upgrade to version XY" vs "CFI on arch BAR? You have to apply this
patch.")

-as_bad (_("CFI is not supported for this target"));
+as_bad (_("CFI is not supported for target '" TARGET_FORMAT "'"));

Also "intelligable" looks like a typo. Perhaps "intelligible"?

-- 
Petr Hluzin

  reply	other threads:[~2011-02-15 22:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AANLkTim6hyXysiV-025BDgNJ84qaqTnkRdHi+e7bF2gx@mail.gmail.com>
     [not found] ` <AANLkTi=Rnu-wb2W8FejN=XQHmHuTq7rZovKuDdO-QLwi@mail.gmail.com>
     [not found]   ` <AANLkTimOXF1V__SSFs1gtqJh5nc183EdeHm5NoeU6YXs@mail.gmail.com>
     [not found]     ` <AANLkTike2osnZS=sUphuN_=oFQLCDUs54uuGCWL6cLVQ@mail.gmail.com>
2011-02-15 17:41       ` Richard Henderson
2011-02-15 18:02         ` Richard Henderson
2011-02-15 22:13           ` Petr Hluzín [this message]
2011-02-16 16:51             ` Richard Henderson
2011-02-15 18:09         ` Anitha Boyapati
2011-02-15 18:48           ` Richard Henderson
2011-02-15 19:15             ` Anitha Boyapati
2011-02-15 19:03         ` [avr] gas support for cfi info Richard Henderson
2011-02-15 22:45           ` Petr Hluzín
2011-02-16 17:59             ` Richard Henderson
2011-02-16 22:49               ` Petr Hluzín
2011-02-17 16:12                 ` Richard Henderson
2011-02-17 16:16                   ` Tristan Gingold
2011-02-17 15:35               ` Anitha Boyapati
2011-02-17 16:05                 ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=u=w8AdO71yZ_YZWptcbAGDhVzjr3WoZtnuSCr@mail.gmail.com' \
    --to=petr.hluzin@gmail.com \
    --cc=anitha.boyapati@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=rth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).