From: "H.J. Lu" <hjl.tools@gmail.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: amodra@gmail.com, binutils@sourceware.org
Subject: Re: PATCH: Add --size-check=[error|warning]
Date: Fri, 11 Mar 2011 17:20:00 -0000 [thread overview]
Message-ID: <AANLkTikG8wa1Em0bEUddbYpYs2TzFFTDb95qWFJ3xSbv@mail.gmail.com> (raw)
In-Reply-To: <4D7A64670200007800035F4C@vpn.id2.novell.com>
On Fri, Mar 11, 2011 at 9:05 AM, Jan Beulich <JBeulich@novell.com> wrote:
>>>> On 11.03.11 at 17:58, "H.J. Lu" <hongjiu.lu@intel.com> wrote:
>> Issue an error for bad ELF .size directive on Linux kernel bisect where
>> the bad assembly codes aren't fixed. This patch adds
>> --size-check=[error|warning] so that we can issue a warning instead of
>> an error. OK to install?
>
> Please make it so that it'll be a warning by default, and an error
> upon programmer request. Otherwise, for the very purpose of
I disagree. It should be error by default since the input is bogus,
Otherwise, those assembly bugs, benign or not, may not get
fixed.
> bisection, it won't help much as you would have to override
> compiler/assembler flags during that process.
>
They can use a wrapper to pass --size-check=warning to
assembler. I think it is a small price to pay for those mistakes.
--
H.J.
next prev parent reply other threads:[~2011-03-11 17:20 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 16:58 H.J. Lu
2011-03-11 17:04 ` Jan Beulich
2011-03-11 17:20 ` H.J. Lu [this message]
2011-03-14 8:44 ` Jan Beulich
2011-03-14 9:55 ` Ingo Molnar
2011-03-14 10:41 ` Alan Modra
2011-03-14 10:50 ` Pekka Enberg
2011-03-14 18:04 ` Alan Cox
2011-03-14 10:52 ` Jan Beulich
[not found] ` <AANLkTi=3AiLaw5Gnis8Ha4eRXirk0s-Cnk2zzN12YDpH__45869.1711457961$1300099861$gmane$org@mail.gmail.com>
2011-03-14 11:03 ` Andreas Schwab
2011-03-14 11:12 ` Pekka Enberg
2011-03-14 12:02 ` Andreas Schwab
2011-03-14 12:13 ` Ingo Molnar
2011-03-14 12:55 ` Andreas Schwab
2011-03-14 13:17 ` Ingo Molnar
2011-03-14 14:11 ` Andreas Schwab
2011-03-14 12:11 ` Ingo Molnar
2011-03-14 12:23 ` Ingo Molnar
2011-03-14 12:26 ` Ingo Molnar
2011-03-14 13:16 ` git bisect plus fixes (was: PATCH: Add --size-check=[error|warning]) Ralf Wildenhues
2011-03-14 13:55 ` PATCH: Add --size-check=[error|warning] H.J. Lu
2011-03-16 23:56 ` Alan Modra
2011-03-18 11:20 ` Alan Modra
2011-03-18 11:59 ` Alan Modra
2011-03-14 11:02 Sedat Dilek
2011-03-14 11:25 ` Jan Beulich
2011-03-14 11:35 ` Ingo Molnar
2011-03-14 11:39 ` Sedat Dilek
2011-03-14 11:53 ` Sedat Dilek
2011-03-14 12:22 ` Jan Beulich
2011-03-14 12:38 ` Sedat Dilek
2011-03-14 15:56 ` Ian Lance Taylor
2011-03-14 18:02 ` H. Peter Anvin
2011-03-14 16:33 ` H. Peter Anvin
2011-03-14 19:24 ` Steven Rostedt
2011-03-14 20:06 ` Linus Torvalds
2011-03-14 12:57 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikG8wa1Em0bEUddbYpYs2TzFFTDb95qWFJ3xSbv@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=JBeulich@novell.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).