From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18621 invoked by alias); 21 Feb 2011 15:53:49 -0000 Received: (qmail 18595 invoked by uid 22791); 21 Feb 2011 15:53:48 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-qw0-f41.google.com (HELO mail-qw0-f41.google.com) (209.85.216.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Feb 2011 15:53:43 +0000 Received: by qwd7 with SMTP id 7so2084862qwd.0 for ; Mon, 21 Feb 2011 07:53:41 -0800 (PST) MIME-Version: 1.0 Received: by 10.229.192.149 with SMTP id dq21mr1134296qcb.57.1298303621493; Mon, 21 Feb 2011 07:53:41 -0800 (PST) Received: by 10.229.214.131 with HTTP; Mon, 21 Feb 2011 07:53:41 -0800 (PST) In-Reply-To: <201102211542.p1LFgucQ002211@glazunov.sibelius.xs4all.nl> References: <-8460070221060995487@unknownmsgid> <-6930711422310680743@unknownmsgid> <201102211542.p1LFgucQ002211@glazunov.sibelius.xs4all.nl> Date: Mon, 21 Feb 2011 15:53:00 -0000 Message-ID: Subject: Re: [RFC patch]: Adjust the use of 'long' type in dwarf2.h header From: Kai Tietz To: Mark Kettenis Cc: pierre.muller@ics-cnrs.unistra.fr, gcc-patches@gcc.gnu.org, binutils@sourceware.org, gdb@sourceware.org, jakub@redhat.com, brobecker@adacore.com Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00260.txt.bz2 2011/2/21 Mark Kettenis : >> Date: Mon, 21 Feb 2011 16:25:35 +0100 >> From: Kai Tietz >> >> 2011/2/21 Kai Tietz : >> > 2011/2/21 Pierre Muller : >> >>> Yes, I saw this too and it is a thorn here. But the issue about a >> >>> transformation function (like dwarf_vma) is that we have memory leaks >> >>> - as this function is to be used on some printf's more then once - as >> >>> static buffer would be overriden. Well printfs can be splitted into >> >>> smaller parts, but this then would make localization even harder. >> >> >> >> =A0In GDB code, this is solved in utils.c source by the use of the >> >> get_cell function, which rotates over 16 char arrays of size 50 each >> >> currently, in dwarf.c 4 arrays of 16 char (as long as longest address= is >> >> 64-bit) >> >> for this dwarf_vma function would probably be enough, no? >> >> >> >> >> >> Pierre Muller >> >> GDB pascal language maintainer >> > >> > Yes, this sounds ok. I think maximum here are right now 3 dwarf_vma >> > prints within one printf. So it should be ok. I'll add here such a >> > rotating function. I don't assume we need here to handle >> > multi-threading, so rotation code can be pretty simple. >> > >> > Kai >> > >> >> So this version uses new function dwarf_vma_print function for >> printf-messages, which are getting localized. > > dwarf_vma_print is a really bad name for that function since it > doesn't print anything. > well, it doesn't output, but it uses sprintf. So what's about dwarf_vmatoa instead?