[gold][patch] Pass the output filename to the plugin

[gold][patch] Pass the output filename to the plugin

[Rafael Espindola]

[-- Attachment #1: Type: text/plain, Size: 712 bytes --]

With the attached patch gold will pass the name of the output file to
the plugin. The use case is that sometimes the plugin wants to output
additional information to another file.

For example, in the llvm plugin we have a also-emit-llvm option. Right
now that option requires an argument. I would like to make the
argument optional and default to appending .bc to the regular output
name.

gold/
2010-06-01  Rafael Espindola  <espindola@google.com>

        * plugin.cc (Plugin::load): Pass the output name to the plugin.

include/
2010-06-01  Rafael Espindola  <espindola@google.com>

        * plugin-api.h (ld_plugin_tag): Add LDPT_OUTPUT_NAME.

Cheers,
-- 
Rafael Ávila de Espíndola

[-- Attachment #2: output.patch --]
[-- Type: application/octet-stream, Size: 1038 bytes --]

diff --git a/gold/plugin.cc b/gold/plugin.cc
index 2ee1301..62141ac 100644
--- a/gold/plugin.cc
+++ b/gold/plugin.cc
@@ -127,7 +127,7 @@ Plugin::load()
   sscanf(ver, "%d.%d", &major, &minor);
 
   // Allocate and populate a transfer vector.
-  const int tv_fixed_size = 14;
+  const int tv_fixed_size = 15;
   int tv_size = this->args_.size() + tv_fixed_size;
   ld_plugin_tv *tv = new ld_plugin_tv[tv_size];
 
@@ -154,6 +154,10 @@ Plugin::load()
   else
     tv[i].tv_u.tv_val = LDPO_EXEC;
 
+  ++i;
+  tv[i].tv_tag = LDPT_OUTPUT_NAME;
+  tv[i].tv_u.tv_string = parameters->options().output();
+
   for (unsigned int j = 0; j < this->args_.size(); ++j)
     {
       ++i;
diff --git a/include/plugin-api.h b/include/plugin-api.h
index 572621f..5821785 100644
--- a/include/plugin-api.h
+++ b/include/plugin-api.h
@@ -260,7 +260,8 @@ enum ld_plugin_tag
   LDPT_MESSAGE,
   LDPT_GET_INPUT_FILE,
   LDPT_RELEASE_INPUT_FILE,
-  LDPT_ADD_INPUT_LIBRARY
+  LDPT_ADD_INPUT_LIBRARY,
+  LDPT_OUTPUT_NAME
 };
 
 /* The plugin transfer vector.  */

Re: [gold][patch] Pass the output filename to the plugin

[Cary Coutant]

> gold/
> 2010-06-01  Rafael Espindola  <espindola@google.com>
>
>        * plugin.cc (Plugin::load): Pass the output name to the plugin.
>
> include/
> 2010-06-01  Rafael Espindola  <espindola@google.com>
>
>        * plugin-api.h (ld_plugin_tag): Add LDPT_OUTPUT_NAME.

Looks good to me.

-cary

Re: [gold][patch] Pass the output filename to the plugin

[Ian Lance Taylor]

Rafael Espindola <espindola@google.com> writes:

> gold/
> 2010-06-01  Rafael Espindola  <espindola@google.com>
>
>         * plugin.cc (Plugin::load): Pass the output name to the plugin.
>
> include/
> 2010-06-01  Rafael Espindola  <espindola@google.com>
>
>         * plugin-api.h (ld_plugin_tag): Add LDPT_OUTPUT_NAME.

This is OK.

Please update http://gcc.gnu.org/wiki/whopr/driver .

Thanks.

Ian