From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8623 invoked by alias); 25 Feb 2011 17:01:35 -0000 Received: (qmail 8611 invoked by uid 22791); 25 Feb 2011 17:01:34 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: sourceware.org Received: from mail-qw0-f41.google.com (HELO mail-qw0-f41.google.com) (209.85.216.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Feb 2011 17:01:30 +0000 Received: by qwd7 with SMTP id 7so1812208qwd.0 for ; Fri, 25 Feb 2011 09:01:28 -0800 (PST) MIME-Version: 1.0 Received: by 10.224.74.21 with SMTP id s21mr2259522qaj.141.1298653288347; Fri, 25 Feb 2011 09:01:28 -0800 (PST) Received: by 10.224.61.18 with HTTP; Fri, 25 Feb 2011 09:01:28 -0800 (PST) In-Reply-To: <20110225134026.GC5959@bubble.grove.modra.org> References: <20110225134026.GC5959@bubble.grove.modra.org> Date: Fri, 25 Feb 2011 17:01:00 -0000 Message-ID: Subject: Re: PR12519 ELF .size expressions From: "H.J. Lu" To: binutils@sourceware.org Cc: Alan Modra Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00315.txt.bz2 On Fri, Feb 25, 2011 at 5:40 AM, Alan Modra wrote: > Fixes code handling ELF .size expressions that can't be evaluated > immediately for some reasone, for example if the .size directive was > given at the beginning of the function referencing a label at the end > of the function. =A0Also corrects a couple of errors in the testsuite > that the old .size code wrongly accepted. > > gas/ > =A0 =A0 =A0 =A0PR gas/12519 > =A0 =A0 =A0 =A0* config/obj-elf.c (elf_frob_symbol): Properly handle size= expression. > ld/testsuite/ > =A0 =A0 =A0 =A0* ld-mn10300/i135409-3.s: Correct .size label reference. > =A0 =A0 =A0 =A0* ld-sh/sh64/stolib.s: Likewise. > I checked in this testcase. --=20 H.J. --- diff --git a/gas/testsuite/ChangeLog b/gas/testsuite/ChangeLog index 50c23da..4bb775d 100644 --- a/gas/testsuite/ChangeLog +++ b/gas/testsuite/ChangeLog @@ -1,3 +1,12 @@ +2011-02-25 H.J. Lu + + PR gas/12519 + * gas/elf/bad-size.d: New. + * gas/elf/bad-size.err: Likewise. + * gas/elf/bad-size.s: Likewise. + + * gas/elf/elf.exp: Run bad-size. + 2011-02-13 Mike Frysinger * gas/bfin/arithmetic.d, gas/bfin/parallel.d: Change A0 to A1. diff --git a/gas/testsuite/gas/elf/bad-size.d b/gas/testsuite/gas/elf/bad-s= ize.d new file mode 100644 index 0000000..a313293 --- /dev/null +++ b/gas/testsuite/gas/elf/bad-size.d @@ -0,0 +1,2 @@ +#name: Check bad size directive +#error-output: bad-size.err diff --git a/gas/testsuite/gas/elf/bad-size.err b/gas/testsuite/gas/elf/bad-size.err new file mode 100644 index 0000000..5e01ef2 --- /dev/null +++ b/gas/testsuite/gas/elf/bad-size.err @@ -0,0 +1,2 @@ +.*bad-size\.s: Assembler messages: +.*bad-size\.s:6: Error: .* diff --git a/gas/testsuite/gas/elf/bad-size.s b/gas/testsuite/gas/elf/bad-s= ize.s new file mode 100644 index 0000000..c982779 --- /dev/null +++ b/gas/testsuite/gas/elf/bad-size.s @@ -0,0 +1,6 @@ + .text +_test_nop: + .byte 0 + .section .text.entry.continue, "xa" + .byte 0 + .size _test_nop, .-_test_nop diff --git a/gas/testsuite/gas/elf/elf.exp b/gas/testsuite/gas/elf/elf.exp index f21d838..8bfeb95 100644 --- a/gas/testsuite/gas/elf/elf.exp +++ b/gas/testsuite/gas/elf/elf.exp @@ -182,4 +182,5 @@ if { ([istarget "*-*-*elf*"] run_dump_test "dwarf2-3" run_dump_test "dwarf2-4" run_dump_test "bad-section-flag" + run_dump_test "bad-size" }