* [patch][gold] Fix symbol visibility in plugin objects
@ 2010-05-30 6:02 Rafael Espindola
2010-06-01 17:54 ` Cary Coutant
2010-06-01 19:46 ` Ian Lance Taylor
0 siblings, 2 replies; 3+ messages in thread
From: Rafael Espindola @ 2010-05-30 6:02 UTC (permalink / raw)
To: Binutils; +Cc: Cary Coutant
[-- Attachment #1: Type: text/plain, Size: 226 bytes --]
The subject says it all :-)
2010-05-30 Rafael Espindola <espindola@google.com>
* plugin.cc (Sized_pluginobj::::do_add_symbols): Correctly set the
visibility of symbols.
Cheers,
--
Rafael Ávila de Espíndola
[-- Attachment #2: vis.patch --]
[-- Type: application/octet-stream, Size: 671 bytes --]
diff --git a/gold/plugin.cc b/gold/plugin.cc
index 2ee1301..a7bdbb5 100644
--- a/gold/plugin.cc
+++ b/gold/plugin.cc
@@ -647,13 +647,13 @@ Sized_pluginobj<size, big_endian>::do_add_symbols(Symbol_table* symtab,
switch (isym->visibility)
{
case LDPV_PROTECTED:
- vis = elfcpp::STV_DEFAULT;
+ vis = elfcpp::STV_PROTECTED;
break;
case LDPV_INTERNAL:
- vis = elfcpp::STV_DEFAULT;
+ vis = elfcpp::STV_INTERNAL;
break;
case LDPV_HIDDEN:
- vis = elfcpp::STV_DEFAULT;
+ vis = elfcpp::STV_HIDDEN;
break;
case LDPV_DEFAULT:
default:
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch][gold] Fix symbol visibility in plugin objects
2010-05-30 6:02 [patch][gold] Fix symbol visibility in plugin objects Rafael Espindola
@ 2010-06-01 17:54 ` Cary Coutant
2010-06-01 19:46 ` Ian Lance Taylor
1 sibling, 0 replies; 3+ messages in thread
From: Cary Coutant @ 2010-06-01 17:54 UTC (permalink / raw)
To: Rafael Espindola; +Cc: Binutils
> The subject says it all :-)
>
> 2010-05-30 Rafael Espindola <espindola@google.com>
>
> * plugin.cc (Sized_pluginobj::::do_add_symbols): Correctly set the
> visibility of symbols.
Ouch. Did I really write that? LGTM, and thanks!
-cary
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch][gold] Fix symbol visibility in plugin objects
2010-05-30 6:02 [patch][gold] Fix symbol visibility in plugin objects Rafael Espindola
2010-06-01 17:54 ` Cary Coutant
@ 2010-06-01 19:46 ` Ian Lance Taylor
1 sibling, 0 replies; 3+ messages in thread
From: Ian Lance Taylor @ 2010-06-01 19:46 UTC (permalink / raw)
To: Rafael Espindola; +Cc: Binutils, Cary Coutant
Rafael Espindola <espindola@google.com> writes:
> 2010-05-30 Rafael Espindola <espindola@google.com>
>
> * plugin.cc (Sized_pluginobj::::do_add_symbols): Correctly set the
> visibility of symbols.
This is OK.
Thanks.
Ian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-01 19:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-05-30 6:02 [patch][gold] Fix symbol visibility in plugin objects Rafael Espindola
2010-06-01 17:54 ` Cary Coutant
2010-06-01 19:46 ` Ian Lance Taylor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).