From: Linus Torvalds <torvalds@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Jan Beulich <JBeulich@novell.com>,
sedat.dilek@gmail.com, Alan Modra <amodra@bigpond.net.au>,
Ingo Molnar <mingo@elte.hu>,
"H.J. Lu" <hjl.tools@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
binutils <binutils@sourceware.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: PATCH: Add --size-check=[error|warning]
Date: Mon, 14 Mar 2011 20:06:00 -0000 [thread overview]
Message-ID: <AANLkTim0SbUQ=snszAKRHXkCj_aTJr3GN12xTE1kuj5-@mail.gmail.com> (raw)
In-Reply-To: <20110314192445.GD20259@home.goodmis.org>
On Mon, Mar 14, 2011 at 12:24 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
>
> If it was a bug in asm, but binutils can cope with it, then it should be
> a warning. If binutils can't cope, then error.
I think this is the really fundamental issue: anybody who makes a hard
error out of something that is recoverable is a total moron.
We have that in the kernel too - I've berated people for using
BUG_ON() _much_ too eagerly. If you make a hard error out of
something, that just makes things much much harder to handle, and is
just a big inconvenience for everybody. Why do it?
In the kernel, a hard error (like BUG_ON()) tends to result in a
system that is unusable and makes logging things harder. And in
development tools, a hard error just means that you stop _everybody_,
whether the user is a developer or just a tester who can't
realistically fix it (or a developer who is not involved in that
area). And even for developers who _are_ directly involved, a hard
error stops the build, instead of just letting it continue and help
him see if there are perhaps _other_ cases that should also be fixed.
So anybody who makes something a hard error when it's not required is
just being a STUPID. It hurts everybody. Don't do it.
Linus
next prev parent reply other threads:[~2011-03-14 20:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 11:02 Sedat Dilek
2011-03-14 11:25 ` Jan Beulich
2011-03-14 11:35 ` Ingo Molnar
2011-03-14 11:39 ` Sedat Dilek
2011-03-14 11:53 ` Sedat Dilek
2011-03-14 12:22 ` Jan Beulich
2011-03-14 12:38 ` Sedat Dilek
2011-03-14 15:56 ` Ian Lance Taylor
2011-03-14 18:02 ` H. Peter Anvin
2011-03-14 16:33 ` H. Peter Anvin
2011-03-14 19:24 ` Steven Rostedt
2011-03-14 20:06 ` Linus Torvalds [this message]
2011-03-14 12:57 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2011-03-11 16:58 H.J. Lu
2011-03-11 17:04 ` Jan Beulich
2011-03-11 17:20 ` H.J. Lu
2011-03-14 8:44 ` Jan Beulich
2011-03-14 9:55 ` Ingo Molnar
2011-03-14 10:41 ` Alan Modra
2011-03-14 10:50 ` Pekka Enberg
2011-03-14 18:04 ` Alan Cox
2011-03-14 10:52 ` Jan Beulich
[not found] ` <AANLkTi=3AiLaw5Gnis8Ha4eRXirk0s-Cnk2zzN12YDpH__45869.1711457961$1300099861$gmane$org@mail.gmail.com>
2011-03-14 11:03 ` Andreas Schwab
2011-03-14 11:12 ` Pekka Enberg
2011-03-14 12:02 ` Andreas Schwab
2011-03-14 12:13 ` Ingo Molnar
2011-03-14 12:55 ` Andreas Schwab
2011-03-14 13:17 ` Ingo Molnar
2011-03-14 14:11 ` Andreas Schwab
2011-03-14 12:11 ` Ingo Molnar
2011-03-14 12:23 ` Ingo Molnar
2011-03-14 12:26 ` Ingo Molnar
2011-03-14 13:55 ` H.J. Lu
2011-03-16 23:56 ` Alan Modra
2011-03-18 11:20 ` Alan Modra
2011-03-18 11:59 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTim0SbUQ=snszAKRHXkCj_aTJr3GN12xTE1kuj5-@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=JBeulich@novell.com \
--cc=akpm@linux-foundation.org \
--cc=amodra@bigpond.net.au \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=sedat.dilek@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).