From: "H.J. Lu" <hjl.tools@gmail.com>
To: Dave Korn <dave.korn.cygwin@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: PATCH: PR ld/12507: Can't build a program with -flto -nostdlib
Date: Fri, 25 Feb 2011 23:08:00 -0000 [thread overview]
Message-ID: <AANLkTim19Y9t78D=Kjn2E7xo4iSGR2wD-71X9JqKORpH@mail.gmail.com> (raw)
In-Reply-To: <4D683105.70307@gmail.com>
On Fri, Feb 25, 2011 at 2:45 PM, Dave Korn <dave.korn.cygwin@gmail.com> wrote:
> On 24/02/2011 22:59, H.J. Lu wrote:
>> We should never mark entry symbol IR only. I checked in this patch as
>> an obvious fix.
>
>> --- a/ld/plugin.c
>> +++ b/ld/plugin.c
>> @@ -490,8 +490,10 @@ get_symbols (const void *handle, int nsyms, struct ld_plugin_symbol *syms)
>> even potentially-referenced, perhaps in a future final link if
>> this is a partial one, perhaps dynamically at load-time if the
>> symbol is externally visible. */
>> - ironly = !is_visible_from_outside (&syms[n], owner_sec, blhe)
>> - && !bfd_hash_lookup (non_ironly_hash, syms[n].name, FALSE, FALSE);
>> + ironly = (!is_visible_from_outside (&syms[n], owner_sec, blhe)
>> + && !bfd_hash_lookup (non_ironly_hash, syms[n].name,
>> + FALSE, FALSE)
>> + && strcmp (syms[n].name, entry_symbol.name) != 0);
>
> This caused a bunch of regressions for me:
>
>> +FAIL: plugin claimfile resolve symbol
>> +FAIL: plugin claimfile replace file
>> +FAIL: plugin ignore lib
>> +FAIL: plugin claimfile replace lib
>
> It turns out that entry_symbol.name can be NULL, and strcmp doesn't have to
> handle null pointers gracefully; it segfaulted on cygwin. We need to guard
> the test, like the attached.
>
> ld/ChangeLog:
>
> 2011-02-25 Dave Korn <....
>
> * plugin.c (get_symbols): Guard against NULL name of entry_symbol.
>
> OK?
Sorry for that. I consider it obvious.
--
H.J.
next prev parent reply other threads:[~2011-02-25 23:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 22:59 H.J. Lu
2011-02-25 22:45 ` Dave Korn
2011-02-25 23:08 ` H.J. Lu [this message]
2011-02-25 23:30 ` Alan Modra
2011-02-25 23:45 ` H.J. Lu
2011-02-25 23:59 ` Alan Modra
2011-02-26 0:09 ` Rafael Ávila de Espíndola
2011-02-26 4:34 ` H.J. Lu
2011-02-26 5:16 ` Rafael Ávila de Espíndola
2011-02-26 5:32 ` H.J. Lu
2011-02-26 4:33 ` H.J. Lu
2011-02-26 4:36 ` H.J. Lu
2011-02-26 9:04 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTim19Y9t78D=Kjn2E7xo4iSGR2wD-71X9JqKORpH@mail.gmail.com' \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
--cc=dave.korn.cygwin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).