From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17742 invoked by alias); 23 Nov 2010 18:02:36 -0000 Received: (qmail 17722 invoked by uid 22791); 23 Nov 2010 18:02:34 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-qw0-f41.google.com (HELO mail-qw0-f41.google.com) (209.85.216.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Nov 2010 18:02:18 +0000 Received: by qwj8 with SMTP id 8so420033qwj.0 for ; Tue, 23 Nov 2010 10:02:16 -0800 (PST) MIME-Version: 1.0 Received: by 10.224.199.196 with SMTP id et4mr6620429qab.271.1290535336576; Tue, 23 Nov 2010 10:02:16 -0800 (PST) Received: by 10.220.192.1 with HTTP; Tue, 23 Nov 2010 10:02:16 -0800 (PST) In-Reply-To: References: <4C27E695.9070802@codesourcery.com> <4C286200.30402@gnu.org> <4C2886C7.4040408@gnu.org> <4C28CA2A.7060703@codesourcery.com> <4C28CE9C.9030809@gnu.org> <4C28D9F1.6030309@codesourcery.com> <4CC83135.4080603@ubuntu.com> <4CCA91ED.7010909@redhat.com> <4CCAE033.3010009@ubuntu.com> <4CCAE45F.20201@gnu.org> <4CDB3413.1090900@ubuntu.com> <4CEBB272.3080708@redhat.com> <4CEBC0F4.7030404@ubuntu.com> Date: Tue, 23 Nov 2010 18:02:00 -0000 Message-ID: Subject: Re: Review of --enable-gold=both patch From: "H.J. Lu" To: Matthias Klose Cc: Nick Clifton , Paolo Bonzini , Mark Mitchell , "Joseph S. Myers" , Ian Lance Taylor , GCC Patches , binutils , Tristan Gingold Content-Type: multipart/mixed; boundary=20cf300fb2074e86d00495bc2c91 X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2010-11/txt/msg00417.txt.bz2 --20cf300fb2074e86d00495bc2c91 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 2216 On Tue, Nov 23, 2010 at 9:09 AM, H.J. Lu wrote: > On Tue, Nov 23, 2010 at 5:26 AM, Matthias Klose wrote: >> On 23.11.2010 13:24, Nick Clifton wrote: >>> >>> Hi Matthias, >>> >>> [Sorry about the delay in replying - I am in a bit of a muddle right no= w]. >>> >>>> The attached patch implements this proposal, tested the combinations >>>> above, and disabling ld without gold (leading to an error). >>>> >>>> I did choose to always install the bfd linker as ld.bfd and the gold >>>> linker as ld.gold, and pointing the link to one of the above. >>>> >>>> Nick, is this ok with you? >>> >>> Yes, it is fine. Thanks for doing this. >> >> checked in in gcc as r167076. =A0Nick, Tristan, could you check it into >> binutils trunk and branch? >> > > Binutils is broken now: > > http://www.sourceware.org/bugzilla/show_bug.cgi?id=3D12258 > This change: case "${ENABLE_LD}" in default) if test x${default_ld} !=3D xgold; then AC_MSG_ERROR([either gold or ld can be the default ld]) fi ;; is wrong. At this time, default_ld is set to gold only by --enable-gold=3D= default What we should test is if test x${default_ld} !=3D x; then which checks that default_ld isn't set. Also comments are wrong: # Handle --enable-gold, --enable-ld. # --disable-gold [--enable-ld] # Build only ld. Default option. # --enable-gold[=3Ddefault] [--enable-ld] # Build both gold and ld. Install gold as "ld.gold" and "ld", # install ld as "ld.bfd". --enable-gold only enables gold, not make it default unless ld is disabled. # --enable-gold[=3Ddefault] --disable-ld # Build only gold, which is then installed as both "ld.gold" and "ld". # --enable-gold --enable-ld=3Ddefault # Build both gold (installed as "gold") and ld (installed as "ld"). gold is installed as ld.gold. ld is also installed ld.bfd. # In other words, ld is default # --enable-gold=3Ddefault --enable-ld=3Ddefault # Error. I am checking in this patch as an obvious fix. --=20 H.J. --- 2010-11-23 H.J. Lu PR binutils/12258 * configure.ac: Correct comments for --enable-gold/--enable-ld. Properly check default linker. * configure: Regnerated. --20cf300fb2074e86d00495bc2c91 Content-Type: text/plain; charset=US-ASCII; name="binutils-pr12258-1.patch" Content-Disposition: attachment; filename="binutils-pr12258-1.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ggv365ca0 Content-length: 3506 MjAxMC0xMS0yMyAgSC5KLiBMdSAgPGhvbmdqaXUubHVAaW50ZWwuY29tPgoK CVBSIGJpbnV0aWxzLzEyMjU4CgkqIGNvbmZpZ3VyZS5hYzogQ29ycmVjdCBj b21tZW50cyBmb3IgLS1lbmFibGUtZ29sZC8tLWVuYWJsZS1sZC4KCVByb3Bl cmx5IGNoZWNrIGRlZmF1bHQgbGlua2VyLgoJKiBjb25maWd1cmU6IFJlZ25l cmF0ZWQuCgpkaWZmIC0tZ2l0IGEvY29uZmlndXJlIGIvY29uZmlndXJlCmlu ZGV4IDI3NThhYjAuLjhiNjdiYTMgMTAwNzU1Ci0tLSBhL2NvbmZpZ3VyZQor KysgYi9jb25maWd1cmUKQEAgLTI4NTQsMTMgKzI4NTQsMTcgQEAgZXNhYwog IyBIYW5kbGUgLS1lbmFibGUtZ29sZCwgLS1lbmFibGUtbGQuCiAjIC0tZGlz YWJsZS1nb2xkIFstLWVuYWJsZS1sZF0KICMgICAgIEJ1aWxkIG9ubHkgbGQu ICBEZWZhdWx0IG9wdGlvbi4KLSMgLS1lbmFibGUtZ29sZFs9ZGVmYXVsdF0g Wy0tZW5hYmxlLWxkXQorIyAtLWVuYWJsZS1nb2xkIFstLWVuYWJsZS1sZF0K KyMgICAgIEJ1aWxkIGJvdGggZ29sZCBhbmQgbGQuICBJbnN0YWxsIGdvbGQg YXMgImxkLmdvbGQiLCBpbnN0YWxsIGxkCisjICAgICBhcyAibGQuYmZkIiBh bmQgImxkIi4KKyMgLS1lbmFibGUtZ29sZD1kZWZhdWx0IFstLWVuYWJsZS1s ZF0KICMgICAgIEJ1aWxkIGJvdGggZ29sZCBhbmQgbGQuICBJbnN0YWxsIGdv bGQgYXMgImxkLmdvbGQiIGFuZCAibGQiLAogIyAgICAgaW5zdGFsbCBsZCBh cyAibGQuYmZkIi4KICMgLS1lbmFibGUtZ29sZFs9ZGVmYXVsdF0gLS1kaXNh YmxlLWxkCiAjICAgICBCdWlsZCBvbmx5IGdvbGQsIHdoaWNoIGlzIHRoZW4g aW5zdGFsbGVkIGFzIGJvdGggImxkLmdvbGQiIGFuZCAibGQiLgogIyAtLWVu YWJsZS1nb2xkIC0tZW5hYmxlLWxkPWRlZmF1bHQKLSMgICAgIEJ1aWxkIGJv dGggZ29sZCAoaW5zdGFsbGVkIGFzICJnb2xkIikgYW5kIGxkIChpbnN0YWxs ZWQgYXMgImxkIikuCisjICAgICBCdWlsZCBib3RoIGdvbGQgKGluc3RhbGxl ZCBhcyAibGQuZ29sZCIpIGFuZCBsZCAoaW5zdGFsbGVkIGFzICJsZCIKKyMg ICAgIGFuZCBsZC5iZmQpLgogIyAgICAgSW4gb3RoZXIgd29yZHMsIGxkIGlz IGRlZmF1bHQKICMgLS1lbmFibGUtZ29sZD1kZWZhdWx0IC0tZW5hYmxlLWxk PWRlZmF1bHQKICMgICAgIEVycm9yLgpAQCAtMjkyMCw3ICsyOTI0LDcgQEAg ZmkKIAogY2FzZSAiJHtFTkFCTEVfTER9IiBpbgogICBkZWZhdWx0KQotICAg IGlmIHRlc3QgeCR7ZGVmYXVsdF9sZH0gIT0geGdvbGQ7IHRoZW4KKyAgICBp ZiB0ZXN0IHgke2RlZmF1bHRfbGR9ICE9IHg7IHRoZW4KICAgICAgIGFzX2Zu X2Vycm9yICJlaXRoZXIgZ29sZCBvciBsZCBjYW4gYmUgdGhlIGRlZmF1bHQg bGQiICIkTElORU5PIiA1CiAgICAgZmkKICAgICA7OwpkaWZmIC0tZ2l0IGEv Y29uZmlndXJlLmFjIGIvY29uZmlndXJlLmFjCmluZGV4IDYyNmJiNGUuLjI5 NGYyNDEgMTAwNjQ0Ci0tLSBhL2NvbmZpZ3VyZS5hYworKysgYi9jb25maWd1 cmUuYWMKQEAgLTMyNywxMyArMzI3LDE3IEBAIGVzYWMKICMgSGFuZGxlIC0t ZW5hYmxlLWdvbGQsIC0tZW5hYmxlLWxkLgogIyAtLWRpc2FibGUtZ29sZCBb LS1lbmFibGUtbGRdCiAjICAgICBCdWlsZCBvbmx5IGxkLiAgRGVmYXVsdCBv cHRpb24uCi0jIC0tZW5hYmxlLWdvbGRbPWRlZmF1bHRdIFstLWVuYWJsZS1s ZF0KKyMgLS1lbmFibGUtZ29sZCBbLS1lbmFibGUtbGRdCisjICAgICBCdWls ZCBib3RoIGdvbGQgYW5kIGxkLiAgSW5zdGFsbCBnb2xkIGFzICJsZC5nb2xk IiwgaW5zdGFsbCBsZAorIyAgICAgYXMgImxkLmJmZCIgYW5kICJsZCIuCisj IC0tZW5hYmxlLWdvbGQ9ZGVmYXVsdCBbLS1lbmFibGUtbGRdCiAjICAgICBC dWlsZCBib3RoIGdvbGQgYW5kIGxkLiAgSW5zdGFsbCBnb2xkIGFzICJsZC5n b2xkIiBhbmQgImxkIiwKICMgICAgIGluc3RhbGwgbGQgYXMgImxkLmJmZCIu CiAjIC0tZW5hYmxlLWdvbGRbPWRlZmF1bHRdIC0tZGlzYWJsZS1sZAogIyAg ICAgQnVpbGQgb25seSBnb2xkLCB3aGljaCBpcyB0aGVuIGluc3RhbGxlZCBh cyBib3RoICJsZC5nb2xkIiBhbmQgImxkIi4KICMgLS1lbmFibGUtZ29sZCAt LWVuYWJsZS1sZD1kZWZhdWx0Ci0jICAgICBCdWlsZCBib3RoIGdvbGQgKGlu c3RhbGxlZCBhcyAiZ29sZCIpIGFuZCBsZCAoaW5zdGFsbGVkIGFzICJsZCIp LgorIyAgICAgQnVpbGQgYm90aCBnb2xkIChpbnN0YWxsZWQgYXMgImxkLmdv bGQiKSBhbmQgbGQgKGluc3RhbGxlZCBhcyAibGQiCisjICAgICBhbmQgbGQu YmZkKS4KICMgICAgIEluIG90aGVyIHdvcmRzLCBsZCBpcyBkZWZhdWx0CiAj IC0tZW5hYmxlLWdvbGQ9ZGVmYXVsdCAtLWVuYWJsZS1sZD1kZWZhdWx0CiAj ICAgICBFcnJvci4KQEAgLTM4Nyw3ICszOTEsNyBAQCBFTkFCTEVfTEQ9eWVz KQogCiBjYXNlICIke0VOQUJMRV9MRH0iIGluCiAgIGRlZmF1bHQpCi0gICAg aWYgdGVzdCB4JHtkZWZhdWx0X2xkfSAhPSB4Z29sZDsgdGhlbgorICAgIGlm IHRlc3QgeCR7ZGVmYXVsdF9sZH0gIT0geDsgdGhlbgogICAgICAgQUNfTVNH X0VSUk9SKFtlaXRoZXIgZ29sZCBvciBsZCBjYW4gYmUgdGhlIGRlZmF1bHQg bGRdKQogICAgIGZpCiAgICAgOzsK --20cf300fb2074e86d00495bc2c91--