From: "H.J. Lu" <hjl.tools@gmail.com>
To: Dave Korn <dave.korn.cygwin@gmail.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>
Subject: Re: [6/6][PATCH] Respect symbol wrappers when computing symbol resolutions.
Date: Sat, 26 Feb 2011 04:50:00 -0000 [thread overview]
Message-ID: <AANLkTimZKjT_uHSgd3jqN5JXRAGhpRhEWs-b1vgD_YVD@mail.gmail.com> (raw)
In-Reply-To: <4D684D79.9090708@gmail.com>
On Fri, Feb 25, 2011 at 4:46 PM, Dave Korn <dave.korn.cygwin@gmail.com> wrote:
>
> Hi list,
>
> I found this running the GCC testsuite, where on cygwin we use ld wrappers
> to allow replacement of libstdc++ new/delete operators.
>
> ld/ChangeLog:
>
> 2011-02-24 Dave Korn <...
>
> * plugin.c (get_symbols): Use wrapped lookup for undefined symbols.
>
> I'd like it if someone can confirm that I've correctly interpreted the
> comment that precedes the definition of bfd_wrapped_link_hash_lookup, about
> how it should "only be used for references to an undefined symbol, not for
> definitions of a symbol"; I took that to mean that I should key off the
> initial state of defined-ness of the symbol passed from the plugin and call
> either a wrapped or unwrapped lookup accordingly, but possibly since we're
> asking about the resolution of a symbol, it would make as much sense to always
> treat this as if we were looking up an undefined reference and simply always
> call the wrapped lookup?
>
You can add a testcase to LTO tests on lto-mixed branch.
--
H.J.
next prev parent reply other threads:[~2011-02-26 4:50 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-26 0:44 [PATCH,trunk+2.20] Fix issues in ld.bfd plugin interface [0/6] Dave Korn
2011-02-26 0:45 ` [PATCH,trunk+2.21] " Dave Korn
2011-02-26 0:45 ` [1/6][PATCH] Fix PE-COFF bug in orphan section alignment handling Dave Korn
2011-02-26 9:14 ` Alan Modra
2011-02-26 0:46 ` [4/6][PATCH] Fix issue from GCC PR47527: no ELF flags, EABI attribs, etc. in dummy IR BFD Dave Korn
2011-02-26 0:48 ` Dave Korn
2011-02-26 9:16 ` Alan Modra
2011-02-26 0:46 ` [3/6][PATCH] Revise linker plugin API to better preserve link order Dave Korn
2011-02-26 9:15 ` Alan Modra
2011-02-26 0:46 ` [2/6][PATCH] Do not use dummy bfd suffix for recognition, make it human-readable instead Dave Korn
2011-02-26 0:46 ` [5/6][PATCH] Perform second link stage and ignore now-obsolete linker -pass-through= option Dave Korn
2011-02-26 0:48 ` Dave Korn
2011-02-26 4:03 ` Rafael Ávila de Espíndola
2011-02-27 18:54 ` Ian Lance Taylor
2011-02-27 19:11 ` Rafael Ávila de Espíndola
2011-02-27 19:22 ` Ian Lance Taylor
2011-02-27 19:37 ` Rafael Ávila de Espíndola
2011-02-26 9:05 ` Alan Modra
2011-02-26 0:47 ` [x/6][PATCH] Portability tweaks for LTO tests Dave Korn
2011-02-26 0:49 ` Dave Korn
2011-02-26 3:50 ` H.J. Lu
2011-02-26 5:33 ` H.J. Lu
2011-02-26 0:47 ` [6/6][PATCH] Respect symbol wrappers when computing symbol resolutions Dave Korn
2011-02-26 0:49 ` Dave Korn
2011-02-26 4:50 ` H.J. Lu [this message]
2011-02-26 9:28 ` Alan Modra
2011-02-26 2:14 ` [PATCH,trunk+2.20] Fix issues in ld.bfd plugin interface [0/6] H.J. Lu
2011-02-26 3:37 ` Dave Korn
2011-02-26 3:48 ` H.J. Lu
2011-03-10 10:43 ` Dave Korn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimZKjT_uHSgd3jqN5JXRAGhpRhEWs-b1vgD_YVD@mail.gmail.com \
--to=hjl.tools@gmail.com \
--cc=binutils@sourceware.org \
--cc=dave.korn.cygwin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).