From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7244 invoked by alias); 17 Aug 2010 14:01:27 -0000 Received: (qmail 7148 invoked by uid 22791); 17 Aug 2010 14:01:26 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mail-fx0-f41.google.com (HELO mail-fx0-f41.google.com) (209.85.161.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Aug 2010 14:01:18 +0000 Received: by fxm3 with SMTP id 3so3867896fxm.0 for ; Tue, 17 Aug 2010 07:01:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.103.134 with SMTP id k6mr6633592fao.5.1282053676521; Tue, 17 Aug 2010 07:01:16 -0700 (PDT) Received: by 10.223.109.134 with HTTP; Tue, 17 Aug 2010 07:01:16 -0700 (PDT) In-Reply-To: References: <1281767203-21421-1-git-send-email-vapier@gentoo.org> Date: Tue, 17 Aug 2010 14:15:00 -0000 Message-ID: Subject: Re: [PATCH] libiberty: add HAVE_CONFIG_H check to all files (lacking it already) From: Mike Frysinger To: Ian Lance Taylor Cc: binutils@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00197.txt.bz2 On Tue, Aug 17, 2010 at 9:46 AM, Ian Lance Taylor wrote: > Mike Frysinger writes: >> On Tue, Aug 17, 2010 at 9:15 AM, Ian Lance Taylor wrote: >>> No, those files were copied from projects like gnulib, which exist to >>> provide files to be included in other programs. >> >> looking closer, i'm not sure that's true. =A0there are plenty of files >> labeled "This file is part of libiberty." that have HAVE_CONFIG_H >> protection. =A0what really strikes me though is that some files which >> have this protection require other files which do not. =A0which again is >> how i got here in the first place. > > In that case I would personally prefer that the #ifdef HAVE_CONFIG_H be > removed from those files, since it should not be needed. well, that would cause me more issues, so i'm not inclined to post a patch to "fix" those files ;) guess i'll just live with having to modify files by hand in order to do tes= ting -mike