From: Kai Tietz <ktietz70@googlemail.com>
To: Dave Korn <dave.korn.cygwin@gmail.com>
Cc: Binutils <binutils@sourceware.org>
Subject: Re: [patch ld]: Testsuite fix of vers-script-3 and vers-script-4 tests
Date: Tue, 15 Feb 2011 16:16:00 -0000 [thread overview]
Message-ID: <AANLkTimt5Nea-8vxD0r4w-ksJ06VjHv-=ZQ2V2EcA0ar@mail.gmail.com> (raw)
In-Reply-To: <AANLkTi=5+Tfqt3fF3pttKnee7zVTkJUSz9nTG3Rj1Bk9@mail.gmail.com>
2011/2/15 Kai Tietz <ktietz70@googlemail.com>:
> 2011/2/15 Dave Korn <dave.korn.cygwin@gmail.com>:
>> On 15/02/2011 15:30, Kai Tietz wrote:
>>
>>> Ok, I withdraw recent patch. It is just fixing the symptoms but not
>>> the underlying issue.
>>> For 32-bit COFF the real issue is in pe-dll.c file in function
>>> process_def_file_and_drectve. Here the underscore of a symbol is
>>> stripped, and the same time it is done in bfd_demangle, which is used
>>> by bfd_find_version_for_sym. By this in 32-bit case with leading
>>> underscores, they were stripped twice.
>>>
>>> ChangeLog
>>>
>>> 2011-02-15 Kai Tietz
>>>
>>> * pe-dll.c (process_def_file_and_drectve): Don't strip
>>> leading underscore from symbol by calling bfd_find_version_for_sym.
>>>
>>> Tested for x86_64-w64-mingw32, i686-pc-cygwin, and i686-w64-mingw32.
>>> Ok for apply?
>>
>> Nope. This causes two regressions on i686-pc-cygwin:
>>
>>> FAIL: vers-script-3
>>> FAIL: vers-script-4
>>
>> They pass currently. They fail with your patch. I'm reasonably sure that I
>> only added that underscore-stripping code when I discovered it to be
>> necessary, but I may not have tested it on a non-prefixing host.
>>
>> I don't understand why you want to remove the underscore stripping code to
>> solve a problem on w64, where it should never be active in any case?
>>
>> cheers,
>> DaveK
>>
>>
>
> Well, for none-underscored code I see no regressions. I see it for
> 32-bit mingw and cygwin. Have you updated your tree? I assume it is
> related to some indirect changes.
>
> For me the vers-script-3 and vers-script-4 tests in pe-ld are failing
> at the moment in an unpatched variant.
>
> Kai
>
> PS: See
> 2011-02-14 Mike Frysinger <vapier@gentoo.org>
>
> * ldlang.c (lang_vers_match): Declare a new c_sym, assign it to
> the bfd_demangle of sym, change users of sym to c_sym when not
> already demangling, and free when done. Change callers of
> cplus_demangle to bfd_demangle.
>
> This could be the culprit here.
>
Applied.
Thanks,
Kai
prev parent reply other threads:[~2011-02-15 16:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 12:42 Kai Tietz
2011-02-15 15:30 ` Kai Tietz
2011-02-15 15:55 ` Dave Korn
2011-02-15 16:03 ` Dave Korn
2011-02-15 16:07 ` Dave Korn
2011-02-15 16:08 ` Kai Tietz
2011-02-15 16:16 ` Kai Tietz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTimt5Nea-8vxD0r4w-ksJ06VjHv-=ZQ2V2EcA0ar@mail.gmail.com' \
--to=ktietz70@googlemail.com \
--cc=binutils@sourceware.org \
--cc=dave.korn.cygwin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).