From: Sriraman Tallam <tmsriram@google.com>
To: binutils <binutils@sourceware.org>, Ian Lance Taylor <iant@google.com>
Subject: Delaying fills generation while ordering sections in gold.
Date: Sat, 12 Feb 2011 01:54:00 -0000 [thread overview]
Message-ID: <AANLkTinaAzrix7D1JwtWAj2XPgRMmx5TVYGMBatLYhQz@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 274 bytes --]
Hi,
I have attached a simple patch to delay fills generation for output
sections when input sections could be reordered using
--section-ordering-file flag.
* output.cc (Output_section::add_input_section): Delay fill
generation for section ordering.
Thanks,
-Sri.
[-- Attachment #2: gold_patch.txt --]
[-- Type: text/plain, Size: 1159 bytes --]
Index: output.cc
===================================================================
RCS file: /cvs/src/src/gold/output.cc,v
retrieving revision 1.139
diff -u -u -p -r1.139 output.cc
--- output.cc 16 Nov 2010 19:18:31 -0000 1.139
+++ output.cc 12 Feb 2011 01:48:50 -0000
@@ -2111,12 +2111,14 @@ Output_section::add_input_section(Layout
// Determine if we want to delay code-fill generation until the output
// section is written. When the target is relaxing, we want to delay fill
- // generating to avoid adjusting them during relaxation.
+ // generating to avoid adjusting them during relaxation. Also, if we are
+ // sorting input sections we must delay fill generation.
if (!this->generate_code_fills_at_write_
&& !have_sections_script
&& (sh_flags & elfcpp::SHF_EXECINSTR) != 0
&& parameters->target().has_code_fill()
- && parameters->target().may_relax())
+ && (parameters->target().may_relax()
+ || parameters->options().section_ordering_file()))
{
gold_assert(this->fills_.empty());
this->generate_code_fills_at_write_ = true;
cvs diff: Diffing po
cvs diff: Diffing testsuite
next reply other threads:[~2011-02-12 1:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-12 1:54 Sriraman Tallam [this message]
2011-02-12 2:10 ` Ian Lance Taylor
2011-02-12 3:20 ` Sriraman Tallam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTinaAzrix7D1JwtWAj2XPgRMmx5TVYGMBatLYhQz@mail.gmail.com \
--to=tmsriram@google.com \
--cc=binutils@sourceware.org \
--cc=iant@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).