From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21765 invoked by alias); 15 Feb 2011 15:30:21 -0000 Received: (qmail 21754 invoked by uid 22791); 15 Feb 2011 15:30:19 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-qy0-f169.google.com (HELO mail-qy0-f169.google.com) (209.85.216.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 Feb 2011 15:30:13 +0000 Received: by qyk7 with SMTP id 7so2207533qyk.0 for ; Tue, 15 Feb 2011 07:30:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.229.75.18 with SMTP id w18mr4105958qcj.95.1297783811234; Tue, 15 Feb 2011 07:30:11 -0800 (PST) Received: by 10.229.214.131 with HTTP; Tue, 15 Feb 2011 07:30:11 -0800 (PST) In-Reply-To: References: Date: Tue, 15 Feb 2011 15:30:00 -0000 Message-ID: Subject: Re: [patch ld]: Testsuite fix of vers-script-3 and vers-script-4 tests From: Kai Tietz To: Binutils Cc: Dave Korn Content-Type: multipart/mixed; boundary=0016364270c8105fda049c53d7d0 X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00165.txt.bz2 --0016364270c8105fda049c53d7d0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 1037 2011/2/15 Kai Tietz : > Hello, > > ChangeLog > > 2011-02-15 =A0Kai Tietz > > =A0 =A0 =A0 =A0* ld-pe/vers-script-3.ver: Add _Z* to global and use > =A0 =A0 =A0 =A0wildcard for personality symbols. > =A0 =A0 =A0 =A0* ld-pe/vers-script-4.ver: Likewise. > > Tested for x86_64-w64-mingw32 and i686-w64-mingw32. Ok for apply? > > Regards, > Kai > Ok, I withdraw recent patch. It is just fixing the symptoms but not the underlying issue. For 32-bit COFF the real issue is in pe-dll.c file in function process_def_file_and_drectve. Here the underscore of a symbol is stripped, and the same time it is done in bfd_demangle, which is used by bfd_find_version_for_sym. By this in 32-bit case with leading underscores, they were stripped twice. ChangeLog 2011-02-15 Kai Tietz * pe-dll.c (process_def_file_and_drectve): Don't strip leading underscore from symbol by calling bfd_find_version_for_sy= m. Tested for x86_64-w64-mingw32, i686-pc-cygwin, and i686-w64-mingw32. Ok for apply? Regards, Kai --0016364270c8105fda049c53d7d0 Content-Type: text/plain; charset=US-ASCII; name="pe_dll.txt" Content-Disposition: attachment; filename="pe_dll.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gk6yxszs1 Content-length: 846 SW5kZXg6IHBlLWRsbC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZp bGU6IC9jdnMvc3JjL3NyYy9sZC9wZS1kbGwuYyx2CnJldHJpZXZpbmcgcmV2 aXNpb24gMS4xMzMKZGlmZiAtdSAtMyAtcjEuMTMzIHBlLWRsbC5jCi0tLSBw ZS1kbGwuYwkyNyBKdW4gMjAxMCAwNDowNzo1NCAtMDAwMAkxLjEzMworKysg cGUtZGxsLmMJMTUgRmViIDIwMTEgMTU6MjM6MTcgLTAwMDAKQEAgLTcyMCw5 ICs3MjAsOCBAQAogCSAgICAgIGlmIChsYW5nX2VsZl92ZXJzaW9uX2luZm8g JiYgd291bGRfZXhwb3J0KQogCQl7CiAJCSAgYmZkX2Jvb2xlYW4gaGlkZSA9 IDA7Ci0JCSAgY2hhciBvZnMgPSBwZV9kZXRhaWxzLT51bmRlcnNjb3JlZCAm JiBzeW1ib2xzW2pdLT5uYW1lWzBdID09ICdfJzsKIAkJICAodm9pZCkgYmZk X2ZpbmRfdmVyc2lvbl9mb3Jfc3ltIChsYW5nX2VsZl92ZXJzaW9uX2luZm8s Ci0JCQkJc3ltYm9sc1tqXS0+bmFtZSArIG9mcywgJmhpZGUpOworCQkJCXN5 bWJvbHNbal0tPm5hbWUsICZoaWRlKTsKIAkJICB3b3VsZF9leHBvcnQgPSAh aGlkZTsKIAkJfQogCSAgICAgIGlmICh3b3VsZF9leHBvcnQpCg== --0016364270c8105fda049c53d7d0--