From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp001-out.apm-internet.net (smtp001-out.apm-internet.net [85.119.248.222]) by sourceware.org (Postfix) with ESMTPS id ECC60385840C for ; Tue, 26 Sep 2023 07:54:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ECC60385840C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sandoe.co.uk Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sandoe.co.uk Received: (qmail 83260 invoked from network); 26 Sep 2023 07:54:11 -0000 X-APM-Out-ID: 16957148518325 X-APM-Authkey: 257869/1(257869/1) 5 Received: from unknown (HELO smtpclient.apple) (81.138.1.83) by smtp001.apm-internet.net with SMTP; 26 Sep 2023 07:54:11 -0000 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\)) Subject: Re: [PATCH v2 1/2] *: add modern gettext support From: Iain Sandoe In-Reply-To: <1c90c3ea-0b54-520c-8524-7feb6b88212e@suse.com> Date: Tue, 26 Sep 2023 08:54:10 +0100 Cc: =?utf-8?Q?Arsen_Arsenovi=C4=87?= , Bruno Haible , GDB Patches , GCC Binutils Content-Transfer-Encoding: quoted-printable Message-Id: References: <20230926004300.1716711-2-arsen@aarsen.me> <20230926004300.1716711-3-arsen@aarsen.me> <1c90c3ea-0b54-520c-8524-7feb6b88212e@suse.com> To: Jan Beulich X-Mailer: Apple Mail (2.3696.120.41.1.4) X-Spam-Status: No, score=2.0 required=5.0 tests=BAYES_50,BODY_8BITS,KAM_COUK,KAM_DMARC_STATUS,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jan, > On 26 Sep 2023, at 08:03, Jan Beulich wrote: >=20 > On 26.09.2023 02:17, Arsen Arsenovi=C4=87 via Binutils wrote: >> ChangeLog: >>=20 >> * .gitignore: Add '/gettext*'. >> * configure.ac (host_libs): Replace intl with gettext. >> (hbaseargs, bbaseargs, baseargs): Split baseargs into = {h,b}baseargs. >> (skip_barg): New flag. Skips appending current flag to = bbaseargs. >> : Exempt --with-libintl-{type,prefix} from >> target and build machine argument passing. >> * configure: Regenerate. >> * Makefile.def (host_modules): Replace intl module with gettext >> module. >> (configure-ld): Depend on configure-gettext. >> * Makefile.in: Regenerate. >>=20 >> config/ChangeLog: >>=20 >> * intlmacosx.m4: Import from gettext-0.22 (serial 8). >> * gettext.m4: Sync with gettext-0.22 (serial 77). >> * gettext-sister.m4 (ZW_GNU_GETTEXT_SISTER_DIR): Load gettext's >> uninstalled-config.sh, or call AM_GNU_GETTEXT if missing. >> * iconv.m4: Sync with gettext-0.22 (serial 26). >>=20 >> gas/ChangeLog: >>=20 >> * aclocal.m4: Regenerate. >> * configure: Regenerate. >>=20 >> gold/ChangeLog: >>=20 >> * aclocal.m4: Regenerate. >> * configure: Regenerate. >>=20 >> gprof/ChangeLog: >>=20 >> * aclocal.m4: Regenerate. >> * configure: Regenerate. >>=20 >> ld/ChangeLog: >>=20 >> * aclocal.m4: Regenerate. >> * configure: Regenerate. >>=20 >> libctf/ChangeLog: >>=20 >> * Makefile.am (SUBDIRS): Define to empty to suppress a check in >> Automake. >> * Makefile.in: Regenerate. >> * configure.ac (CTF_LIBADD): Use LTLIBINTL rather than LIBINTL. >> * aclocal.m4: Regenerate. >> * configure: Regenerate. >>=20 >> opcodes/ChangeLog: >>=20 >> * aclocal.m4: Regenerate. >> * po/Make-in ($(srcdir)/$(PACKAGE).pot): Output to a .pot >> temporary file to suppress xgettext checking charset names. >> * configure.ac (SHARED_LIBADD): Use LTLIBINTL rather than = LIBINTL. >> * configure: Regenerate. >>=20 >> bfd/ChangeLog: >>=20 >> * aclocal.m4: Regenerate. >> * configure.ac (SHARED_LIBADD): Use LTLIBINTL rather than = LIBINTL. >> * configure: Regenerate. >>=20 >> binutils/ChangeLog: >>=20 >> * aclocal.m4: Regenerate. >> * configure: Regenerate. >=20 > May I please ask that a change like this come with a real description? = The > ChangeLog entries certainly describe - purely mechanically - what is = done > to the files, but to be honest I cannot really read out of the (large) > patch what the overall behavioral change is. I'm therefore only = getting > the impression that you make gettext 0.22(?) a prereq to building = binutils > and gdb. I=E2=80=99ll leave to Arsen to expand upon this ^ > Which in turn may make it impossible to (easily) build either on > older systems (it would certainly limit [remove?] my ability to test = 32-bit > builds of binutils, as the newer distros I use all only come in 64-bit > flavors; there may be ways to configure as 32-bit, but past experience = has > shown that such is potentially fragile / only partially functioning). I have one datum at least: In this context, gettext is a host library, so the concern is about the = oldest, least capable, hosts you might wish to support. * AFAIU, if your host already has libintl installed you do not need to = do anything (unless you happen to want a newer version). * My oldest (regularly-tested) 32b host is Darwin9 (2007): - it has no installed libintl - it is not even ELF. Here: * if I do nothing, binutils builds without NLS support. * If I symlink (or copy) gettext 0.22 into the root source dir then it = builds along with the other sources and I get NLS support. HTH (at least as some reassurance that we have tested in older = environments) Iain $ LANG=3Dja_JP = /opt/iains/i686-apple-darwin9/binutils-gdb-master/bin/objdump fff =E4=BD=BF=E7=94=A8=E6=B3=95: = /opt/iains/i686-apple-darwin9/binutils-gdb-master/bin/objdump = =E3=82=AA=E3=83=96=E3=82=B8=E3=82=A7=E3=82=AF=E3=83=88=E3=83=95=E3=82=A1=E3= =82=A4=E3=83=AB =E3=81=AE=E6=83=85=E5=A0=B1=E3=82=92=E8=A1=A8=E7= =A4=BA=E3=81=99=E3=82=8B = =E4=B8=8B=E8=A8=98=E3=81=AE=E3=82=B9=E3=82=A4=E3=83=83=E3=83=81=E3=81=AE=E4= =B8=AD=E3=81=A7=E6=9C=80=E4=BD=8E=E4=B8=80=E3=81=A4=E3=81=AF=E6=8C=87=E5=AE= =9A=E3=81=97=E3=81=AA=E3=81=91=E3=82=8C=E3=81=B0=E3=81=84=E3=81=91=E3=81=BE= =E3=81=9B=E3=82=93: