From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22962 invoked by alias); 9 Apr 2011 16:07:14 -0000 Received: (qmail 22948 invoked by uid 22791); 9 Apr 2011 16:07:11 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-qy0-f169.google.com (HELO mail-qy0-f169.google.com) (209.85.216.169) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 09 Apr 2011 16:07:06 +0000 Received: by qyk2 with SMTP id 2so491842qyk.0 for ; Sat, 09 Apr 2011 09:07:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.224.187.73 with SMTP id cv9mr2819026qab.26.1302365226187; Sat, 09 Apr 2011 09:07:06 -0700 (PDT) Received: by 10.229.97.206 with HTTP; Sat, 9 Apr 2011 09:07:06 -0700 (PDT) In-Reply-To: <20110409140103.GI19002@bubble.grove.modra.org> References: <20110407010943.GW19002@bubble.grove.modra.org> <20110407085238.GZ19002@bubble.grove.modra.org> <20110409043456.GG19002@bubble.grove.modra.org> <20110409131155.GH19002@bubble.grove.modra.org> <20110409140103.GI19002@bubble.grove.modra.org> Date: Sat, 09 Apr 2011 16:07:00 -0000 Message-ID: Subject: Re: [patch bfd]: Prevent possible buffer overflow on pdata-section sorting From: Kai Tietz To: Alan Modra , Binutils Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00140.txt.bz2 2011/4/9 Alan Modra : > On Sat, Apr 09, 2011 at 03:17:31PM +0200, Kai Tietz wrote: >> 2011/4/9 Alan Modra : >> > On Sat, Apr 09, 2011 at 11:50:45AM +0200, Kai Tietz wrote: >> >> Ok, AFAICS it is enough here to set rawsize at one place. >> > >> > Yes. >> > >> >> Just for bss-section we don't want to set rawsize. >> > >> > Why is that? >> > >> >> --- src.orig/bfd/coffcode.h =A0 2011-04-09 10:29:19.000000000 +0200 >> >> +++ src/bfd/coffcode.h =A0 =A0 =A0 =A02011-04-09 11:46:45.938100500 += 0200 >> >> @@ -3297,6 +3297,11 @@ coff_compute_section_file_positions (bfd >> >> =A0 =A0 =A0 =A0if (!(current->flags & SEC_HAS_CONTENTS)) >> >> =A0 =A0 =A0 continue; >> > >> > Won't the above test exclude .bss anyway? >> >> Hmm, this might be bogus. I've tested it without this check and it >> seems to work still. So I can remove this check. Ok then for apply? > > Yes, OK. > > -- > Alan Modra > Australia Development Lab, IBM > Ok, applied. Thanks, Kai