Re: [Patch] bfd elfxx-ia64: share code between elf32 and elf64

["H.J. Lu" <hjl.tools@gmail.com>]

On Tue, May 17, 2011 at 6:10 AM, Tristan Gingold <gingold@adacore.com> wrote:
>
> On May 17, 2011, at 3:04 PM, H.J. Lu wrote:
>
>> On Tue, May 17, 2011 at 5:56 AM, Tristan Gingold <gingold@adacore.com> wrote:
>>> Hi,
>>>
>>> some functions of elfxx-ia64.c are in fact the same when compiled for elf32 and for elf64.  This patch adds a new file,
>>> elfxx-ia64.h which declares these functions and compiles them only for elf64.
>>>
>>> No regression for linux/gnu ia64 and hpux ia64.
>>>
>>> This work is in fact preliminary work to support gnu ld on vms/ia64.  Although VMS uses elf64, it doesn't use the same shared library
>>> model.  Its DSO model is derived from the previous vms one (vector based). This made code reuse difficult.
>>>
>>> Ok for trunk ?
>>>
>>
>> Why not do something similar to SPARC/MIPS to put common codes in
>> a new .c file?
>
> That's fine with me.  My proposal would be:
>
> size specific code to elfnn-ia64.c
> common code to elfxx-ia64.c (to match mips and sparc).
>
> Do you agree with this proposal ?
>

I like it.  FWIW, I planned to do it a long ago.

Thanks.

-- 
H.J.