From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29670 invoked by alias); 16 May 2011 13:41:29 -0000 Received: (qmail 29525 invoked by uid 22791); 16 May 2011 13:41:27 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,TW_BJ X-Spam-Check-By: sourceware.org Received: from mail-qw0-f41.google.com (HELO mail-qw0-f41.google.com) (209.85.216.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 May 2011 13:41:13 +0000 Received: by qwa26 with SMTP id 26so3118487qwa.0 for ; Mon, 16 May 2011 06:41:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.26.131 with SMTP id e3mr3175292qcc.254.1305553272156; Mon, 16 May 2011 06:41:12 -0700 (PDT) Received: by 10.229.182.7 with HTTP; Mon, 16 May 2011 06:41:12 -0700 (PDT) In-Reply-To: <201105161335.p4GDZms9016712@ignucius.se.axis.com> References: <43974448-D817-48FF-B7E8-1AE01EC9D0C9@adacore.com> <201105161335.p4GDZms9016712@ignucius.se.axis.com> Date: Mon, 16 May 2011 13:41:00 -0000 Message-ID: Subject: Re: [Patch] Add private dumper to objdump From: "H.J. Lu" To: Hans-Peter Nilsson Cc: gingold@adacore.com, binutils@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00214.txt.bz2 On Mon, May 16, 2011 at 6:35 AM, Hans-Peter Nilsson wrote: >> From: Tristan Gingold >> Date: Mon, 16 May 2011 14:22:32 +0200 > >> On May 10, 2011, at 4:46 AM, Alan Modra wrote: >> >> > On Thu, May 05, 2011 at 04:27:38PM +0200, Tristan Gingold wrote: >> >> =A0 =A0* od-xcoff.c: New file. >> >> =A0 =A0* objdump.h: New file. >> >> =A0 =A0* objdump.c: Include objdump.h >> >> =A0 =A0(dump_private_options, objdump_private_vectors): New variables. >> >> =A0 =A0(usage): Mention -P/--private. =A0Display handled options. >> >> =A0 =A0(long_options): Add -P/--private. >> >> =A0 =A0(dump_target_specific): New function. >> >> =A0 =A0(dump_bfd): Handle dump_private_options. >> >> =A0 =A0(main): Handle -P. >> >> =A0 =A0* doc/binutils.texi (objdump): Document -P/--private. >> >> =A0 =A0* configure.in (OBJDUMP_PRIVATE_VECTORS, OBJDUMP_PRIVATE_OFILE= S): >> >> =A0 =A0New variables, compute them. >> >> =A0 =A0(od_vectors): Add vectors for private dumpers. Make them uniq. >> >> =A0 =A0(OBJDUMP_DEFS): Add OBJDUMP_PRIVATE_VECTORS. >> >> =A0 =A0* Makefile.am (HFILES): Add objdump.h >> >> =A0 =A0(CFILES): Add od-xcoff.c >> >> =A0 =A0(OBJDUMP_PRIVATE_OFILES): New variable. >> >> =A0 =A0(objdump_DEPENDENCIES): Append OBJDUMP_PRIVATE_OFILES. >> >> =A0 =A0(objdump_LDADD): Ditto. >> >> =A0 =A0(EXTRA_objdump_SOURCES): Define. >> >> =A0 =A0* Makefile.in: Regenerate. >> >> =A0 =A0* configure: Regenerate. >> > >> > OK. >> >> Thanks, committed. There is no ChangeLog entry. > Looks like you missed updating the test-suite. =A0Changing the > format of objdump or readelf requires that. =A0My autotester > complains for cris-axis-elf and cris-axis-linux-gnu: > > Running /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-scripts/phdrs.e= xp ... > FAIL: PHDRS > Running /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-scripts/phdrs2.= exp ... > FAIL: PHDRS2 > > But, I can't trivially figure out why the test-suite fails as it > does; it looks like the same thing would happen for all > architectures and the failure mode is weird. =A0Quoting the ld.log > for the first failure ("same" for the second): The problem is we have -p, --private-headers Display object format specific file header conte= nts and we support short and unambiguous names. --=20 H.J.