public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Paul Schlie <schlie@comcast.net>
To: Zack Weinberg <zack@codesourcery.com>
Cc: Alan Modra <amodra@bigpond.net.au>,
	Ben Elliston <bje@au1.ibm.com>, <binutils@sources.redhat.com>,
	Nick Clifton <nickc@redhat.com>
Subject: Re: Add -Werror to build_warnings
Date: Fri, 18 Feb 2005 16:08:00 -0000	[thread overview]
Message-ID: <BE3AE1F3.9217%schlie@comcast.net> (raw)
In-Reply-To: <87r7jebhqu.fsf@codesourcery.com>

> From: Zack Weinberg <zack@codesourcery.com>
> Would you please write complete sentences?  Your telegraphic style is
> extremely difficult to read.
>> Paul Schlie <schlie@comcast.net> writes:
>> - Fully understand your position in general, however honestly question the
>>   utility of the specific warning: of a comparison between two pointers to
>>   otherwise equivalent rank data types which only in sign-ness; as it's not
>>   clear that such a comparison could ever lead to unintended consequences,
> 
> You are mistaken.  We flushed all these warnings out of GCC about a
> year ago, and we found real bugs.  Mostly, if I recall correctly, they
> were cases where the two pointers should never have been being
> compared in the first place, and this was the only diagnostic you got.

- OK, I accept that it basically forces you to at least look; at which time
  you may discover something that wasn't intended somewhere. Which one could
  argue is better than nothing.

Thanks,



  reply	other threads:[~2005-02-18  5:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-18 15:58 Paul Schlie
2005-02-18 16:05 ` Zack Weinberg
2005-02-18 16:08   ` Paul Schlie [this message]
2005-02-18 16:23 ` Alan Modra
  -- strict thread matches above, loose matches on Subject: below --
2005-02-18  6:33 Paul Schlie
2005-02-18 14:34 ` Alan Modra
2005-02-16  5:01 Ben Elliston
2005-02-16  6:30 ` Alan Modra
2005-02-16  7:27   ` Ben Elliston
2005-02-16 13:01     ` Nick Clifton
2005-02-18  2:56   ` Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BE3AE1F3.9217%schlie@comcast.net \
    --to=schlie@comcast.net \
    --cc=amodra@bigpond.net.au \
    --cc=binutils@sources.redhat.com \
    --cc=bje@au1.ibm.com \
    --cc=nickc@redhat.com \
    --cc=zack@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).