From: Gilles DUBOSCQ <gilles.m.duboscq@oracle.com>
To: Vladimir Mezentsev <vladimir.mezentsev@oracle.com>
Cc: "binutils@sourceware.org" <binutils@sourceware.org>,
Ruud van der Pas <ruud.vanderpas@oracle.com>
Subject: Re: gprofng SIGSEGV when processing unusual dwarf
Date: Tue, 7 Feb 2023 09:39:03 +0000 [thread overview]
Message-ID: <BLAPR10MB529889278B23B0B9797683BAABDB9@BLAPR10MB5298.namprd10.prod.outlook.com> (raw)
In-Reply-To: <BLAPR10MB5298E4043C8F2A0ED0318463ABDB9@BLAPR10MB5298.namprd10.prod.outlook.com>
Hi Vladimir,
I saw you posted a patch for this. A few remarks:
* Regarding the NO_STMT_LIST, i'm not sure what it the correct/portable way of defining uint64_t constants, i used a ULL literal for my tests but maybe UINT64_MAX should be used instead? I'm not sure exactly if this is available in all the environments where gprofng is built.
* Regarding the change in DwrCU::parse_cu_header, i think Dwarf_ref will also return 0 when the attribute is not found, what i was trying to achieve in my tests was for stmt_list_offset to be kept at its default NO_STMT_LIST value if the attribute is absent.
Best regards,
Gilles
next prev parent reply other threads:[~2023-02-07 9:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 16:37 Gilles DUBOSCQ
2023-02-06 20:28 ` Ruud van der Pas
2023-02-07 8:45 ` Gilles DUBOSCQ
2023-02-07 9:39 ` Gilles DUBOSCQ [this message]
2023-02-07 22:44 ` Vladimir Mezentsev
2023-02-08 8:30 ` Gilles DUBOSCQ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BLAPR10MB529889278B23B0B9797683BAABDB9@BLAPR10MB5298.namprd10.prod.outlook.com \
--to=gilles.m.duboscq@oracle.com \
--cc=binutils@sourceware.org \
--cc=ruud.vanderpas@oracle.com \
--cc=vladimir.mezentsev@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).