From: Chen Gang <xili_gchen_5257@hotmail.com>
To: binutils@sourceware.org
Subject: [PATCH] ld/ldmain.c (main): Use %F instead of %X for einfo().
Date: Tue, 17 Mar 2015 23:55:00 -0000 [thread overview]
Message-ID: <BLU436-SMTP1361F406467D82A57C8069AB9030@phx.gbl> (raw)
When src or dst is NULL, the next fread or fwrite will cause segment
fault, so we need treat it as fatal case in einfo().
2015-03-18 Chen Gang <gang.chen.5i5j@gmail.com>
* ldmain.c (main): Use %F instead of %X for einfo().
---
ld/ChangeLog | 4 ++++
ld/ldmain.c | 4 ++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/ld/ChangeLog b/ld/ChangeLog
index 0f8fbc4..72202c2 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,7 @@
+2015-03-18 Chen Gang <gang.chen.5i5j@gmail.com>
+
+ * ldmain.c (main): Use %F instead of %X for einfo().
+
2015-03-02 Alan Modra <amodra@gmail.com>
* ld.texinfo (Options <-z nocopyreloc>): Rewrite.
diff --git a/ld/ldmain.c b/ld/ldmain.c
index 4b41288..6674a80 100644
--- a/ld/ldmain.c
+++ b/ld/ldmain.c
@@ -484,10 +484,10 @@ main (int argc, char **argv)
dst = fopen (dst_name, FOPEN_WB);
if (!src)
- einfo (_("%X%P: unable to open for source of copy `%s'\n"),
+ einfo (_("%P%F: unable to open for source of copy `%s'\n"),
output_filename);
if (!dst)
- einfo (_("%X%P: unable to open for destination of copy `%s'\n"),
+ einfo (_("%P%F: unable to open for destination of copy `%s'\n"),
dst_name);
while ((l = fread (buf, 1, bsize, src)) > 0)
{
--
1.9.3
next reply other threads:[~2015-03-17 23:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 23:55 Chen Gang [this message]
2015-03-18 1:18 ` Alan Modra
[not found] <BLU436-SMTP1074DBE9281017DAB4DB3A9B9000@phx.gbl>
2015-03-18 10:32 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BLU436-SMTP1361F406467D82A57C8069AB9030@phx.gbl \
--to=xili_gchen_5257@hotmail.com \
--cc=binutils@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).