Re: [PATCH] ld/ldmain.c (main): Use %F instead of %X for einfo().

Re: [PATCH] ld/ldmain.c (main): Use %F instead of %X for einfo().

[Chen Gang]

On 3/18/15 09:18, Alan Modra wrote:
> On Wed, Mar 18, 2015 at 07:54:46AM +0800, Chen Gang wrote:
>> When src or dst is NULL, the next fread or fwrite will cause segment
>> fault, so we need treat it as fatal case in einfo().
>>
>> 2015-03-18  Chen Gang <gang.chen.5i5j@gmail.com>
>>
>>         * ldmain.c (main): Use %F instead of %X for einfo().
> 
> Thanks, committed.
> 

Thank you too, I shall try to find/send another patches for binutils/gdb
within this month.

At present, I found an ld issue for cross building Linux c6x kernel, it
is about OTHER_BSS_SECTIONS: it does not consider about ld -r option,
which causes _STACK_START, _HEAP_START and _HEAP_MAX multi-definition:

I am analyzing about it. At present, for me, I plan to check "-r" in
"emulparams/elf32_tic6x_le.sh", it will skip OTHER_BSS_SECTIONS for "-r".
Welcome any ideas, suggestions and completions.


Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

Re: [PATCH] ld/ldmain.c (main): Use %F instead of %X for einfo().

[Alan Modra]

On Wed, Mar 18, 2015 at 07:54:46AM +0800, Chen Gang wrote:
> When src or dst is NULL, the next fread or fwrite will cause segment
> fault, so we need treat it as fatal case in einfo().
> 
> 2015-03-18  Chen Gang <gang.chen.5i5j@gmail.com>
> 
>         * ldmain.c (main): Use %F instead of %X for einfo().

Thanks, committed.

-- 
Alan Modra
Australia Development Lab, IBM

[PATCH] ld/ldmain.c (main): Use %F instead of %X for einfo().

[Chen Gang]

When src or dst is NULL, the next fread or fwrite will cause segment
fault, so we need treat it as fatal case in einfo().

2015-03-18  Chen Gang <gang.chen.5i5j@gmail.com>

        * ldmain.c (main): Use %F instead of %X for einfo().
---
 ld/ChangeLog | 4 ++++
 ld/ldmain.c  | 4 ++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/ld/ChangeLog b/ld/ChangeLog
index 0f8fbc4..72202c2 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,7 @@
+2015-03-18  Chen Gang <gang.chen.5i5j@gmail.com>
+
+	* ldmain.c (main): Use %F instead of %X for einfo().
+
 2015-03-02  Alan Modra  <amodra@gmail.com>
 
 	* ld.texinfo (Options <-z nocopyreloc>): Rewrite.
diff --git a/ld/ldmain.c b/ld/ldmain.c
index 4b41288..6674a80 100644
--- a/ld/ldmain.c
+++ b/ld/ldmain.c
@@ -484,10 +484,10 @@ main (int argc, char **argv)
 	      dst = fopen (dst_name, FOPEN_WB);
 
 	      if (!src)
-		einfo (_("%X%P: unable to open for source of copy `%s'\n"),
+		einfo (_("%P%F: unable to open for source of copy `%s'\n"),
 		       output_filename);
 	      if (!dst)
-		einfo (_("%X%P: unable to open for destination of copy `%s'\n"),
+		einfo (_("%P%F: unable to open for destination of copy `%s'\n"),
 		       dst_name);
 	      while ((l = fread (buf, 1, bsize, src)) > 0)
 		{
-- 
1.9.3