From: "Cui, Lili" <lili.cui@intel.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "hjl.tools@gmail.com" <hjl.tools@gmail.com>,
"binutils@sourceware.org" <binutils@sourceware.org>
Subject: RE: [PATCH 1/2] [PATCH 1/2] Enable Intel AVX512_FP16 instructions
Date: Tue, 13 Jul 2021 07:35:18 +0000 [thread overview]
Message-ID: <BY5PR11MB400812B008F18A24C449BB8B9E149@BY5PR11MB4008.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1911a3da-faab-0381-2bd1-0ccd9cc35301@suse.com>
> -----Original Message-----
> From: Jan Beulich <jbeulich@suse.com>
> Sent: Tuesday, July 13, 2021 3:26 PM
> To: Cui, Lili <lili.cui@intel.com>
> Cc: hjl.tools@gmail.com; binutils@sourceware.org
> Subject: Re: [PATCH 1/2] [PATCH 1/2] Enable Intel AVX512_FP16 instructions
>
> On 09.07.2021 13:52, Cui, Lili wrote:
> >> From: Jan Beulich <jbeulich@suse.com>
> >> Sent: Friday, July 2, 2021 9:42 PM
> >>
> >> On 01.07.2021 09:47, Cui,Lili wrote:
> >>> opcodes/i386-opc.tbl | 376 +++++++++++++++++++++
> >>
> >> May I suggest SpaceEVexMap{5,6} to become just EVexMap{5,6}?
> >> The table entries are hard enough to read, being partly far over 200
> columns.
> >> Any unambiguous shortening of names is a win imo.
> >>
> > I changed it to EVexMap{5,6} and put it behind with other VEX.m-mmmm
> interpretation. Do you think SpaceEVexMap{5,6} is better? because it
> maintains the same style as the others.
> >
> > #define Space0F OpcodeSpace=SPACE_0F
> > #define Space0F38 OpcodeSpace=SPACE_0F38 #define Space0F3A
> > OpcodeSpace=SPACE_0F3A #define SpaceXOP08
> OpcodeSpace=SPACE_XOP08
> > #define SpaceXOP09 OpcodeSpace=SPACE_XOP09 #define SpaceXOP0A
> > OpcodeSpace=SPACE_XOP0A
> >
> > #define EVexMap5 OpcodeSpace=SPACE_EVEXMAP5 #define EVexMap6
> > OpcodeSpace=SPACE_EVEXMAP6
>
> The shorter form you have seems better to me.
>
OK, thanks.
> >> You appear to be adding IgnoreSize to most (all?) SAE templates. May
> >> I ask why that is? I've taken quite a bit of time over the last
> >> couple of years to remove stray uses, and I'd really prefer if no
> >> unneeded new ones got introduced.
> >>
> > Sorry for that, I nearly deleted all IgnoreSize For FP16, except
> > vcvtph2psx, vcvtsi2sh and vcvtusi2sh. This patch was written a few
> > years ago,
>
> A few _years_ ago? Oh.
>
Yes, more than two years ago.
> Jan
>
> > the part of IgnoreSize was not updated with community.
next prev parent reply other threads:[~2021-07-13 7:35 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 7:47 [PATCH 0/2]Enable Intel AVX512_FP16 instructions and add tests for it Cui,Lili
2021-07-01 7:47 ` [PATCH 1/2] [PATCH 1/2] Enable Intel AVX512_FP16 instructions Cui,Lili
2021-07-02 13:42 ` Jan Beulich
2021-07-02 15:46 ` Jan Beulich
2021-07-06 12:42 ` Cui, Lili
2021-07-09 11:52 ` Cui, Lili
2021-07-13 7:25 ` Jan Beulich
2021-07-13 7:35 ` Cui, Lili [this message]
2021-07-02 15:08 ` Jan Beulich
2021-07-09 11:50 ` Cui, Lili
2021-07-05 6:30 ` Jan Beulich
2021-07-05 12:38 ` H.J. Lu
2021-07-06 12:48 ` Cui, Lili
2021-07-09 11:47 ` Cui, Lili
2021-07-09 12:16 ` Jan Beulich
2021-07-13 6:58 ` Cui, Lili
2021-07-13 7:54 ` Jan Beulich
2021-07-13 8:03 ` Cui, Lili
2021-07-13 16:25 ` Jan Beulich
[not found] ` <DM6PR11MB4009305D09B37299FC2F282C9EE39@DM6PR11MB4009.namprd11.prod.outlook.com>
2021-07-21 14:29 ` Jan Beulich
2021-07-22 7:05 ` Cui, Lili
2021-07-14 15:21 ` Jan Beulich
2021-07-20 7:08 ` FW: " Cui, Lili
2021-07-20 8:46 ` Jan Beulich
2021-07-20 11:13 ` Cui, Lili
2021-07-20 11:26 ` Cui, Lili
2021-07-20 13:02 ` Jan Beulich
2021-07-20 13:38 ` Cui, Lili
2021-07-20 14:15 ` Jan Beulich
2021-07-20 14:29 ` Cui, Lili
2021-07-21 10:32 ` Jan Beulich
2021-07-01 15:42 ` [PATCH 0/2]Enable Intel AVX512_FP16 instructions and add tests for it H.J. Lu
2021-07-01 17:46 ` H.J. Lu
2021-07-02 0:13 ` Cui, Lili
[not found] ` <20210701074736.9534-3-lili.cui@intel.com>
2021-07-02 15:44 ` [PATCH 2/2] [PATCH 2/2] Add tests for Intel AVX512_FP16 instructions Jan Beulich
[not found] ` <BY5PR11MB4008FDC77679D0F8FB9E88B39E149@BY5PR11MB4008.namprd11.prod.outlook.com>
2021-07-13 15:59 ` Jan Beulich
2021-07-14 18:01 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR11MB400812B008F18A24C449BB8B9E149@BY5PR11MB4008.namprd11.prod.outlook.com \
--to=lili.cui@intel.com \
--cc=binutils@sourceware.org \
--cc=hjl.tools@gmail.com \
--cc=jbeulich@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).