public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jedidiah Thompson <wej22007@outlook.com>
To: Nick Clifton <nickc@redhat.com>,
	"binutils@sourceware.org" <binutils@sourceware.org>
Subject: RE: 2.38 branch date approaching
Date: Thu, 13 Jan 2022 15:42:27 +0000	[thread overview]
Message-ID: <BYAPR02MB4901F53F838FA86BD84B7C1893539@BYAPR02MB4901.namprd02.prod.outlook.com> (raw)
In-Reply-To: <db446ed1-9fba-4563-8487-0c774dfb00fe@redhat.com>

I’m not going to be at my computer for another week or so, but as soon as I am, I will send the updated patch.

From: Nick Clifton<mailto:nickc@redhat.com>
Sent: Thursday, January 13, 2022 8:44 AM
To: Jedidiah Thompson<mailto:wej22007@outlook.com>; binutils@sourceware.org<mailto:binutils@sourceware.org>
Subject: Re: 2.38 branch date approaching

Hi Jeddiah,

> Not to spam, but would you please review my aarch64-pe patches? I don't want it added to 2.38, as it doesn't have some important features needed (like relocations and DLL
> support), but it will make it easier for me to work on those features when it gets reviewed.

Sure - but ... please could you send me a new version of the patch with a couple of changes ?

Specifically:

   * Please could you send the patch as an attachment, not inline.
     (For some reason my email reader keeps on wrapping long lines, which corrupts inline patches)

   * Please could you omit the changes to the gdb sources.
     (You will need separate approval from the gdb folks for that part).

   * Please could you omit the changes to the auto-generated files
     (eg configure, Makefile.in, etc).  I will regenerate the files
     myself.

   * If possible, please could you omit any formatting tweaks.
     eg replacing "# define" with "#define" and so on.

Cheers
   Nick


  reply	other threads:[~2022-01-13 15:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-04 15:58 Nick Clifton
2022-01-10 16:20 ` H.J. Lu
2022-01-11  5:08   ` Alan Modra
2022-01-12 12:53 ` Jedidiah Thompson
2022-01-12 12:58 ` Jedidiah Thompson
2022-01-13 13:44   ` Nick Clifton
2022-01-13 15:42     ` Jedidiah Thompson [this message]
2022-01-12 14:35 ` Jedidiah Thompson
2022-01-12 14:48   ` Jedidiah Thompson
2022-01-12 18:02 ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR02MB4901F53F838FA86BD84B7C1893539@BYAPR02MB4901.namprd02.prod.outlook.com \
    --to=wej22007@outlook.com \
    --cc=binutils@sourceware.org \
    --cc=nickc@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).