From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id 8F3183858424 for ; Tue, 4 Jan 2022 22:15:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8F3183858424 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sifive.com Received: by mail-ot1-x335.google.com with SMTP id n17-20020a9d64d1000000b00579cf677301so8087769otl.8 for ; Tue, 04 Jan 2022 14:15:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OpaJBeLszKOHZkHnQe881swXnFNZzTEvtq9cQfRYeEQ=; b=IAz3u5zROn9Wz5dgqs7ZtUT/LVsVZ82ez3Vs7ZlLs6WqAif+R8cdY6sWPwG58zG6GM hH+MypIzcAsj2XOTxJaq/NVVWaYisRR67kjpJlYyYY5ZCppqave/cKsR+dFI0kIoNQLC QUCa1D+MVvWpWTucyE6kbZ/IoT9nxCI6Hd65K4dZEYtgNFSLyUEGl4L6UgWeR2UxxN25 MUadSS9SJoesKeKrNziwqpj3zceTKsMTXPai1LQydfS8A7KMYOd048iQ629pd4a92m5d SCkZgaCP9sKiw+5hSS1+ZCcsBZtgD1x7QWFTr1eVyFWSBdMHKQr5ysImqefhJKvEboOc DsIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OpaJBeLszKOHZkHnQe881swXnFNZzTEvtq9cQfRYeEQ=; b=x7lA2etiwXLOFBu59FBdoedAtLQRsMo6+JwondofEW+sxVjcGy+ckA27T7FXb5hoZa dWt5R74oTrYEAEHFwEC/pcoKJY3W0dliJUAeOX9Ht3dho0D8w9aqoD16ogHwfJsvOS/d c+CQ82hJNz/adFHTmDkuThodFuIOLexTZ992nrK9kJ8vixY/6wYx6oLjjPnSLhTjfLX4 uA3McsTgVANPg12QQGPzwqgsRKLl2TPMa/3DutoufJ/TZ7bRYDVPGB7pgMsNud4P739e T7u3Dce/42dzg/BJKx6tdvDhVuywZVDcYCNRcN6IGVUKFtrcyrjO6SCGZMQa3dNaRmjD VFEw== X-Gm-Message-State: AOAM531nqd3n586/jqaMjkWrpWpM+bZBjj37e3LixsdV+J89f1JzQsqe Gdr3A9jzaO58F5N/fnJ4TFtOsJMDIY5XcS5p X-Google-Smtp-Source: ABdhPJz4RPkhVY1LgQX8HfDbiBPT7P91ZGuM7nwD4d2UpcHvdje7WhezAgYNm8xFLMaM7joaXVVk1g== X-Received: by 2002:a05:6830:440f:: with SMTP id q15mr35940513otv.373.1641334516490; Tue, 04 Jan 2022 14:15:16 -0800 (PST) Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com. [209.85.210.54]) by smtp.gmail.com with ESMTPSA id n21sm7541988oov.33.2022.01.04.14.15.15 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jan 2022 14:15:16 -0800 (PST) Received: by mail-ot1-f54.google.com with SMTP id a23-20020a9d4717000000b0056c15d6d0caso48807944otf.12 for ; Tue, 04 Jan 2022 14:15:15 -0800 (PST) X-Received: by 2002:a05:6830:2042:: with SMTP id f2mr35776413otp.89.1641334515779; Tue, 04 Jan 2022 14:15:15 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrew Waterman Date: Tue, 4 Jan 2022 14:15:04 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/5] RISC-V: Cache management instructions To: Jan Beulich Cc: Tsukasa OI , Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jan 2022 22:15:18 -0000 On Tue, Jan 4, 2022 at 12:01 AM Jan Beulich via Binutils wrote: > > On 16.12.2021 12:04, Tsukasa OI via Binutils wrote: > > --- a/opcodes/riscv-opc.c > > +++ b/opcodes/riscv-opc.c > > @@ -849,6 +849,12 @@ const struct riscv_opcode riscv_opcodes[] = > > {"sfence.vma", 0, INSN_CLASS_I, "s,t", MATCH_SFENCE_VMA, MASK_SFENCE_VMA, match_opcode, 0 }, > > {"wfi", 0, INSN_CLASS_I, "", MATCH_WFI, MASK_WFI, match_opcode, 0 }, > > > > +/* Zicbom and Zicboz instructions. */ > > +{"cbo.clean", 0, INSN_CLASS_ZICBOM, "s", MATCH_CBO_CLEAN, MASK_CBO_CLEAN, match_opcode, 0 }, > > +{"cbo.flush", 0, INSN_CLASS_ZICBOM, "s", MATCH_CBO_FLUSH, MASK_CBO_FLUSH, match_opcode, 0 }, > > +{"cbo.inval", 0, INSN_CLASS_ZICBOM, "s", MATCH_CBO_INVAL, MASK_CBO_INVAL, match_opcode, 0 }, > > +{"cbo.zero", 0, INSN_CLASS_ZICBOZ, "s", MATCH_CBO_ZERO, MASK_CBO_ZERO, match_opcode, 0 }, > > Perhaps more a spec question / remark than one on the implementation: > Wouldn't it be more natural for CBO.* to have memory-like operands, > e.g. "cbo.zero (x1)" instead of "cbo.zero x1"? Without taking a position, I'll mention that there is precedent for the latter, too: in particular, the rs1 argument to SFENCE.VMA is an address operand that doesn't use parens. > > Jan >