From: Jiong WANG <wong.kwongyuan@gmail.com>
To: Ian Lance Taylor <iant@google.com>
Cc: davem@davemloft.net, binutils@sourceware.org
Subject: Re: [GOLD] question about gold handling SPARC style .rela.plt, .rela.plt overlapping
Date: Tue, 07 Aug 2012 14:19:00 -0000 [thread overview]
Message-ID: <CA++uP6NzdHZwUTcx_r4FGxA4CjbCP98dYWOGhhmBS3yQtY6h8w@mail.gmail.com> (raw)
In-Reply-To: <CAKOQZ8zAbvtxaNTJ8AmQO+Ux2BF+V1YKgfw5z3KPd6KAAmbCCw@mail.gmail.com>
Thanks!
---
Regards,
WANG.Jiong
2012/8/7 Ian Lance Taylor <iant@google.com>:
> On Tue, Aug 7, 2012 at 1:24 AM, WANG.Jiong <wong.kwongyuan@gmail.com> wrote:
>>
>> currently, I am porting gold linker for a private target which allow
>> PLTREL overlapping
>>
>> ...
>>
>> So, should we always generate DT_RELA, DT_RELASZ, DT_RELAENT, and make
>> DT_RELA, DT_RELASZ exactly the same value as DT_JMPREL, DT_PLTRELSZ ?
>>
>> that is, for the following condition check in
>> Layout::add_target_dynamic_tags
>>
>> 4344 if (dyn_rel != NULL && dyn_rel->output_section() != NULL)
>> 4345 {
>> 4346 odyn->add_section_address(use_rel ? elfcpp::DT_REL :
>> elfcpp::DT_RELA,
>> 4347 dyn_rel->output_section());
>> 4348 if (plt_rel != NULL
>> 4349 && plt_rel->output_section() != NULL
>> 4350 && dynrel_includes_plt)
>>
>> should we check dynrel_includes_plt even when dyn_rel == NULL ?
>
> Yes, I agree. If dynrel_includes_plt && dyn_rel == NULL && plt_rel !=
> NULL, we should generate the DT_REL tags.
>
> I committed the attached patch.
>
> Ian
>
> 2012-08-07 Ian Lance Taylor <iant@google.com>
>
> * layout.cc (Layout::add_target_dynamic_tags): If
> dynrel_includes_plt but no dyn_rel, emit dynamic reloc tags for
> plt_rel.
prev parent reply other threads:[~2012-08-07 14:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 10:25 WANG.Jiong
2012-08-07 13:34 ` Ian Lance Taylor
2012-08-07 14:19 ` Jiong WANG [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA++uP6NzdHZwUTcx_r4FGxA4CjbCP98dYWOGhhmBS3yQtY6h8w@mail.gmail.com \
--to=wong.kwongyuan@gmail.com \
--cc=binutils@sourceware.org \
--cc=davem@davemloft.net \
--cc=iant@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).