From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112466 invoked by alias); 1 May 2016 16:44:20 -0000 Mailing-List: contact binutils-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sourceware.org Received: (qmail 112446 invoked by uid 89); 1 May 2016 16:44:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=canadian, Canadian, H*F:U*pinskia, asc X-HELO: mail-lf0-f67.google.com Received: from mail-lf0-f67.google.com (HELO mail-lf0-f67.google.com) (209.85.215.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 01 May 2016 16:44:09 +0000 Received: by mail-lf0-f67.google.com with SMTP id y84so22794568lfc.3 for ; Sun, 01 May 2016 09:44:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=Sk/zkY9/mIQ3rlVoiQlCQBie0LM1IdaN3hQ6TEu98og=; b=hA401K/eC9coZZ3v5C6HFmXOTJg7NehrLs9rQn+wYFlvcsJEICoW6MPPB7XEEjnSib QYrkVQmvZKSzlFc/cGVpUX9rEFHbHH84ewQLKthR38wjwhWDf9Q0DeYXejb0D1qG9Yu+ 8mReaVqeeSotho0rQoV35tv5ICG+qRVyMsqofbdAyyHBuzzr7NYRPJRu+t893K6X84CS dnycbxC2rKhCbWdCrM/gbIYU1Kee+XhOO/q/8QgDKUjVJ//60QIuYXUw4IZWNiCUFRwB ZtwpIa1WKbnZK4CZXsFh7MNaxch31d6NIYeotARU5VLkVNLJcQ/oDzVyZBLoZQckm+85 qyAA== X-Gm-Message-State: AOPr4FXkHEYPwoXn74zNPT8FbWfCAWR2xUxil7K1iuHc8ZGFKgshU1p3ot2F1oCfL24Tdt6oDLpd/5EqSdLyyA== MIME-Version: 1.0 X-Received: by 10.25.210.144 with SMTP id j138mr11113725lfg.77.1462121046287; Sun, 01 May 2016 09:44:06 -0700 (PDT) Received: by 10.25.133.84 with HTTP; Sun, 1 May 2016 09:44:06 -0700 (PDT) In-Reply-To: <1459300381-19313-1-git-send-email-tbsaunde+binutils@tbsaunde.org> References: <1459300381-19313-1-git-send-email-tbsaunde+binutils@tbsaunde.org> Date: Sun, 01 May 2016 16:44:00 -0000 Message-ID: Subject: Re: [PATCH 0/7] enable -Wwrite-strings for gas From: Andrew Pinski To: tbsaunde+binutils@tbsaunde.org Cc: binutils Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg00000.txt.bz2 On Tue, Mar 29, 2016 at 6:12 PM, wrote: > From: Trevor Saunders > > Hi, > > At this point I think we've fixed basically all the -Wwrite-strings issues in > gas that can be fixed reasonably without just adding casts. So this series > adds a handful of casts in several patches that try to explain why those casts > are necessary, and then enables the warning for gas. > > I built one target per tc-*.c and regtested x86_64-linux-gnu, ok? This patch set broke cross Canadian cross as the build compiler does not have to be the same as the target compiler version on what options are supported. I use gcc 4.4.5 as my build compiler but the target compiler is GCC 7. Thanks, Andrew > > Trev > > > Trevor Saunders (7): > cast literal to char * when assigning to input_line_ptr > work around get_symbol_name () in sparc and ia64 > cast to char * when assigning to optarg > cast the arg to md_assemble () to char * > tc-i960.c: add some casts when assigning literals to args[i] > make xtensa_section_rename () take const char * > enable -Wwrite-strings for gas > > bfd/configure | 20 ++++++++++++++++++-- > bfd/warning.m4 | 4 ++++ > binutils/configure | 20 ++++++++++++++++++-- > gas/Makefile.am | 2 +- > gas/Makefile.in | 2 +- > gas/as.c | 2 +- > gas/config/tc-i960.c | 26 +++++++++++++------------- > gas/config/tc-ia64.c | 6 ++++-- > gas/config/tc-m32c.c | 8 ++++---- > gas/config/tc-m32r.c | 2 +- > gas/config/tc-msp430.c | 2 +- > gas/config/tc-nds32.c | 10 +++++----- > gas/config/tc-sparc.c | 2 +- > gas/config/tc-xtensa.c | 6 +++--- > gas/config/tc-xtensa.h | 2 +- > gas/config/tc-z80.c | 2 +- > gas/configure | 20 ++++++++++++++++++-- > gas/stabs.c | 2 +- > gold/configure | 16 ++++++++++++++++ > gprof/configure | 20 ++++++++++++++++++-- > ld/configure | 20 ++++++++++++++++++-- > opcodes/configure | 20 ++++++++++++++++++-- > 22 files changed, 166 insertions(+), 48 deletions(-) > > -- > 2.1.4 >