From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by sourceware.org (Postfix) with ESMTPS id 099A63858436 for ; Fri, 1 Sep 2023 06:37:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 099A63858436 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-500a398cda5so2974575e87.0 for ; Thu, 31 Aug 2023 23:37:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693550242; x=1694155042; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5BVMMdqykX0/w8YsMsdgUB5c44s6SSMWnMYe+yRe2yQ=; b=Iofdxopv3V7ctLeMq2RqVCJRTZhgYHlGPvOPvWyfLBSCJBwU/Q+7oqxhQH+ASHBGi7 AZIfPFqlSmXba3t2x7kwPtc4GCRHwOo58T6Y0TMMeF0/y1/9DKa2KWfh5+dXFBwRiP86 dSIVIpjgHGfNx8xOAGcsqMIuhysoZUMeTv3GLT2gQCY7ZoUkf4+dQJU5rhMH6WsG6KZS Rx8SnOb2qbrxwnbTRn5UMoqelLQ/4qBLCucWhd2d+hsJXANDJJpFnvk3cIIb86N4QMkj BkLQLz+vxEl1BvQ3+24G8Zw+gjJehkyDjDpp0IzTcdQvlZa3zKbdExe0EKDjbbfUeADY z5qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693550242; x=1694155042; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5BVMMdqykX0/w8YsMsdgUB5c44s6SSMWnMYe+yRe2yQ=; b=WlCZG2JwGQ63Vt/HXO/K/slEEyLjxQcOxWOSORIr3gn6ew2gSflmVQ3/RNygOrAx7n QW7E/69NjGEY5voCChXiLcAkEPKD1930ncu/ucM+W84Wbxo7x9D/jeoneW6rzML/tug4 0bJ2mri73T/doyLSKStGpM+HQp7n/CgkI7TLrvzIJ0ViA7q04JAOK1wVsNIHDjV9LIVF Ey53I6E6Zo++IxNaM8slEJ7r+PIGJtfE9IePdfpupjcZhVbQx0cYLLkFYLuWGv9XT+fv L/xaokhVLAcGvXeAZhEbcXXhqW+DsKPASlfZK77Wm+s1ozkxTRNTtqglYibGinKAWmLP mXFg== X-Gm-Message-State: AOJu0Yw7MFpyG0W8ojW4hvn5P5OU1owiYhiaGmIWe+RUcnYmYSKgfAvO sKvG7D5zhN9a/1Rx1+CAwQi63gh3gEOBoafXC8Db1+QYa99gqA== X-Google-Smtp-Source: AGHT+IHDPIz4Bm+jPLs/Cmx679535y1XoCpfQn68iS1+FsG6YKZRgOanakbhY/a0CbbBD3FJTTag9u/JO8MB4kMhYCU= X-Received: by 2002:a05:6512:39c6:b0:500:9de4:5968 with SMTP id k6-20020a05651239c600b005009de45968mr1093270lfu.59.1693550242052; Thu, 31 Aug 2023 23:37:22 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Kiva Oyama Date: Fri, 1 Sep 2023 14:37:05 +0800 Message-ID: Subject: Re: [RISCV] [GNU AS] Possible `vmsge{u}.vx` instruction lowering bug? To: Jan Beulich Cc: Nelson Chu , binutils@sourceware.org Content-Type: multipart/alternative; boundary="000000000000963fbf0604466484" X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000963fbf0604466484 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > Is the following expected? Yes. > Seems "vd is any" also has the same issue. I rechecked the spec, for every masked vmsge{u}.vx, the lowered instruction is only masked when `vd !=3D v0`. So your patch does fix these two problems. Thank you for clarifying. Best Regards, Kiva Oyama On Wed, Aug 30, 2023 at 1:51=E2=80=AFPM Jan Beulich wro= te: > On 30.08.2023 04:51, Nelson Chu wrote: > > Hi Jan, > > Thanks for pointing that out. > > > > Hi Kiva, > > Maybe you can send a better patch for this issue if you are interested, > > including what Jan suggested. Thanks :-) > > Hmm, both of your replies above make me suspect a misunderstanding: I > think your patch does exactly what is needed. > > Jan > > > On Tue, Aug 29, 2023 at 4:52=E2=80=AFPM Jan Beulich = wrote: > > > >> On 29.08.2023 09:59, Nelson Chu wrote: > >>> Is the following expected? > >> > >> I think so, but Kiva - please confirm. > >> > >>> Seems "vd is any" also has the same issue. > >> > >> Right, that's what ... > >> > >>>> I think this wants fixing alike in binutils: From looking at > >>>> vector_macro(), > >>>> it appears that emitting the masked form is merely an accident > resulting > >>>> from the inverted encoding of "masking". In particular, if masking w= as > >>>> indeed meant, I expect code there would be > >>>> > >>>> if (vd =3D=3D vm) > >>>> { > >>>> macro_build (NULL, "vmslt.vx", "Vd,Vt,sVm", > vtemp, > >>>> vs2, vs1, vm); > >>>> macro_build (NULL, "vmandnot.mm", "Vd,Vt,Vs", > vd, > >>>> vm, vtemp); > >>>> } > >>>> else > >>>> ... > >>>> > >>>> much like it is a few lines down from there. (Apparently the "else" > path > >>>> omitted above is similarly affected.) > >> > >> ... I was referring to with the parenthesized sentence. > >> > >> Jan > >> > > > > --000000000000963fbf0604466484--