From: Amol <suratiamol@gmail.com>
To: Tamar Christina <tamar.christina@arm.com>
Cc: binutils@sourceware.org, nd@arm.com, Richard.Earnshaw@arm.com,
nickc@redhat.com, ramana.radhakrishnan@arm.com
Subject: Re: [PATCH 2/2][Binutils][Arm]: Fix LSB of GOT for Thumb2 only PLT
Date: Tue, 31 Mar 2020 16:13:32 +0530 [thread overview]
Message-ID: <CA+nuEB_jrcGc0Sq-9TPUEp=Vo8nX=P+r3VQNS=BosPPp_gZmcQ@mail.gmail.com> (raw)
In-Reply-To: <20200330081219.GA16551@arm.com>
Hi Tamar,
On 30/03/2020, Tamar Christina <tamar.christina@arm.com> wrote:
> However I have not been able to do an execution test since I do not have a way
> to actually test this. I am hoping the user who reported it can test it but the
> patch is sound based on principles.
>
The issue was originally reported on Arm's community by a user rgujju [1];
I was just the debugger.
> Amol would you be able to confirm the patch works on your setup?
>
The .got entries for both the binaries
(a) on the ld/16017, and
(b) on the setup at [1],
now have the LSB set, where previously they did not.
I tested the setup at [1], but on qemu alone; the control now
successfully jumps to the plt0 stub, where previously it would just crash
attempting that jump.
If it isn't too late, you may want to flag rgujju as the reporter of the bug.
Apologies for any inconvenience caused.
[1] https://community.arm.com/developer/ip-products/processors/f/cortex-m-forum/45919/gcc-does-not-generate-correct-code-while-building-pic
Thanks,
amol
next prev parent reply other threads:[~2020-03-31 10:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-30 8:12 Tamar Christina
2020-03-30 9:28 ` Nick Clifton
2020-03-31 10:43 ` Amol [this message]
2020-04-01 9:28 ` Tamar Christina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+nuEB_jrcGc0Sq-9TPUEp=Vo8nX=P+r3VQNS=BosPPp_gZmcQ@mail.gmail.com' \
--to=suratiamol@gmail.com \
--cc=Richard.Earnshaw@arm.com \
--cc=binutils@sourceware.org \
--cc=nd@arm.com \
--cc=nickc@redhat.com \
--cc=ramana.radhakrishnan@arm.com \
--cc=tamar.christina@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).