public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Kito Cheng <kito.cheng@gmail.com>
To: Jim Wilson <jimw@sifive.com>
Cc: Nelson Chu <nelson.chu@sifive.com>,
	Binutils <binutils@sourceware.org>,
		Kito Cheng <kito.cheng@sifive.com>
Subject: Re: [PATCH] RISC-V: Convert the ADD/ADDI to the compressed MV/LI if RS1 is zero.
Date: Thu, 20 Feb 2020 02:48:00 -0000	[thread overview]
Message-ID: <CA+yXCZADyz4=DyO_oZhnehBCBgVxCyn77949y=ONzAJiw2iAPw@mail.gmail.com> (raw)
In-Reply-To: <CAFyWVaYQ6H9fp_weDRRASeJWLnEMAUz1KZYTKk7s=kM1Qa5J6A@mail.gmail.com>

Hi Jim:

FYI, I used to using this command to update author of last commit
without change global git setting:

git commit --amend --author="Author Name <email@address.com>"

[1] https://stackoverflow.com/questions/3042437/how-to-change-the-commit-author-for-one-specific-commit


On Thu, Feb 20, 2020 at 7:11 AM Jim Wilson <jimw@sifive.com> wrote:
>
> On Tue, Feb 18, 2020 at 5:42 PM Nelson Chu <nelson.chu@sifive.com> wrote:
> >         gas/
> >         * testsuite/gas/riscv/c-add-addi.d: New testcase.
> >         * testsuite/gas/riscv/c-add-addi.s: Likewise.
> >         opcodes/
> >         * riscv-opc.c (riscv_opcodes): Convert add/addi to the compressed
> >         c.mv/c.li if rs1 is zero.
>
> Looks good to me.  Committed.
>
> Though apparently I committed it wrong as I didn't realize that git
> has a way to assign authors to patches separate from the person that
> commits the patch.  I just included a changelog line to attribute the
> patch to you.  I shall have to try setting the author for the commit
> next time.
>
> Jim

  reply	other threads:[~2020-02-20  2:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-19  1:42 Nelson Chu
2020-02-19 23:11 ` Jim Wilson
2020-02-20  2:48   ` Kito Cheng [this message]
2020-02-20  6:33   ` Nelson Chu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+yXCZADyz4=DyO_oZhnehBCBgVxCyn77949y=ONzAJiw2iAPw@mail.gmail.com' \
    --to=kito.cheng@gmail.com \
    --cc=binutils@sourceware.org \
    --cc=jimw@sifive.com \
    --cc=kito.cheng@sifive.com \
    --cc=nelson.chu@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).