From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) by sourceware.org (Postfix) with ESMTPS id 9C1A23858C53 for ; Fri, 1 Apr 2022 04:04:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9C1A23858C53 Received: by mail-ej1-x632.google.com with SMTP id p15so3257630ejc.7 for ; Thu, 31 Mar 2022 21:04:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0nMTX0bhfGU+mgXiebmNX2euAf48jv5WnqTc4EBiUoA=; b=u9dEQbDcwyh14M9bLdB8iKGaY58zANcDeABzqhhJDgptiwTmhRQ9FXEzMkpRW3Clp/ oQv27gN6Y6imqGcrkPf7OT7A3W6v8B/2jvOKO0dHd0KKAAeRRw64KcRGBmIelt0tLQ/+ BGAefFiEmyN+N0aRnHKm+i4tT58jYa+2/jsYQTusGtg8ni+85c94kNzVaaQbRlEz1IUi DKjY6n/+wNMfG81D6O/yKpOS33oGzxsPGA/YjC01RMXXzZPAUVWUwthfQ561rAQJRJti +sgyQhDztpmct/YfOTQ5OvJ0oG4Y2wAvbp7i0jWj9FZZQB7PXsiDR0kEyht/HB0GWQO+ 5zfg== X-Gm-Message-State: AOAM533Mg8KuTvVOd2CpB35IEG9deO35uo/1berC0oT6EYARruLDH58B 8qQCn/v3XQ5SP6LBtw/omEsXKOTS8h9UoiV3WoI5ib2Xoo//4Q== X-Google-Smtp-Source: ABdhPJz/+G2FpwTmzZYtFrBjrN04Ylg962x6t/gPssEm4VD6QXwrBLDJuu7GrENe/kodkdNz4TqUjhNZUudM36dWGtI= X-Received: by 2002:a17:907:7252:b0:6df:75cc:615e with SMTP id ds18-20020a170907725200b006df75cc615emr7692769ejc.683.1648785864160; Thu, 31 Mar 2022 21:04:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Kito Cheng Date: Fri, 1 Apr 2022 12:04:12 +0800 Message-ID: Subject: Re: [PATCH 0/5] RISC-V: Add Ratified Cache Management Operation ISA Extensions (with paren) To: Palmer Dabbelt Cc: Binutils Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2022 04:04:27 -0000 Nelson has merge this patch series: https://github.com/bminor/binutils-gdb/commit/41d6ac5da655a2e78109848f2db47e53552fd61a https://github.com/bminor/binutils-gdb/commit/3b374308d3006407b9571e573e4ccce4e904a4c4 On Fri, Apr 1, 2022 at 11:33 AM Palmer Dabbelt wrote: > > On Tue, 08 Feb 2022 18:29:27 PST (-0800), binutils@sourceware.org wrote: > > This patchset is a modified version of: > > > > > > GitHub: > > (original; 2021-12-16, rebased) > > (new: 2022-02-09) > > > > > > There seems a discussion to change operand of cbo.* instructions on: > > . > > Looks like that still hasn't been resolved? I don't really care either > way, just that whatever we do is in agreement with the spec as it'd be > silly to differ from LLVM here. > > > I have a little preference for old one but it's not bad to have both > > options (as complete patchsets). > > > > Note that however, the original patchset is *NOT OUTDATED* yet. > > It implements Zicbom/Zicboz instruction like: > > > > cbo.zero a0 > > > > This new patchset implements Zicbom/Zicboz instructions like: > > > > cbo.zero (a0) > > cbo.zero 0(a0) # only zero is allowed > > There's some precedent for accepting both flavors of instructions like > that, so if there's already an assembler out there that does things one > way and the spec does the other I guess we could accept both? I'd still > prefer to just have everyone agree on the specification side, though. > > > Actually, my first attempt to implement cbo.* instructions used the same > > format as *new* patchset (I modified before submitting the first > > patchset for compliance to the specification document). > > > > This version requires extra checking (0(a0) actually allows > > EXPRESSION_RESULTS_IN_ZERO(a0)) so I added a few extra tests. > > It will also reject operand format in older patchset. > > > > Old patchset and new patchset are mutually exclusive and should follow > > the conclusion of the discussion above. > > > > Thanks, > > Tsukasa > > > > > > > > > > Tsukasa OI (5): > > RISC-V: Add mininal support for Zicbo[mpz] > > RISC-V: Cache management instructions > > RISC-V: Cache management instruction testcases > > RISC-V: Prefetch hint instructions and operand set > > RISC-V: Prefetch hint instruction testcases > > > > bfd/elfxx-riscv.c | 9 +++++++++ > > gas/config/tc-riscv.c | 18 ++++++++++++++++++ > > gas/testsuite/gas/riscv/zicbom-fail.d | 3 +++ > > gas/testsuite/gas/riscv/zicbom-fail.l | 7 +++++++ > > gas/testsuite/gas/riscv/zicbom-fail.s | 7 +++++++ > > gas/testsuite/gas/riscv/zicbom.d | 15 +++++++++++++++ > > gas/testsuite/gas/riscv/zicbom.s | 7 +++++++ > > gas/testsuite/gas/riscv/zicbop-fail.d | 3 +++ > > gas/testsuite/gas/riscv/zicbop-fail.l | 4 ++++ > > gas/testsuite/gas/riscv/zicbop-fail.s | 4 ++++ > > gas/testsuite/gas/riscv/zicbop.d | 12 ++++++++++++ > > gas/testsuite/gas/riscv/zicbop.s | 4 ++++ > > gas/testsuite/gas/riscv/zicboz-fail.d | 3 +++ > > gas/testsuite/gas/riscv/zicboz-fail.l | 3 +++ > > gas/testsuite/gas/riscv/zicboz-fail.s | 3 +++ > > gas/testsuite/gas/riscv/zicboz.d | 12 ++++++++++++ > > gas/testsuite/gas/riscv/zicboz.s | 4 ++++ > > include/opcode/riscv-opc.h | 16 ++++++++++++++++ > > include/opcode/riscv.h | 3 +++ > > opcodes/riscv-dis.c | 4 ++++ > > opcodes/riscv-opc.c | 9 +++++++++ > > 21 files changed, 150 insertions(+) > > create mode 100644 gas/testsuite/gas/riscv/zicbom-fail.d > > create mode 100644 gas/testsuite/gas/riscv/zicbom-fail.l > > create mode 100644 gas/testsuite/gas/riscv/zicbom-fail.s > > create mode 100644 gas/testsuite/gas/riscv/zicbom.d > > create mode 100644 gas/testsuite/gas/riscv/zicbom.s > > create mode 100644 gas/testsuite/gas/riscv/zicbop-fail.d > > create mode 100644 gas/testsuite/gas/riscv/zicbop-fail.l > > create mode 100644 gas/testsuite/gas/riscv/zicbop-fail.s > > create mode 100644 gas/testsuite/gas/riscv/zicbop.d > > create mode 100644 gas/testsuite/gas/riscv/zicbop.s > > create mode 100644 gas/testsuite/gas/riscv/zicboz-fail.d > > create mode 100644 gas/testsuite/gas/riscv/zicboz-fail.l > > create mode 100644 gas/testsuite/gas/riscv/zicboz-fail.s > > create mode 100644 gas/testsuite/gas/riscv/zicboz.d > > create mode 100644 gas/testsuite/gas/riscv/zicboz.s > > > > > > base-commit: a37603c43f8da7983ed53b567ea30ce66066daa2