From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <npickito@gmail.com>
Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com
 [IPv6:2a00:1450:4864:20::52d])
 by sourceware.org (Postfix) with ESMTPS id 4AFA43857012
 for <binutils@sourceware.org>; Mon,  8 Aug 2022 15:47:31 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4AFA43857012
Received: by mail-ed1-x52d.google.com with SMTP id z2so11904247edc.1
 for <binutils@sourceware.org>; Mon, 08 Aug 2022 08:47:31 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=cc:to:subject:message-id:date:from:in-reply-to:references
 :mime-version:x-gm-message-state:from:to:cc;
 bh=7FHq/cqUHjJyPqQMSefR2iO0zarbJrS/+1uejGyZNoI=;
 b=QRDXSipIRGuM7rZHebo1pYMJ1BAWUDPeBf3ZMjXSwxyHpB9I1YyeyUbJVkjVZD9TtE
 kiPDKishLi50tkEaQeVnX1K4VDRTABbErIGzIG5StKzfh2OExruqW5dgbz0CSRR1I2Zv
 EQB96DKa05fIloiTf8rHlVnNEvzgjsnWCD7gQC3Pearjje/9UkfcsQFdXnQpP2anv2k7
 XaMsgws8abW6eAGKSdGLGiBX2v/8ieApCB7OkJzTBUoZiykAcC3wVu/Y5BtrSq2FgGoJ
 jEaj7JiyJbZtIgCHz9gm8hSiDhTRQEZ6vpIZRC6LM0UF1t5ChBExPtJ0Cd+EBpf3wXis
 ZzGg==
X-Gm-Message-State: ACgBeo3jPkUEPEPKdxTg+1NEzQH/n5Rt73D+3e5P1J19UEPJujoAKP3+
 5UzP6Kc3EE/wmA8AsOvJOv4bbfGXatiVTJ5dNH4asVxjMRY=
X-Google-Smtp-Source: AA6agR76DeBws/G53iS2n90qaAeW4gr3fU3EvBLUeiw9wl2PNIhiXTJh4NN+xuzOT5V2IXvcixB0V17WfWnhWbsiRvM=
X-Received: by 2002:a05:6402:34ce:b0:43d:c2ce:6e8a with SMTP id
 w14-20020a05640234ce00b0043dc2ce6e8amr17928755edc.160.1659973650011; Mon, 08
 Aug 2022 08:47:30 -0700 (PDT)
MIME-Version: 1.0
References: <20220808065523.18152-1-maskray@google.com>
 <mvmtu6nkvss.fsf@suse.de>
In-Reply-To: <mvmtu6nkvss.fsf@suse.de>
From: Kito Cheng <kito.cheng@gmail.com>
Date: Mon, 8 Aug 2022 23:47:18 +0800
Message-ID: <CA+yXCZBRTFLrpiqc0A0gJeCT+Pq5nFQaa92G6__LYv6r1a80tA@mail.gmail.com>
Subject: Re: [PATCH] RISC-V: Remove R_RISCV_GNU_VTINHERIT/R_RISCV_GNU_VTENTRY
To: Andreas Schwab <schwab@suse.de>
Cc: Fangrui Song via Binutils <binutils@sourceware.org>,
 Kito Cheng <kito.cheng@sifive.com>, Fangrui Song <maskray@google.com>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: binutils@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Binutils mailing list <binutils.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>,
 <mailto:binutils-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>,
 <mailto:binutils-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Aug 2022 15:47:33 -0000

Hi Andreas:

> FWIW, they are still generically handled by the .vtable_inherit and
> .vtable_entry pseudo-ops, but support for -fvtable-gc has been removed
> from gcc in 2003.  The RISC-V assembler never picked them up.

Thanks for the historical data! RISC-V GNU toolchain is upstreamed
after that time, so sounds like we could remove that safely for
RISC-V.

> $ riscv64-suse-linux-as vtable.s
> vtable.s: Assembler messages:
> vtable.s:1: Error: cannot represent BFD_RELOC_VTABLE_ENTRY relocation in object file
> vtable.s:2: Error: cannot represent BFD_RELOC_VTABLE_INHERIT relocation in object file

Maybe we can improve the error message into something like:
.vtable_inherit / .vtable_entry is unsupported for RISC-V.