From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <npickito@gmail.com>
Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com
 [IPv6:2a00:1450:4864:20::531])
 by sourceware.org (Postfix) with ESMTPS id 773DC3858D37
 for <binutils@sourceware.org>; Mon, 21 Feb 2022 15:12:55 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 773DC3858D37
Received: by mail-ed1-x531.google.com with SMTP id x5so29939110edd.11
 for <binutils@sourceware.org>; Mon, 21 Feb 2022 07:12:55 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=qJ3DAB1M2rmFu3vr/8xHPtZ17hAv3SauolZ3jH4NVqc=;
 b=fsAtM+AUrnmo4QjAGscpMzSHTXHHGbf3hHaSWGJt5oVPFgc0byRDdvGYkn1hIviMMD
 ydToDfaanG1OASnQNQYo5O6jErly/0+ThGSHjb9o7jywjx3uuNxCvqV7ntwOFACHbpDB
 BqlL5kod3hhwMtGvc9fsXvW7bukB8mgtEa7T3mIilXjB2r6+KpNz8KxEKWMs0JDtaZQ6
 7c++F0bS+14ZLQ+fOo28DDirHzGutzWYmHj4LGFM7E5bhe3vQ0bG49z1iYDdtQ/J6+u6
 Mzi8v3fhUCQ+KiwbtreAnmGfDvttWJaLl07HZC0mY5mr/lR6/ympiQAr50gnAI/rNwfc
 lVzg==
X-Gm-Message-State: AOAM530/71RxudB1n1NgZcOxEMx0Pewv/p76s2/D4GH8jdDHb+nGCko7
 GCe715Muiuml1lfkr1+LWY/Q21VFmiRaAjgNJmE=
X-Google-Smtp-Source: ABdhPJxLmSnyda2PBJEEq5cEcITicYiLvPWDgRiFUYIJaE1j1M0f63m2+QhMeCSShcm3Ueu6upZx6ny0NIYDAATMJg4=
X-Received: by 2002:aa7:c251:0:b0:404:769b:adb3 with SMTP id
 y17-20020aa7c251000000b00404769badb3mr22324301edo.98.1645456374364; Mon, 21
 Feb 2022 07:12:54 -0800 (PST)
MIME-Version: 1.0
References: <20220221144740.19913-1-kito.cheng@sifive.com>
 <d179f232-6c30-63da-7a47-1f7ec5914cf1@irq.a4lg.com>
In-Reply-To: <d179f232-6c30-63da-7a47-1f7ec5914cf1@irq.a4lg.com>
From: Kito Cheng <kito.cheng@gmail.com>
Date: Mon, 21 Feb 2022 23:12:43 +0800
Message-ID: <CA+yXCZBaCtsjZDGZRV1a-uE4RX0gj76f0fTt8w3JZw5VdqTXJA@mail.gmail.com>
Subject: Re: [PATCH] RISC-V: Maintain a string to hold the canonical order
To: Tsukasa OI <research_trasio@irq.a4lg.com>
Cc: Kito Cheng <kito.cheng@sifive.com>, Binutils <binutils@sourceware.org>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: binutils@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Binutils mailing list <binutils.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/binutils>,
 <mailto:binutils-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/binutils/>
List-Post: <mailto:binutils@sourceware.org>
List-Help: <mailto:binutils-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/binutils>,
 <mailto:binutils-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Feb 2022 15:13:01 -0000

> Just "*ext" or "*ext != '\0'"? comparing a const char (not pointer) with
> NULL looks a bit odd.

Thanks for catching that, that's functional equivalent, but definitely
wrong semantic.