From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by sourceware.org (Postfix) with ESMTPS id CF0B93858D33 for ; Thu, 1 Feb 2024 12:52:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CF0B93858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CF0B93858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::533 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706791958; cv=none; b=pYsgWS9SksUAUlWXauDE5KjvY0Gv3jKZwoFa+83qxCYoMALPkmDd+PP5jSYECYYoekEBBP89yMY1WjV4+YD3FvlxM6EM0edvJ5Qd8F436swkvKmBqxtuNL2w6DQBpFXyXvOW0oMeWqY8DAedeNv0Sdv9cK5a1rZG3aIQgJp8IzU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706791958; c=relaxed/simple; bh=Bh4/1zAmYpgAf5KJiXuOhDPcBJy7nwewTx4J16h8/ss=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=O4fhb0/XzHct201pAbMwMP4u3RXyRqEBNH/OnuJdi4sfIz1xXe+obrIZHkGfw1FNNAEmAgYXimCY25GOWWKfPr2my/VSw7ADTlxcTJtqfbalg5vs28jTTNuwnZe6UuPSgB9IXhcRw//1nqSYMEntY2gX3tR1AimUrpxIRfqaplw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-55ad2a47b7aso1225465a12.3 for ; Thu, 01 Feb 2024 04:52:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706791955; x=1707396755; darn=sourceware.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=zkba1yUQhI81HuOVolA6lHwOYr6hjxCrmOFKDQOR3kE=; b=ST7Ms3QDfW6YEjjl3nbDfE5U5ZKhZOERREFNE6iTlKPxN7qNLpl1C3z5DN4WddD1ck PZvHK1tdTqAlndxzX66fQNzuo4R+kC5JmGqR85F78iC5AIeC8X9k1sdcRrmf7SrN+YQB JeimbcZr3XCfkqxU0JWmCp9I2EvhylG2KSV61SfY5HR31Kzox7v2YxsvSDcYWTBYZ9Z1 4pfHy4bpD5h1IwuZ64zqRlMcosdBOsxD2fd1IVvgR9naxSk2t/5zdfq5CMm1mBssr789 fe72r72loCYtuGFfxAInARnypr2l2ZRi2PLhW5mjKqD/jysdSFBtS+xnLPsgnwWF7zr0 oGBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706791955; x=1707396755; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zkba1yUQhI81HuOVolA6lHwOYr6hjxCrmOFKDQOR3kE=; b=F3gbxtndN1+hjBaCOQkJNn+Yz32F2hLtgH3yUzmz957tb7uF7kxhvUgt9BKF5KEm/j ufCMHW3iPkn9Cw3h9lOxlWvWOlrIkNolYd3ACi8MniE3DRYED/qLuCxCSusiDecI93S5 y8A6RfirxJkKlLDxUJBafq5I3ufb0ZXzECnDCgwp8ONU/tm4jm/cGDUJZk8tgMpP15dD NzasZC8WcmA3Qb+98rxfqVvrWaj16u+P0EaFKKmG7s73kk9/SbHDiiG3f+/gF63dPWwT 1ZRcmFw8xKLbPzAgfEXXv9Ynnkl8P/466wYZOhafvzaofE03llpa4BPXuNzuT5trrKFk Pnag== X-Gm-Message-State: AOJu0Yyy+7Ni7+kGmn0KOVunze4f1vGZb5ph+0N88l9++j9ZYgCtIzn+ PPDBa4XPG7HnUzaQEdR8SWU9JffBzc1NN8G2Ov16Cs8wNq7AwMzrJBwT5CwNOFnemGkmvdbe26h pdO800Uv8XOhZ37rCBgQbZL7799tM6v+R41rMSMxW X-Google-Smtp-Source: AGHT+IFpMKuc6AQ+waP1JFYb/14wvDDt0IIVmuNPKT8uA/SQWOSwZzh3o7aAV3q7kTgsBaSXzt8Syk0Cu4PojxgKkrw= X-Received: by 2002:a17:907:b9d6:b0:a35:a87c:b842 with SMTP id xa22-20020a170907b9d600b00a35a87cb842mr1596833ejc.57.1706791954901; Thu, 01 Feb 2024 04:52:34 -0800 (PST) MIME-Version: 1.0 References: <20240131141122.350700-1-jiawei@iscas.ac.cn> In-Reply-To: <20240131141122.350700-1-jiawei@iscas.ac.cn> From: Kito Cheng Date: Thu, 1 Feb 2024 20:52:23 +0800 Message-ID: Subject: Re: [PATCH v6 1/2] RISC-V: Support Zcmp push/pop instructions. To: Jiawei Cc: binutils@sourceware.org, nelson@rivosinc.com, kito.cheng@sifive.com, palmer@dabbelt.com, jbeulich@suse.com, research_trasio@irq.a4lg.com, christoph.muellner@vrull.eu, jeremy.bennett@embecosm.com, nandni.jamnadas@embecosm.com, mary.bennett@embecosm.com, charlie.keaney@embecosm.com, simon.cook@embecosm.com, sinan.lin@linux.alibaba.com, gaofei@eswincomputing.com, fujin.zhao@foxmail.com, wuwei2016@iscas.ac.cn, shihua@iscas.ac.cn, shiyulong@iscas.ac.cn, chenyixuan@iscas.ac.cn Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > +static bool > +reglist_lookup (char **s, unsigned *reg_list) > +{ > + unsigned regno = 0; > + unsigned regnum = 0; > + char *reglist = strdup (*s); char *token; > + char *regname[3]; > + > + if (reglist == NULL) > + goto next; > + > + /* Use reglist to judge the reg name use. */ > + reglist = strtok (reglist, "}"); token = strtok (reglist, "}"); You need to keep the original pointer which points to the start of the space you got, otherwise it will cause problems when you free that. > + for(reglist = strtok (reglist, ",");reglist;reglist = strtok(NULL, ",")){ for(token = strtok (token, ","); token ;token = strtok (NULL, ",")) { > + regname[regnum] = reglist; regname[regnum] = token;