From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x932.google.com (mail-ua1-x932.google.com [IPv6:2607:f8b0:4864:20::932]) by sourceware.org (Postfix) with ESMTPS id 214153857704 for ; Fri, 30 Jun 2023 06:49:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 214153857704 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ua1-x932.google.com with SMTP id a1e0cc1a2514c-78caeb69125so598755241.3 for ; Thu, 29 Jun 2023 23:49:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688107780; x=1690699780; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=DTWgBaMpRfZ9/tfBziKfZSGSq+IOelY2yciuH2GFMTw=; b=kyG/2t0D7r97GBUx/ssSA1ZTLMlh+DeDuWwkoeDu6GLN/EthRgOFPAyRvr2DYugbdq gEHpj4resrN/OI68cfhMHA4c5vtm9z9PPJuH/YCMzz09Tes2tMAxCnUo38c7WQMPJl4k 9oq2+dsTLe2+Uw0RfnjBfEas0mZrQ1+HAPn1mJbqo5RwYFz7A3zfh/cphXy9A8M8r1N2 y9lqpNfLY4oF0TUhmdhY6Yj/KejJjDKuCv8SK10AYIMDyMOyHKG9JlpcyvbvXFayAFtR W8B1T42n6grJNR0/t+nP3SkNu8r/dRtOa6COzIq+UDA8gbqVWPL9xxSfDbcM8gnw75rA UryA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688107780; x=1690699780; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DTWgBaMpRfZ9/tfBziKfZSGSq+IOelY2yciuH2GFMTw=; b=D2+4rhQEUJjsot4Ka/MoZ8w/lF4jlv0E93x0iZ4LiXkv4Xn1q9ay4Oo09U8P9voA31 YRhUW0EDOottKcraljdgIK4JMRAY2ZO0CL/jmwhhAzSvjptJQi+BRDU0N7uJiKcTitc6 /4Zi4cuR5PxOpLhhX4TmeSDHCNdJ5YCcT888coJ+8VBbrCBQeFVKY9OzW7mb1GNdhy7r el16Zr+ZcnE0am+mKgQL8vw40J3Ws/9A1ySuRxxUSnViTKZLe7OdAInsvu07pQa6gVDY GTzRlpTa43lpVP+xaIHXsBe93hjbrfZjnM9lHjWNWNLkT36N5inHpdNlWUgke+cZaoR1 U8jg== X-Gm-Message-State: ABy/qLYRxWlVfTOawb+GEp76ouKR5IE/tIvJ9jsK2OXnJas7OVaQohFM k1QWXxZ2GajNN9MHArIhPr+9Ahqm0RDkgAAuxhaAVmGX8tE= X-Google-Smtp-Source: APBJJlHqeXjBQ2K4cE0KqrTDQj3t9pY53/sswXBlRrDTvFP4aImE9Vt8f2cer9ONvGocevx036UPQBZL43K+nw9F42Y= X-Received: by 2002:a67:eed0:0:b0:443:6cd7:6dc3 with SMTP id o16-20020a67eed0000000b004436cd76dc3mr1495427vsp.5.1688107779667; Thu, 29 Jun 2023 23:49:39 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Kito Cheng Date: Fri, 30 Jun 2023 14:49:28 +0800 Message-ID: Subject: Re: [RFC PATCH v5] RISC-V: Add support for the Zfa extension To: Nelson Chu Cc: Palmer Dabbelt , jeffreyalaw@gmail.com, christoph.muellner@vrull.eu, binutils@sourceware.org, Andrew Waterman , Jim Wilson , philipp.tomsich@vrull.eu, jbeulich@suse.com, research_trasio@irq.a4lg.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Nelson: > > Presumably someone's actually looked at the code? If not I can look > > over it... > > > > I have looked and replied, Kito and Jan should also have looked. The > special zfa syntax should be the same as LLVM when I looked. But since > that is almost two month ago, it's good if someone helps to review it again > to make sure everything is on the line. The syntax part matches https://github.com/riscv-non-isa/riscv-asm-manual/pull/85, which also matches LLVM implementation. I am happy to see no syntax divergence on both sides :) So give my blessing, this patch LGTM.