From: Marcus Nilsson <brainbomb@gmail.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] readelf: Replace xmalloc with malloc in slurp_relr_relocs
Date: Fri, 17 Jun 2022 11:01:34 +0200 [thread overview]
Message-ID: <CAA1E49v3Qim3pY=SG9bCVwt9O22iN-AuodWH=MJ22nxvU6Nk4Q@mail.gmail.com> (raw)
In-Reply-To: <b05dd046-60cb-790b-72d4-cee4f7adef9c@suse.com>
Thank you for you reply. Since I don't have push permissions, feel free to
commit this one if no one disapproves.
Thanks,
Marcus Nilsson
On Wed, Jun 8, 2022 at 8:11 AM Jan Beulich <jbeulich@suse.com> wrote:
> On 07.06.2022 23:23, Marcus Nilsson via Binutils wrote:
> > Using xmalloc makes the null check redundant since failing allocation
> > will exit the program. Instead use malloc and let the error be
> > conveyed up the call chain.
> >
> > binutils/ChangeLog:
> > * readelf.c: (slurp_relr_relocs) Use malloc instead of xmalloc
> > when allocating space for relocations.
>
> OK.
>
> Jan
>
>
--
Marcus Nilsson
-
tel: +46(0)704911844
mail: marcus@landmarknilsson.se
github: github.com/metmo
linkedin: linkedin.com/in/landmarknilsson
prev parent reply other threads:[~2022-06-17 9:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 21:23 Marcus Nilsson
2022-06-08 6:11 ` Jan Beulich
2022-06-17 9:01 ` Marcus Nilsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA1E49v3Qim3pY=SG9bCVwt9O22iN-AuodWH=MJ22nxvU6Nk4Q@mail.gmail.com' \
--to=brainbomb@gmail.com \
--cc=binutils@sourceware.org \
--cc=jbeulich@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).