From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by sourceware.org (Postfix) with ESMTPS id B2CAF3858C5F for ; Mon, 19 Jun 2023 14:21:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B2CAF3858C5F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-4f85966b0f2so3883700e87.3 for ; Mon, 19 Jun 2023 07:21:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; t=1687184485; x=1689776485; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=hjOQTUJbO+iW2T5OHZA7MI51IdWHyUrDY2v0tp86ccM=; b=QhA+zCZjUA+jUGUavZAoo0P4oktOcq6LixVcO2AVzheMsZpmaF+eW7Qf8WkjjA310R SyeSOTuK73vUF7gIR469GGyHFjveQk10k5ZFwsDKVb+3d97RWrUj9XevnrrOe/RrlMtQ hKBI75CuuRZNZl41hXgAFjee00ZMZ1WjEAjxraTsnDP5qh2Tt0yX3rtXVZ8VcnHBD9/4 qguHPMtCzo8BY+edQpXlE38R7OXDH6vRcT/vcLQwIQzMgirAZctn1SA6JKZi6uRnXFF+ un6vfrCRr7Hj7XxTXNurJ43SKdC27mlc2CLzThUe6sQFp6Duh81aSnSpxTmMIMbP8HmS i80Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687184485; x=1689776485; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hjOQTUJbO+iW2T5OHZA7MI51IdWHyUrDY2v0tp86ccM=; b=EglQE9hh2QadMjYaQ37s5AjvaboZzCiRRJdNv23Y+Ezj340VhP0RRDQEJzDsUH9AOF EOcYa48UI8pgh5wDDEDgNg4PRqUJoLdJkzewTwpxzcY0GdIEtRxKOPNXzpB0L1GlzoP/ TpKG4lFIdWJ4F0cKrxRc7DfZqL7WvUPY2oZ8WgriPDjWrfYUbaqWsz+pzhidaOQtmxe1 DILZN0QLFI0bEUQfzOfTd3TC6uMu5Gy2doe2F8Y8ukmulR8iQEmmWc2Wwfo6YHWASgUZ R3L9PdjL7PSCLLVQi4Ba6/bhiBnK+4ROZxa+iMSFsK5Ljn0BLguk55fqvKs5/9SbUP0+ ZZKA== X-Gm-Message-State: AC+VfDxuhxYDcVmo7ryLVSmWlcQWdkDAyf7yqj35818jCg9T4ljOzzKw 5kLPJdaWoKhn7NZpwPWeL/zsfjUpjcR44GNEjedzmN8Er0N1UXQL X-Google-Smtp-Source: ACHHUZ4IfsowpErRPIxyYH4XEdcFE6Z93jq5Cj0lqA5ZBDPGOnP/Dz836Ce994soOJGOxMshpU+W241UIGDXaQYQvOI= X-Received: by 2002:a19:434b:0:b0:4f1:477c:f8a9 with SMTP id m11-20020a19434b000000b004f1477cf8a9mr4670469lfj.65.1687184484941; Mon, 19 Jun 2023 07:21:24 -0700 (PDT) MIME-Version: 1.0 References: <20230121002935.1139281-1-philipp.tomsich@vrull.eu> <7dfcdb8b-f8ba-f0ae-b71f-f6fef1acac13@gmail.com> In-Reply-To: <7dfcdb8b-f8ba-f0ae-b71f-f6fef1acac13@gmail.com> From: Philipp Tomsich Date: Mon, 19 Jun 2023 16:21:14 +0200 Message-ID: Subject: Re: [RFC PATCH v1] RISC-V: Support Zicond extension To: Jeff Law Cc: binutils@sourceware.org, Kito Cheng , Nelson Chu , Christoph Muellner Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Given that the 2.41 milestone is approaching and Zicond has passed the FREEZE milestone (and is even out of public review already), I would like to move this forward. Is this OK for trunk? Should I resubmit with an updated commit message? Thanks, Philipp. On Thu, 26 Jan 2023 at 01:26, Jeff Law wrote: > > > > On 1/20/23 17:29, Philipp Tomsich wrote: > > *** Zicond is not FROZEN at this time. Do not merge until FROZEN. *** > > > > This implements the Zicond (conditional integer operations) extension, > > as of version 1.0-draft-20230120. > > > > The Zicond extension acts as a building block for branchless sequences > > including conditional-arithmetic, conditional-logic and > > conditional-select/move. > > The following instructions constitute Zicond: > > - czero.eqz rd, rs1, rs2 => rd = (rs2 == 0) ? 0 : rs1 > > - czero.nez rd, rs1, rs2 => rd = (rs2 != 0) ? 0 : rs1 > > > > See > > https://github.com/riscv/riscv-zicond/releases/download/v1.0-draft-20230120/riscv-zicond_1.0-draft-20230120.pdf > > for the proposed specification and usage details. > > > > bfd/ChangeLog: > > > > * elfxx-riscv.c (riscv_multi_subset_supports): Recognize > > INSN_CLASS_XVENTANACONDOPS. > > (riscv_multi_subset_supports_ext): Recognize > > INSN_CLASS_XVENTANACONDOPS, > > > > gas/ChangeLog: > > > > * testsuite/gas/riscv/zicond.d: New test. > > * testsuite/gas/riscv/zicond.s: New test. > > > > include/ChangeLog: > > > > * opcode/riscv-opc.h (MATCH_CZERO_EQZ): Define. > > (MASK_CZERO_EQZ): Define. > > (MATCH_CZERO_NEZ): Define, > > (MASK_CZERO_NEZ): Define. > > (DECLARE_INSN): Add czero.eqz and czero.nez. > > * opcode/riscv.h (enum riscv_insn_class): Add > > INSN_CLASS_ZICOND > > > > opcodes/ChangeLog: > > > > * riscv-opc.c: Add czero.eqz and czero.nez. > Given this extension is derived from the Ventana condops extension, I > may be somewhat biased. The mnemonics and encoding is obviously > different, but the behavior is the same (perhaps differing in timing > characteristics, but I think that's outside of what we care about here). > > I assume nobody cares about gdbsim, so nothing to do there. With that > assumption this is fine to go forward once the spec freezes. > > jeff >