From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id 1C0BD3858D3C for ; Mon, 21 Feb 2022 14:17:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1C0BD3858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-wr1-x42a.google.com with SMTP id f17so2469902wrh.7 for ; Mon, 21 Feb 2022 06:17:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=oKfVHQdwOutXuSQ3ZN++9noWzYUBctbiYC6XMhVIn64=; b=o95Zq/ACDBRgXRGL2TakJPf0PBUBqnhz16WWPU4k+erEa3QUlU0TWhtrE/SEm0KWM0 oDFLts9iNZld23zwFVbB2XhmyEUvEe7cYswPFDQdRpkVLKDRS2t60UyvgJlUlOxeGcNT kBa1JIBQ3TIo/TubwvjU+dp30wzOzFCbrzPDsaDrDtfA1AWFG+Pk+ubzCR2FL7k3q1JS ZE+oemn7aoVDui3ytmT13xWZRezG8VpYILOOy0J6dFu+nRtXlp3ORHSbjmLWxSvbngrZ bHi9BfW/+5tNEhj+56bJBqY9kfKvNrRcGo5Q06wXiOKmrn8crhIUsb5XGF7rIAWToUn/ bZ6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=oKfVHQdwOutXuSQ3ZN++9noWzYUBctbiYC6XMhVIn64=; b=znmW+gL62oKfXvm6HQ/9bXsAd1lBe9k0Fq3yj1UhZZk9eyRwlmuNWVkHEp98oTnHgc yIP3sYFY0uT5o/Iqk3N3/La9APuu3af6SCCSF4sXEwMR4zJUyXVK4RS6FSpu1UC6CcZn EBQVWTrJdvjo38SaXkURVbbezI+NUb7XCoGVGRGjSeiMv292LJ8oZPcKft9J7Y+zgIUP 0StaQ1CwwXyIoTrm4BbdRPk98LiEO6F8r6BApt4lZ7vMFwERkMmXoS2erx0R1rLQnfcu eAf4WLpvvpxcvQ35ZAV9lMftm3m+OALAQnSmVtcImjRPaGCDrIXtNyWLT0fWvISJtSIk 5j1A== X-Gm-Message-State: AOAM530bjXrEKyEEmAouVpcbcYRp57SGX79kaFcqmzO3zKB5arwKd0Sd xIPIhnjv9efJ+93a6riNF2ikHZMcqC0WR73MuutIrA== X-Google-Smtp-Source: ABdhPJyEmGVIqzFxk8rkH5f8TON6UvbHgWdIHHuqm0oH1VNqxCd1MIp1LfSb83DVFs/cOT5V+2ttpDakEkdbi3X2iVI= X-Received: by 2002:a5d:6292:0:b0:1e6:29f5:e1df with SMTP id k18-20020a5d6292000000b001e629f5e1dfmr15430778wru.120.1645453022152; Mon, 21 Feb 2022 06:17:02 -0800 (PST) MIME-Version: 1.0 References: <20211115030343.276103-1-jiawei@iscas.ac.cn> <20211115030343.276103-2-jiawei@iscas.ac.cn> <1490a2a8.1571c.17f1ca1de44.Coremail.jiawei@iscas.ac.cn> In-Reply-To: <1490a2a8.1571c.17f1ca1de44.Coremail.jiawei@iscas.ac.cn> From: Philipp Tomsich Date: Mon, 21 Feb 2022 15:16:51 +0100 Message-ID: Subject: Re: Re: [PATCH v4 1/3] RISC-V: Minimal support of scalar crypto extension To: jiawei@iscas.ac.cn Cc: Jan Beulich , kito.cheng@sifive.com, nelson.chu@sifive.com, jimw@sifive.com, mjos@pqshield.com, ben.marshall@pqshield.com, cmuellner@ventanamicro.com, palmer@dabbelt.com, andrew@sifive.com, lazyparser@gmail.com, siyu@isrc.iscas.ac.cn, schwab@linux-m68k.org, binutils@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Feb 2022 14:17:05 -0000 On Mon, 21 Feb 2022 at 15:14, wrote: > > > > > > -----=E5=8E=9F=E5=A7=8B=E9=82=AE=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: "Jan Beulich" > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022-02-21 21:24:11 (=E6=98=9F= =E6=9C=9F=E4=B8=80) > > =E6=94=B6=E4=BB=B6=E4=BA=BA: jiawei > > =E6=8A=84=E9=80=81: kito.cheng@sifive.com, nelson.chu@sifive.com, ji= mw@sifive.com, philipp.tomsich@vrull.eu, mjos@pqshield.com, ben.marshall@pq= shield.com, cmuellner@ventanamicro.com, palmer@dabbelt.com, andrew@sifive.c= om, lazyparser@gmail.com, siyu@isrc.iscas.ac.cn, schwab@linux-m68k.org, bin= utils@sourceware.org > > =E4=B8=BB=E9=A2=98: Re: [PATCH v4 1/3] RISC-V: Minimal support of sc= alar crypto extension > > > > On 15.11.2021 04:03, jiawei wrote: > > > Minimal support of scalar crypto extension, add "k" in riscv_su= pported_std_ext[] to make the order check right with "zk" behind "zb". "z= bk*" is sub-extension for k-ext, so it added behind "zbs" in riscv_supporte= d_std_z_ext[]. > > > --- > > > bfd/elfxx-riscv.c | 28 ++++++++++++++++++++++++++++ > > > 1 file changed, 28 insertions(+) > > > > > > diff --git a/bfd/elfxx-riscv.c b/bfd/elfxx-riscv.c > > > index 3ffbaad66dd..152fbe3d160 100644 > > > --- a/bfd/elfxx-riscv.c > > > +++ b/bfd/elfxx-riscv.c > > > @@ -1075,6 +1075,20 @@ static struct riscv_implicit_subset risc= v_implicit_subsets[] =3D > > > {"q", "d", check_implicit_always}, > > > {"d", "f", check_implicit_always}, > > > {"f", "zicsr", check_implicit_always}, > > > + {"zk", "zkn", check_implicit_always}, > > > + {"zk", "zkr", check_implicit_always}, > > > + {"zk", "zkt", check_implicit_always}, > > > + {"zkn", "zbkb", check_implicit_always}, > > > + {"zkn", "zbkc", check_implicit_always}, > > > + {"zkn", "zbkx", check_implicit_always}, > > > + {"zkn", "zkne", check_implicit_always}, > > > + {"zkn", "zknd", check_implicit_always}, > > > + {"zkn", "zknh", check_implicit_always}, > > > + {"zks", "zbkb", check_implicit_always}, > > > + {"zks", "zbkc", check_implicit_always}, > > > + {"zks", "zbkx", check_implicit_always}, > > > + {"zks", "zksed", check_implicit_always}, > > > + {"zks", "zksh", check_implicit_always}, > > > {NULL, NULL, NULL} > > > }; > > > > > > @@ -1127,6 +1141,7 @@ static struct riscv_supported_ext riscv_s= upported_std_ext[] =3D > > > {"c", ISA_SPEC_CLASS_20190608, 2, 0, 0 }= , > > > {"c", ISA_SPEC_CLASS_2P2, 2, 0, 0 }= , > > > {"b", ISA_SPEC_CLASS_NONE, RISCV_UNKNOWN_VERSIO= N, RISCV_UNKNOWN_VERSION, 0 }, > > > + {"k", ISA_SPEC_CLASS_NONE, RISCV_UNKNOWN_VERSIO= N, RISCV_UNKNOWN_VERSION, 0 }, > > > > May I ask what purpose this addition serves? Without its use enablin= g > > smaller scope extensions implicitly, I find it at best unhelpful tha= t > > ".option arch, +k" is accepted without having any effect. > > > > Jan > > It's same like bitmanip extension, add this will make k extension as a su= bextension > and set it's canonical order as ISA spec defined. Let me point out that this is not the same as with the bit-manipulation family of extensions. Zb[abcs] are all standalone extensions, and there is no Zb. --Phil. > > > > > > @@ -1146,6 +1161,19 @@ static struct riscv_supported_ext riscv_= supported_std_z_ext[] =3D > > > {"zba", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 = }, > > > {"zbc", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 = }, > > > {"zbs", ISA_SPEC_CLASS_DRAFT, 1, 0, = 0 }, > > > + {"zbkb", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 = }, > > > + {"zbkc", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 = }, > > > + {"zbkx", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 = }, > > > + {"zk", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 = }, > > > + {"zkn", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 = }, > > > + {"zknd", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 = }, > > > + {"zkne", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 = }, > > > + {"zknh", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 = }, > > > + {"zkr", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 = }, > > > + {"zks", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 = }, > > > + {"zksed", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 }, > > > + {"zksh", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 = }, > > > + {"zkt", ISA_SPEC_CLASS_DRAFT, 1, 0, 0 = }, > > > {NULL, 0, 0, 0, 0} > > > }; > > > >