public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Philipp Tomsich <philipp.tomsich@vrull.eu>
To: Nelson Chu <nelson@rivosinc.com>
Cc: Jan Beulich <jbeulich@suse.com>,
	Christoph Muellner <christoph.muellner@vrull.eu>,
	 binutils@sourceware.org, Andrew Waterman <andrew@sifive.com>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	Jim Wilson <jim.wilson.gcc@gmail.com>
Subject: Re: [PATCH] RISC-V: Eliminate long-casts of X_add_number in diagnostics
Date: Fri, 30 Sep 2022 16:55:50 +0200	[thread overview]
Message-ID: <CAAeLtUBikyyEwA35N82GvkaVUVAmNQsXcV0Z79eq=O6ga=AvYg@mail.gmail.com> (raw)
In-Reply-To: <CAPpQWtDBm+0zcV9NfCcCnrq5aW3=oaiBjnuoYL4=ckrOdPGCVQ@mail.gmail.com>

Thanks! Applied to master.

Philipp.


On Fri, 30 Sept 2022 at 16:46, Nelson Chu <nelson@rivosinc.com> wrote:
>
> Both approved, please commit.  Thanks for helping to fix them.
>
> Nelson
>
> On Fri, Sep 30, 2022 at 6:46 PM Jan Beulich <jbeulich@suse.com> wrote:
> >
> > On 30.09.2022 12:39, Christoph Muellner wrote:
> > > From: Christoph Müllner <christoph.muellner@vrull.eu>
> > >
> > > As reported in (and in addition to)
> > > https://sourceware.org/pipermail/binutils/2022-September/123198.html
> > > there is no need for casts to (signed/unsigned) long, as we can use
> > > C99's PRIs64/PRIu64 format specifiers.
> >
> > For archaeologists you may want to s/PRIs64/PRId64/, such that no-one
> > will be misguided. Otherwise thanks for taking care of the other items
> > this quickly. I'll leave approving of this (as well as my earlier
> > patch) to the arch maintainers, though.
> >
> > Jan

  reply	other threads:[~2022-09-30 14:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-30 10:39 Christoph Muellner
2022-09-30 10:46 ` Jan Beulich
2022-09-30 14:45   ` Nelson Chu
2022-09-30 14:55     ` Philipp Tomsich [this message]
2022-09-30 19:26 ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAeLtUBikyyEwA35N82GvkaVUVAmNQsXcV0Z79eq=O6ga=AvYg@mail.gmail.com' \
    --to=philipp.tomsich@vrull.eu \
    --cc=andrew@sifive.com \
    --cc=binutils@sourceware.org \
    --cc=christoph.muellner@vrull.eu \
    --cc=jbeulich@suse.com \
    --cc=jim.wilson.gcc@gmail.com \
    --cc=nelson@rivosinc.com \
    --cc=palmer@dabbelt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).