From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id ACC5E385841E for ; Mon, 17 Jan 2022 12:57:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ACC5E385841E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-wm1-x336.google.com with SMTP id l12-20020a7bc34c000000b003467c58cbdfso24150403wmj.2 for ; Mon, 17 Jan 2022 04:57:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+WOlmWEH9giOabZF6Nd+qA5MnDIi7EJv5u+hXVF2VyA=; b=OcHOzfVqq1uG8P9RunH5P8btmca6vpY5SAtF8or7EBrOXsToiwkmT/zfM9U4r8Rmop idqRjhfbMmxlp3ApQS6yxiwEsIgr1RyI7V9XNwDlwDWycKczliuP4qZVcWfTvA8v7B13 /4xXq+9ZklpPYddjCGM3Mbac2370/WI/HQDkBfuKvFxMjShOOIuAfm+sd8IZrYAU0yWw im3JDPZuMf/XjMdvLT8DnUCMewSAxI3M023afi6n/dBu/a+2RNdFcix5JJr8eUXU/g9a JvNoBzNseU+a9JgI+5Ppc+iShhUj1fGsCrBpNyRW+lYMxEpw0C9ddAc2npHUIXB1uaaM 3pOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+WOlmWEH9giOabZF6Nd+qA5MnDIi7EJv5u+hXVF2VyA=; b=QHyNkg8Cfp4R5A5DZcpZGQhnZK/bynxLo3PAETFOEVwihc79xGL3TfPjIIPUIm2PzT KnrWrc1Hbb0n4bOeVHXAktMKpJ81NIG7/7smV8yva7viLAI69ssrZmR6FGxwN4U5nHsf PEDwv3sshnvcejcAetZm/sCXZwCAYDKkopT8/6gLNiVZxdtRAV+OBLX+86W3TBBasgx8 61+XY7GXq2TRLpo1PS12TKLF2khUP7U0s3xa42igtFfDzkSx52lxKeqkn3YAucDqoMY5 yR079yFIX0GQli5mdKJzxlS9TfSRhfzNtjirv2BFNTev2Z+FbrA3dNsfL7wS1Ef/zNkA uBfw== X-Gm-Message-State: AOAM530BzDo3wBO5pqgjINPpmHiCGURb+KEb5QZSWucWguOZVnPIPsw0 ULFWV1Q+HbYgDP5eZ/DL4qrPp81PNT6sqiCLLKT//NamVVc= X-Google-Smtp-Source: ABdhPJzRwgbQkhBWjh1cEWDEbLqTupK7cZrm5cMd7r4o9UwahFD3CMZc7Qm8pGxWUtxjtF9wnOOAVTwpM5+cEIjl2KY= X-Received: by 2002:a1c:2784:: with SMTP id n126mr19860701wmn.48.1642424252252; Mon, 17 Jan 2022 04:57:32 -0800 (PST) MIME-Version: 1.0 References: <20220109192948.4046853-1-philipp.tomsich@vrull.eu> In-Reply-To: <20220109192948.4046853-1-philipp.tomsich@vrull.eu> From: Philipp Tomsich Date: Mon, 17 Jan 2022 13:57:20 +0100 Message-ID: Subject: Re: [PATCH v1] RISC-V: Support XVentanaCondOps extension To: binutils@sourceware.org Cc: Kito Cheng , Nelson Chu , Greg Favor , Christoph Muellner X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jan 2022 12:57:35 -0000 Kito & Nelson, On Sun, 9 Jan 2022 at 20:29, Philipp Tomsich wrote: > Ventana Micro has published the specification for their > XVentanaCondOps ("conditional ops") extension at > > https://github.com/ventanamicro/ventana-custom-extensions/releases/download/v1.0.0/ventana-custom-extensions-v1.0.0.pdf > which contains two new instructions > - vt.maskc > - vt.maskcn > that can be used in constructing branchless sequences for > various conditional-arithmetic, conditional-logical, and > conditional-select operations. > > To support such vendor-defined instructions in the mainline binutils, > this change also adds a riscv_supported_vendor_x_ext secondary > dispatch table (but also keeps the behaviour of allowing any unknow > X-extension to be specified in addition to the known ones from this > table). > > As discussed, this change already includes the planned/agreed future > requirements for X-extensions (which are likely to be captured in the > riscv-toolchain-conventions repository): > - a public specification document is available (see above) and is > referenced from the gas-documentation > - the naming follows chapter 27 of the RISC-V ISA specification > - instructions are prefixed by a vendor-prefix (vt for Ventana) > to ensure that they neither conflict with future standard > extensions nor clash with other vendors > > bfd/ChangeLog: > > * elfxx-riscv.c (riscv_get_default_ext_version): Add > riscv_supported_vendor_x_ext. > (riscv_multi_subset_supports): Recognize > INSN_CLASS_XVENTANACONDOPS. > > gas/ChangeLog: > > * doc/c-riscv.texi: Add section to list custom extensions and > their documentation URLs. > * testsuite/gas/riscv/x-ventana-condops.d: New test. > * testsuite/gas/riscv/x-ventana-condops.s: New test. > > include/ChangeLog: > > * opcode/riscv-opc.h Add vt.maskc and vt.maskcn. > * opcode/riscv.h (enum riscv_insn_class): Add > INSN_CLASS_XVENTANACONDOPS. > > opcodes/ChangeLog: > > * riscv-opc.c: Add vt.maskc and vt.maskcn. Given that this doesn't have any wider effects, I would like to merge this for the next release. Any feedback on this patch? Thanks, Philipp.