From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id 303C73858401 for ; Fri, 4 Feb 2022 08:43:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 303C73858401 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=vrull.eu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=vrull.eu Received: by mail-wr1-x435.google.com with SMTP id d15so1141723wrb.9 for ; Fri, 04 Feb 2022 00:43:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vrull.eu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=XzcRTi0q7Rbrom9HntLUfOKrsyVG4aKcbA+H9x1uDBs=; b=qmBAlfw8PZG8UdPkGEaZ2SDUqLBhX/Ut/k3Z1tc3KZ2Fy/3g4YPlGKR2n3qLZGtqR2 w0NlgkmLjLWj7FSvZF4jRlm0vkyQVFbxN3gUHSN3Ey1vQO+Q/7aP2fL8psk1/JPVexwL 6miCeIyJaoZGsAqVKpkALNpnWVuMWcQFCIVgyk5GxBebkOx72bJHSdByjltErmWlgbTV is+M14p1pETG1G7EDbRathnqbI8+WJKuyisfYl1gGqVoBHLokitmkNicsKSYS0Jt3+Fk aa2C8TgwqGuBqoDnF/TRV2VLMSEeVU/9wCYv4ABthN7mCrjgf/dDZ4aEFu3mxpF07yTy E7yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XzcRTi0q7Rbrom9HntLUfOKrsyVG4aKcbA+H9x1uDBs=; b=cR2I78qSX/U8lpwPccYXU2zguxuOhLHejtbRiDuwJt2rv/7cWUeqAfMd5FOUTh4Vx3 V1TWn/90Bp+C9hdpKI9zAfBbXgSyvPtBGX7BsNUZzfhQ+8fOULtHBg6ZDcsNXUEDsi9E RH03UaaAhfjIdOPQayKgUdK5bE9RZXSiDKw4m1cxeHugO8d7Rtv711RX6yN+R1k/z2hf jYE0GqFNoIPTxKz5B8eAaIci61RlXPt/U6UDGr9fNoWJz7qw0Oy3Vr3F/Y71sUKJ2gPt stMukO3vBi7ADnHVg9kZG+Cgg880uMu6Vr72QAZAvcPO9TUKn0e3VegIR8BfgSFZOh0G qA7A== X-Gm-Message-State: AOAM530MCsBc7P9wtYuk3Wr9J2P0PaVFSYXvhLbb8jwR/ov2WZf5xT13 xG/HtV/hMv1SenjXgme2bkyzDmdUjQepR/82wPy6KPzHwjX7gxbl X-Google-Smtp-Source: ABdhPJz/t3XiqRSy4HzgFOU+Mt+IJOKXNHruxsX2yQJEuM6ESdv65IhbVc2vDNvMy/CVtgvK67rs3eFUBH1VUHXLUnI= X-Received: by 2002:a05:6000:18a4:: with SMTP id b4mr1546257wri.641.1643964208236; Fri, 04 Feb 2022 00:43:28 -0800 (PST) MIME-Version: 1.0 References: <20220204001358.2810487-1-philipp.tomsich@vrull.eu> In-Reply-To: From: Philipp Tomsich Date: Fri, 4 Feb 2022 09:43:17 +0100 Message-ID: Subject: Re: [PATCH v1] RISC-V: Add mtinst and mtval2 CSRs (defined in priv-spec 1.12) To: Tsukasa OI Cc: binutils@sourceware.org, Kito Cheng , Vineet Gupta , Paul Donahue Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2022 08:43:31 -0000 Tsukasa, Last time I heard, you did not have copyright assignments in place. Until this is resolved, I can not look at your patches to not lose the ability to independently develop if needed (our community has been burnt in this regard before). It feels like our entire community fell short on the current 2.38 release, as we are missing support for some of the Priv 1.12 (i.e., Ss1-12 and Sm1-12, as the official nomenclature for these extensions is) content. Given that Priv 1.12 was ratified last year, it is pity that it will not be contained in a full release for another half year. I created and sent this patch in response to an issue reported by a DV team =E2=80=94 this is a strong reminder that every time upstream enablemen= t lags behind, many members of the RISC-V ecosystem will be tracking issues and spend time on maintaining forks. On Fri, 4 Feb 2022 at 05:15, Tsukasa OI wrot= e: > > I submitted similar changes in a larger patchset. If the review of mine > takes too much time, it would be good to apply yours first. > > Also, it would be always happy to see that we solve the same problem the > same way (the only difference between ours I see is letter casing). With the addition of opcodes and CSRs, there's really only one way to do it (except for insignificant changes). So, I'm glad that there's no significant difference: I'll chalk that up as a passed review ;-) Thanks, Philipp.